Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(518)

Issue 336840043: ui/gtk3: Increase timeout of window filter in PropertyPanel (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 5 months ago by fujiwara
Modified:
6 years, 5 months ago
Reviewers:
shawn.p.huang, Peng
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

ui/gtk3: Increase timeout of window filter in PropertyPanel The latest Plasma desktop takes more time to generate _NET_WORKAREA atom and this patch increases the timeout from 1 minute to 5 minutes so that PropertyPanel locate within the workarea. Committed: 53d1f9e92666c77ec13efaeb5f330d05332a8360

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated with comment #2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M ui/gtk3/propertypanel.vala View 1 3 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 4
fujiwara
6 years, 5 months ago (2017-10-19 13:24:16 UTC) #1
Peng
LGTM with a nit https://codereview.appspot.com/336840043/diff/1/ui/gtk3/propertypanel.vala File ui/gtk3/propertypanel.vala (right): https://codereview.appspot.com/336840043/diff/1/ui/gtk3/propertypanel.vala#newcode43 ui/gtk3/propertypanel.vala:43: private const uint MONITOR_NET_WORKAREA_TIMEOUT = ...
6 years, 5 months ago (2017-10-19 14:36:30 UTC) #2
fujiwara
https://codereview.appspot.com/336840043/diff/1/ui/gtk3/propertypanel.vala File ui/gtk3/propertypanel.vala (right): https://codereview.appspot.com/336840043/diff/1/ui/gtk3/propertypanel.vala#newcode43 ui/gtk3/propertypanel.vala:43: private const uint MONITOR_NET_WORKAREA_TIMEOUT = 300000; On 2017/10/19 14:36:30, ...
6 years, 5 months ago (2017-10-20 02:34:46 UTC) #3
fujiwara
6 years, 5 months ago (2017-10-20 02:35:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
53d1f9e92666c77ec13efaeb5f330d05332a8360 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b