Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(104)

Issue 336590043: add glyphs for 256th, 512th and 1024th flags and rests

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 months, 4 weeks ago by Malte Meyn
Modified:
8 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

add glyphs for 256th, 512th and 1024th flags and rests This post on lilypond-user asks for small rhythmic values (though it doesn’t explicitely mention rests and unbeamed/flagged notes): https://lists.gnu.org/archive/html/lilypond-user/2018-02/msg00614.html 1024th is the shortest duration suggested by SMuFL. Needs special focus in review: • forms of downstem flags Needs improvement but I don’t know how to do: • dot position for very short rests (see regtest) Contains also: • adjust stem lengths for 256th, 512th, and 1024th flags • Notation Reference: change shortest value from 128th to 1024th • add very short rests to regtest

Patch Set 1 #

Patch Set 2 : add Changes entry, add rests to other regtests too, fix dot positions for rests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+675 lines, -148 lines) Patch
M Documentation/changes.tely View 1 1 chunk +12 lines, -0 lines 0 comments Download
M Documentation/notation/rhythms.itely View 3 chunks +3 lines, -3 lines 0 comments Download
M input/regression/markup-rest.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/markup-rest-styles.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/rest.ly View 2 chunks +3 lines, -3 lines 0 comments Download
M mf/feta-flags.mf View 4 chunks +294 lines, -0 lines 0 comments Download
M mf/feta-rests.mf View 2 chunks +211 lines, -1 line 0 comments Download
M ps/encodingdefs.ps View 2 chunks +137 lines, -126 lines 0 comments Download
M scm/define-grobs.scm View 1 chunk +2 lines, -2 lines 0 comments Download
M scm/output-lib.scm View 1 1 chunk +9 lines, -9 lines 0 comments Download

Messages

Total messages: 10
thomasmorley651
I suggest to update regtests ‘markup-rest.ly’ and ‘markup-rest-styles.ly’ as well. If no glyph for a ...
8 months, 4 weeks ago (2018-02-21 22:44:42 UTC) #1
Malte Meyn
On 2018/02/21 22:44:42, thomasmorley651 wrote: > I suggest to update regtests ‘markup-rest.ly’ and ‘markup-rest-styles.ly’ as ...
8 months, 4 weeks ago (2018-02-22 15:39:27 UTC) #2
lemzwerg
LGTM, thanks!
8 months, 3 weeks ago (2018-02-23 07:30:00 UTC) #3
Be-3
On 2018/02/23 07:30:00, lemzwerg wrote: > LGTM, thanks! In my opinion, there's a misplacement of ...
8 months, 3 weeks ago (2018-02-23 11:18:38 UTC) #4
Malte Meyn
On 2018/02/23 11:18:38, Be-3 wrote: > On 2018/02/23 07:30:00, lemzwerg wrote: > > LGTM, thanks! ...
8 months, 3 weeks ago (2018-02-23 11:41:13 UTC) #5
pkx166h
On 2018/02/23 11:18:38, Be-3 wrote: > On 2018/02/23 07:30:00, lemzwerg wrote: > > LGTM, thanks! ...
8 months, 3 weeks ago (2018-02-23 12:09:34 UTC) #6
Malte Meyn
On 2018/02/23 12:09:34, pkx166h wrote: > Are we simply seeing another symptom of something I ...
8 months, 3 weeks ago (2018-02-23 12:52:29 UTC) #7
Be-3
On 2018/02/23 11:41:13, Malte Meyn wrote: > Probably that won’t be enough, it has to ...
8 months, 3 weeks ago (2018-02-23 16:14:59 UTC) #8
Malte Meyn
add Changes entry, add rests to other regtests too, fix dot positions for rests
8 months ago (2018-03-18 13:16:42 UTC) #9
Malte Meyn
8 months ago (2018-03-18 13:18:57 UTC) #10
I’ll change the width of 8th and 16th flags (see
https://lists.gnu.org/archive/html/lilypond-devel/2018-02/msg00107.html) in
another issue.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b