Issue 336530043: [plaso] Refactored timestamp checks in tests #1701

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 336530043: [plaso] Refactored timestamp checks in tests #1701 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 2 months ago by Joachim Metz

Modified:
6 years, 2 months ago

Reviewers:
jberggren, onager

CC:
romaing, kiddi, log2timeline-dev_googlegroups.com, aaronp

Visibility:
Public.

More Reviews

Description

[plaso] Refactored timestamp checks in tests #1701

Patch Set 1 #

Patch Set 2 : Refactored timestamp checks in tests #1701 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -133 lines)			Patch
M	tests/parsers/winreg_plugins/sam_users.py	View	1	3 chunks	+8 lines, -13 lines	0 comments	Download
M	tests/parsers/winreg_plugins/services.py	View	1	5 chunks	+4 lines, -12 lines	0 comments	Download
M	tests/parsers/winreg_plugins/shutdown.py	View	1	2 chunks	+1 line, -4 lines	0 comments	Download
M	tests/parsers/winreg_plugins/task_scheduler.py	View	1	3 chunks	+2 lines, -7 lines	0 comments	Download
M	tests/parsers/winreg_plugins/terminal_server.py	View	1	3 chunks	+2 lines, -5 lines	0 comments	Download
M	tests/parsers/winreg_plugins/timezone.py	View	1	3 chunks	+2 lines, -6 lines	0 comments	Download
M	tests/parsers/winreg_plugins/typedurls.py	View	1	3 chunks	+2 lines, -7 lines	0 comments	Download
M	tests/parsers/winreg_plugins/usb.py	View	1	2 chunks	+1 line, -5 lines	0 comments	Download
M	tests/parsers/winreg_plugins/usbstor.py	View	1	2 chunks	+1 line, -4 lines	0 comments	Download
M	tests/parsers/winreg_plugins/userassist.py	View	1	3 chunks	+3 lines, -8 lines	0 comments	Download
M	tests/parsers/winreg_plugins/windows_version.py	View	1	4 chunks	+6 lines, -9 lines	0 comments	Download
M	tests/parsers/winreg_plugins/winlogon.py	View	1	3 chunks	+2 lines, -5 lines	0 comments	Download
M	tests/parsers/winreg_plugins/winrar.py	View	1	2 chunks	+1 line, -3 lines	0 comments	Download
M	tests/parsers/winrestore.py	View		2 chunks	+1 line, -4 lines	0 comments	Download
M	tests/parsers/xchatlog.py	View		3 chunks	+6 lines, -10 lines	0 comments	Download
M	tests/parsers/xchatscrollback.py	View		3 chunks	+8 lines, -17 lines	0 comments	Download
M	tests/parsers/zsh_extended_history.py	View		2 chunks	+10 lines, -14 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Joachim Metz

6 years, 2 months ago (2018-02-19 18:36:21 UTC) #4

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close testing6

Expand All Messages | Collapse All Messages