Issue 336230043: FairGameSnitch: we have to register FairGameSnitch to receive latency samples.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 336230043: FairGameSnitch: we have to register FairGameSnitch to receive latency samples.

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 5 months ago by seregibenjamin

Modified:
6 years, 4 months ago

Reviewers:
david.tomic11, tonythomas

CC:
dkostic, kirill.sc, seregibenjamin, cynthiamao122_gmail.com, liangzijie1437_gmail.com

Visibility:
Public.

More Reviews

Description

FairGameSnitch: we have to register FairGameSnitch to receive latency samples. BUG= The bug was that updateScores() never got called because we don't have UPDATE_INTERVAL in this implementation therefore the registration process should take place in the constructor.