Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(734)

Issue 336230043: FairGameSnitch: we have to register FairGameSnitch to receive latency samples.

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 5 days ago by seregibenjamin
Modified:
6 days ago
CC:
dkostic, kirill.sc, seregibenjamin, cynthiamao122_gmail.com, liangzijie1437_gmail.com
Visibility:
Public.

Description

FairGameSnitch: we have to register FairGameSnitch to receive latency samples. BUG= The bug was that updateScores() never got called because we don't have UPDATE_INTERVAL in this implementation therefore the registration process should take place in the constructor.

Patch Set 1 #

Patch Set 2 : FairGameSnitch: added reset interval. #

Patch Set 3 : FairGameSnitch: compare newBase against the old base. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/java/org/apache/cassandra/locator/FairGameSnitch.java View 1 2 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7
seregibenjamin
2 weeks, 5 days ago (2017-11-22 12:13:43 UTC) #1
david.tomic11
On 2017/11/22 12:13:43, seregibenjamin wrote: looks legit
2 weeks, 5 days ago (2017-11-22 12:37:13 UTC) #2
seregibenjamin
2 weeks, 1 day ago (2017-11-25 15:34:56 UTC) #3
david.tomic11
+1 LGTM
2 weeks, 1 day ago (2017-11-25 15:42:36 UTC) #4
seregibenjamin
6 days ago (2017-12-05 14:14:52 UTC) #5
david.tomic11
On 2017/12/05 14:14:52, seregibenjamin wrote: +1 LGTM
6 days ago (2017-12-05 14:21:46 UTC) #6
tonythomas
6 days ago (2017-12-05 14:25:33 UTC) #7
+1 LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 204d58d