Code updated.
LGTM
PTAL, had to create a work-around for a limitation in Python 2.7 version of pysqlite
https://codereview.appspot.com/336130043/diff/20001/plaso/parsers/sqlite_plug... File plaso/parsers/sqlite_plugins/interface.py (right): https://codereview.appspot.com/336130043/diff/20001/plaso/parsers/sqlite_plug... plaso/parsers/sqlite_plugins/interface.py:87: parser_mediator, row, cache=cache, database=database, query=query) Query can't be None here now, please refactor. https://codereview.appspot.com/336130043/diff/40001/plaso/parsers/sqlite_plug... File plaso/parsers/sqlite_plugins/interface.py (right): https://codereview.appspot.com/336130043/diff/40001/plaso/parsers/sqlite_plug... plaso/parsers/sqlite_plugins/interface.py:44: query_hash (int): hash of the query. Please add change to "unique identifier of the query that produced the row" or something similar. https://codereview.appspot.com/336130043/diff/40001/plaso/parsers/sqlite_plug... plaso/parsers/sqlite_plugins/interface.py:161: parser_mediator, row, cache=cache, database=database_wal, Query can't be none here now, please refactor.
https://codereview.appspot.com/336130043/diff/40001/plaso/parsers/sqlite_plug... File plaso/parsers/sqlite_plugins/interface.py (right): https://codereview.appspot.com/336130043/diff/40001/plaso/parsers/sqlite_plug... plaso/parsers/sqlite_plugins/interface.py:44: query_hash (int): hash of the query. On 2017/11/17 15:50:02, onager wrote: > Please add change to "unique identifier of the query that produced the row" or > something similar. Done. https://codereview.appspot.com/336130043/diff/40001/plaso/parsers/sqlite_plug... plaso/parsers/sqlite_plugins/interface.py:161: parser_mediator, row, cache=cache, database=database_wal, I opt to do that in a follow up CL
Changes have been merged with master branch. To close the review and clean up the feature branch you can run: python ./utils/review.py close unicode2
