Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1170)

Issue 336130043: [plaso] Made Unicode strings the default in SQLite parser plugins #1268 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 5 days ago by Joachim Metz
Modified:
3 days, 23 hours ago
Reviewers:
aaronp, onager
CC:
jberggren, romaing, kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[plaso] Made Unicode strings the default in SQLite parser plugins #1268

Patch Set 1 : Made Unicode strings the default in SQLite parser plugins #1268 #

Total comments: 1

Patch Set 2 : Made Unicode strings the default in SQLite parser plugins #1268 #

Total comments: 4

Patch Set 3 : Changes after review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1903 lines, -1789 lines) Patch
M plaso/parsers/plugins.py View 1 1 chunk +3 lines, -7 lines 0 comments Download
M plaso/parsers/sqlite.py View 1 2 chunks +17 lines, -13 lines 0 comments Download
M plaso/parsers/sqlite_plugins/android_calls.py View 1 5 chunks +123 lines, -121 lines 0 comments Download
M plaso/parsers/sqlite_plugins/android_sms.py View 1 4 chunks +92 lines, -87 lines 0 comments Download
M plaso/parsers/sqlite_plugins/android_webview.py View 1 4 chunks +44 lines, -43 lines 0 comments Download
M plaso/parsers/sqlite_plugins/android_webviewcache.py View 1 4 chunks +27 lines, -23 lines 0 comments Download
M plaso/parsers/sqlite_plugins/appusage.py View 1 4 chunks +22 lines, -19 lines 0 comments Download
M plaso/parsers/sqlite_plugins/chrome.py View 1 11 chunks +148 lines, -144 lines 0 comments Download
M plaso/parsers/sqlite_plugins/chrome_cookies.py View 1 5 chunks +50 lines, -44 lines 0 comments Download
M plaso/parsers/sqlite_plugins/chrome_extension_activity.py View 1 4 chunks +33 lines, -32 lines 0 comments Download
M plaso/parsers/sqlite_plugins/firefox.py View 1 20 chunks +222 lines, -213 lines 0 comments Download
M plaso/parsers/sqlite_plugins/firefox_cookies.py View 1 6 chunks +34 lines, -33 lines 0 comments Download
M plaso/parsers/sqlite_plugins/gdrive.py View 1 9 chunks +92 lines, -88 lines 0 comments Download
M plaso/parsers/sqlite_plugins/imessage.py View 1 4 chunks +85 lines, -83 lines 0 comments Download
M plaso/parsers/sqlite_plugins/interface.py View 1 2 12 chunks +58 lines, -22 lines 0 comments Download
M plaso/parsers/sqlite_plugins/kik_ios.py View 1 4 chunks +78 lines, -76 lines 0 comments Download
M plaso/parsers/sqlite_plugins/ls_quarantine.py View 1 4 chunks +23 lines, -22 lines 0 comments Download
M plaso/parsers/sqlite_plugins/mac_document_versions.py View 1 5 chunks +42 lines, -37 lines 0 comments Download
M plaso/parsers/sqlite_plugins/mackeeper_cache.py View 1 8 chunks +92 lines, -90 lines 0 comments Download
M plaso/parsers/sqlite_plugins/skype.py View 1 14 chunks +426 lines, -407 lines 0 comments Download
M plaso/parsers/sqlite_plugins/twitter_ios.py View 1 8 chunks +121 lines, -116 lines 0 comments Download
M plaso/parsers/sqlite_plugins/zeitgeist.py View 1 4 chunks +71 lines, -69 lines 0 comments Download

Messages

Total messages: 11
Joachim Metz
1 week, 5 days ago (2017-11-10 06:12:12 UTC) #1
Joachim Metz
Code updated.
1 week, 5 days ago (2017-11-10 06:27:08 UTC) #2
onager
LGTM
1 week, 2 days ago (2017-11-13 11:21:10 UTC) #3
aaronp
LGTM
1 week ago (2017-11-14 15:42:19 UTC) #4
Joachim Metz
Code updated.
5 days, 5 hours ago (2017-11-17 07:05:09 UTC) #5
Joachim Metz
PTAL, had to create a work-around for a limitation in Python 2.7 version of pysqlite
5 days, 5 hours ago (2017-11-17 07:23:38 UTC) #6
onager
https://codereview.appspot.com/336130043/diff/20001/plaso/parsers/sqlite_plugins/interface.py File plaso/parsers/sqlite_plugins/interface.py (right): https://codereview.appspot.com/336130043/diff/20001/plaso/parsers/sqlite_plugins/interface.py#newcode87 plaso/parsers/sqlite_plugins/interface.py:87: parser_mediator, row, cache=cache, database=database, query=query) Query can't be None ...
4 days, 21 hours ago (2017-11-17 15:50:02 UTC) #7
Joachim Metz
https://codereview.appspot.com/336130043/diff/40001/plaso/parsers/sqlite_plugins/interface.py File plaso/parsers/sqlite_plugins/interface.py (right): https://codereview.appspot.com/336130043/diff/40001/plaso/parsers/sqlite_plugins/interface.py#newcode44 plaso/parsers/sqlite_plugins/interface.py:44: query_hash (int): hash of the query. On 2017/11/17 15:50:02, ...
4 days, 4 hours ago (2017-11-18 08:37:19 UTC) #8
Joachim Metz
Code updated.
4 days, 4 hours ago (2017-11-18 08:41:49 UTC) #9
onager
LGTM
4 days, 2 hours ago (2017-11-18 10:28:42 UTC) #10
Joachim Metz
4 days ago (2017-11-18 12:45:31 UTC) #11
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close unicode2
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4