[plaso] Added additional import tests

[plaso] Added additional import tests

[Joachim Metz, 2018-03-20 19:58:35]

https://codereview.appspot.com/335690043/diff/1/plaso/containers/__init__.py
File plaso/containers/__init__.py (right):

https://codereview.appspot.com/335690043/diff/1/plaso/containers/__init__.py#...
plaso/containers/__init__.py:2: """This file contains imports each file defining
attribute container types."""
"""This file imports source files that register an attribute container type."""

https://codereview.appspot.com/335690043/diff/1/plaso/containers/__init__.py#...
plaso/containers/__init__.py:9: from plaso.containers import plist_event
no need the import the files that do not register an attribute container

https://codereview.appspot.com/335690043/diff/1/plaso/containers/analyzer_res...
File plaso/containers/analyzer_result.py (right):

https://codereview.appspot.com/335690043/diff/1/plaso/containers/analyzer_res...
plaso/containers/analyzer_result.py:31: 
+ 1 white line

https://codereview.appspot.com/335690043/diff/1/plaso/formatters/init_imports.py
File plaso/formatters/init_imports.py (right):

https://codereview.appspot.com/335690043/diff/1/plaso/formatters/init_imports...
plaso/formatters/init_imports.py:26: if __name__ == '__main__':
shouldn't this be in the tests sub-directory ?

https://codereview.appspot.com/335690043/diff/1/tests/test_lib.py
File tests/test_lib.py (right):

https://codereview.appspot.com/335690043/diff/1/tests/test_lib.py#newcode108
tests/test_lib.py:108: 
+ 1 white line

https://codereview.appspot.com/335690043/diff/1/tests/test_lib.py#newcode114
tests/test_lib.py:114: 
- 1 white line

[onager, 2018-03-24 20:47:28]

Code updated.

[onager, 2018-03-24 21:04:58]

Code updated.

[onager, 2018-03-24 21:09:32]

https://codereview.appspot.com/335690043/diff/1/plaso/containers/__init__.py
File plaso/containers/__init__.py (right):

https://codereview.appspot.com/335690043/diff/1/plaso/containers/__init__.py#...
plaso/containers/__init__.py:2: """This file contains imports each file defining
attribute container types."""
On 2018/03/20 19:58:35, Joachim Metz wrote:
> """This file imports source files that register an attribute container
type."""

Done.

https://codereview.appspot.com/335690043/diff/1/plaso/containers/__init__.py#...
plaso/containers/__init__.py:9: from plaso.containers import plist_event
On 2018/03/20 19:58:35, Joachim Metz wrote:
> no need the import the files that do not register an attribute container

Done.

https://codereview.appspot.com/335690043/diff/1/plaso/containers/analyzer_res...
File plaso/containers/analyzer_result.py (right):

https://codereview.appspot.com/335690043/diff/1/plaso/containers/analyzer_res...
plaso/containers/analyzer_result.py:31: 
On 2018/03/20 19:58:35, Joachim Metz wrote:
> + 1 white line

Done.

https://codereview.appspot.com/335690043/diff/1/plaso/formatters/init_imports.py
File plaso/formatters/init_imports.py (right):

https://codereview.appspot.com/335690043/diff/1/plaso/formatters/init_imports...
plaso/formatters/init_imports.py:26: if __name__ == '__main__':
On 2018/03/20 19:58:35, Joachim Metz wrote:
> shouldn't this be in the tests sub-directory ?

Done.

https://codereview.appspot.com/335690043/diff/1/tests/test_lib.py
File tests/test_lib.py (right):

https://codereview.appspot.com/335690043/diff/1/tests/test_lib.py#newcode108
tests/test_lib.py:108: 
On 2018/03/20 19:58:35, Joachim Metz wrote:
> + 1 white line

Done.

https://codereview.appspot.com/335690043/diff/1/tests/test_lib.py#newcode114
tests/test_lib.py:114: 
On 2018/03/20 19:58:35, Joachim Metz wrote:
> - 1 white line

Done.

[Joachim Metz, 2018-03-25 10:07:32]

Please merge and rebase with upstream and some remaining nits.

https://codereview.appspot.com/335690043/diff/40001/plaso/analysis/__init__.py
File plaso/analysis/__init__.py (right):

https://codereview.appspot.com/335690043/diff/40001/plaso/analysis/__init__.p...
plaso/analysis/__init__.py:2: """This file imports python modules that register
analysis plugins."""
python -> Python

https://codereview.appspot.com/335690043/diff/40001/plaso/analyzers/__init__.py
File plaso/analyzers/__init__.py (right):

https://codereview.appspot.com/335690043/diff/40001/plaso/analyzers/__init__....
plaso/analyzers/__init__.py:2: """This file imports python modules that register
analyzers."""
python -> Python

https://codereview.appspot.com/335690043/diff/40001/plaso/analyzers/hashers/_...
File plaso/analyzers/hashers/__init__.py (right):

https://codereview.appspot.com/335690043/diff/40001/plaso/analyzers/hashers/_...
plaso/analyzers/hashers/__init__.py:2: """This file imports python modules that
register hashers."""
python -> Python

https://codereview.appspot.com/335690043/diff/40001/plaso/cli/helpers/__init_...
File plaso/cli/helpers/__init__.py (right):

https://codereview.appspot.com/335690043/diff/40001/plaso/cli/helpers/__init_...
plaso/cli/helpers/__init__.py:2: """This file imports python modules that
register CLI helpers."""
python -> Python

https://codereview.appspot.com/335690043/diff/40001/plaso/containers/__init__.py
File plaso/containers/__init__.py (right):

https://codereview.appspot.com/335690043/diff/40001/plaso/containers/__init__...
plaso/containers/__init__.py:2: """This file imports python modules that
register attribute container types."""
python -> Python

https://codereview.appspot.com/335690043/diff/40001/plaso/containers/__init__...
plaso/containers/__init__.py:14: # These modules define attribute container
types, but don't register them.
I opt to change to:

These modules define attribute containers that inherit from other attribute
containers but do not register attribute containers themselves. So there is no
need to import them.

https://codereview.appspot.com/335690043/diff/40001/plaso/filters/__init__.py
File plaso/filters/__init__.py (right):

https://codereview.appspot.com/335690043/diff/40001/plaso/filters/__init__.py...
plaso/filters/__init__.py:2: """This file imports python modules that register
filters."""
python -> Python

https://codereview.appspot.com/335690043/diff/40001/plaso/output/__init__.py
File plaso/output/__init__.py (right):

https://codereview.appspot.com/335690043/diff/40001/plaso/output/__init__.py#...
plaso/output/__init__.py:2: """This file imports python modules that register
output modules."""
python -> Python

https://codereview.appspot.com/335690043/diff/40001/plaso/output/__init__.py#...
plaso/output/__init__.py:19: # used by output modules in other python modules.
python => Python

or just remove python, seeing that it is omitted elsewhere.

https://codereview.appspot.com/335690043/diff/40001/plaso/parsers/__init__.py
File plaso/parsers/__init__.py (right):

https://codereview.appspot.com/335690043/diff/40001/plaso/parsers/__init__.py...
plaso/parsers/__init__.py:2: """This file imports python modules that register
parsers."""
python -> Python

https://codereview.appspot.com/335690043/diff/40001/tests/test_lib.py
File tests/test_lib.py (right):

https://codereview.appspot.com/335690043/diff/40001/tests/test_lib.py#newcode107
tests/test_lib.py:107: 
+ white line

https://codereview.appspot.com/335690043/diff/40001/tests/test_lib.py#newcode109
tests/test_lib.py:109: """Super class for tests that check modules are imported
correctly."""
Base class is used elsewhere instead of super class. Hence I opt to change Super
=> Base

https://codereview.appspot.com/335690043/diff/40001/tests/test_lib.py#newcode112
tests/test_lib.py:112: 
- white line

[onager, 2018-03-28 22:58:56]

Code updated.

[onager, 2018-03-28 22:59:26]

https://codereview.appspot.com/335690043/diff/40001/plaso/analysis/__init__.py
File plaso/analysis/__init__.py (right):

https://codereview.appspot.com/335690043/diff/40001/plaso/analysis/__init__.p...
plaso/analysis/__init__.py:2: """This file imports python modules that register
analysis plugins."""
On 2018/03/25 10:07:31, Joachim Metz wrote:
> python -> Python

Done.

https://codereview.appspot.com/335690043/diff/40001/plaso/analyzers/__init__.py
File plaso/analyzers/__init__.py (right):

https://codereview.appspot.com/335690043/diff/40001/plaso/analyzers/__init__....
plaso/analyzers/__init__.py:2: """This file imports python modules that register
analyzers."""
On 2018/03/25 10:07:31, Joachim Metz wrote:
> python -> Python

Done.

https://codereview.appspot.com/335690043/diff/40001/plaso/analyzers/hashers/_...
File plaso/analyzers/hashers/__init__.py (right):

https://codereview.appspot.com/335690043/diff/40001/plaso/analyzers/hashers/_...
plaso/analyzers/hashers/__init__.py:2: """This file imports python modules that
register hashers."""
On 2018/03/25 10:07:31, Joachim Metz wrote:
> python -> Python

Done.

https://codereview.appspot.com/335690043/diff/40001/plaso/cli/helpers/__init_...
File plaso/cli/helpers/__init__.py (right):

https://codereview.appspot.com/335690043/diff/40001/plaso/cli/helpers/__init_...
plaso/cli/helpers/__init__.py:2: """This file imports python modules that
register CLI helpers."""
On 2018/03/25 10:07:31, Joachim Metz wrote:
> python -> Python

Done.

https://codereview.appspot.com/335690043/diff/40001/plaso/containers/__init__.py
File plaso/containers/__init__.py (right):

https://codereview.appspot.com/335690043/diff/40001/plaso/containers/__init__...
plaso/containers/__init__.py:2: """This file imports python modules that
register attribute container types."""
On 2018/03/25 10:07:31, Joachim Metz wrote:
> python -> Python

Done.

https://codereview.appspot.com/335690043/diff/40001/plaso/containers/__init__...
plaso/containers/__init__.py:14: # These modules define attribute container
types, but don't register them.
On 2018/03/25 10:07:31, Joachim Metz wrote:
> I opt to change to:
> 
> These modules define attribute containers that inherit from other attribute
> containers but do not register attribute containers themselves. So there is no
> need to import them.

Done.

https://codereview.appspot.com/335690043/diff/40001/plaso/filters/__init__.py
File plaso/filters/__init__.py (right):

https://codereview.appspot.com/335690043/diff/40001/plaso/filters/__init__.py...
plaso/filters/__init__.py:2: """This file imports python modules that register
filters."""
On 2018/03/25 10:07:32, Joachim Metz wrote:
> python -> Python

Done.

https://codereview.appspot.com/335690043/diff/40001/plaso/output/__init__.py
File plaso/output/__init__.py (right):

https://codereview.appspot.com/335690043/diff/40001/plaso/output/__init__.py#...
plaso/output/__init__.py:2: """This file imports python modules that register
output modules."""
On 2018/03/25 10:07:32, Joachim Metz wrote:
> python -> Python

Done.

https://codereview.appspot.com/335690043/diff/40001/plaso/output/__init__.py#...
plaso/output/__init__.py:19: # used by output modules in other python modules.
On 2018/03/25 10:07:32, Joachim Metz wrote:
> python => Python
> 
> or just remove python, seeing that it is omitted elsewhere.

Done.

https://codereview.appspot.com/335690043/diff/40001/plaso/parsers/__init__.py
File plaso/parsers/__init__.py (right):

https://codereview.appspot.com/335690043/diff/40001/plaso/parsers/__init__.py...
plaso/parsers/__init__.py:2: """This file imports python modules that register
parsers."""
On 2018/03/25 10:07:32, Joachim Metz wrote:
> python -> Python

Done.

https://codereview.appspot.com/335690043/diff/40001/tests/test_lib.py
File tests/test_lib.py (right):

https://codereview.appspot.com/335690043/diff/40001/tests/test_lib.py#newcode107
tests/test_lib.py:107: 
On 2018/03/25 10:07:32, Joachim Metz wrote:
> + white line

Done.

https://codereview.appspot.com/335690043/diff/40001/tests/test_lib.py#newcode109
tests/test_lib.py:109: """Super class for tests that check modules are imported
correctly."""
On 2018/03/25 10:07:32, Joachim Metz wrote:
> Base class is used elsewhere instead of super class. Hence I opt to change
Super
> => Base

Done.

https://codereview.appspot.com/335690043/diff/40001/tests/test_lib.py#newcode112
tests/test_lib.py:112: 
On 2018/03/25 10:07:32, Joachim Metz wrote:
> - white line

Done.

[Joachim Metz, 2018-03-29 05:51:46]

LGTM