Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2466)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 335570043: [dfvfs] Moved resolver helpers to reduce cyclic imports (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 2 months ago by Joachim Metz
Modified:
6 years, 1 month ago
Reviewers:
onager
CC:
kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[dfvfs] Moved resolver helpers to reduce cyclic imports * split the helper management functionality from the resolver * moved the helpers to different directory * changed imports Depends on: * https://codereview.appspot.com/337550043/

Patch Set 1 : Moved resolver helpers to reduce cyclic imports #

Unified diffs Side-by-side diffs Delta from patch set Stats (+414 lines, -2106 lines) Patch
M dfvfs/resolver/__init__.py View 1 chunk +0 lines, -78 lines 0 comments Download
D dfvfs/resolver/bde_resolver_helper.py View 1 chunk +0 lines, -43 lines 0 comments Download
D dfvfs/resolver/compressed_stream_resolver_helper.py View 1 chunk +0 lines, -44 lines 0 comments Download
D dfvfs/resolver/cpio_resolver_helper.py View 1 chunk +0 lines, -44 lines 0 comments Download
D dfvfs/resolver/data_range_resolver_helper.py View 1 chunk +0 lines, -44 lines 0 comments Download
D dfvfs/resolver/encoded_stream_resolver_helper.py View 1 chunk +0 lines, -44 lines 0 comments Download
D dfvfs/resolver/encrypted_stream_resolver_helper.py View 1 chunk +0 lines, -44 lines 0 comments Download
D dfvfs/resolver/ewf_resolver_helper.py View 1 chunk +0 lines, -31 lines 0 comments Download
D dfvfs/resolver/fake_resolver_helper.py View 1 chunk +0 lines, -20 lines 0 comments Download
D dfvfs/resolver/fvde_resolver_helper.py View 1 chunk +0 lines, -43 lines 0 comments Download
D dfvfs/resolver/gzip_resolver_helper.py View 1 chunk +0 lines, -43 lines 0 comments Download
D dfvfs/resolver/lvm_resolver_helper.py View 1 chunk +0 lines, -43 lines 0 comments Download
D dfvfs/resolver/ntfs_resolver_helper.py View 1 chunk +0 lines, -43 lines 0 comments Download
D dfvfs/resolver/os_resolver_helper.py View 1 chunk +0 lines, -43 lines 0 comments Download
D dfvfs/resolver/qcow_resolver_helper.py View 1 chunk +0 lines, -31 lines 0 comments Download
D dfvfs/resolver/raw_resolver_helper.py View 1 chunk +0 lines, -31 lines 0 comments Download
M dfvfs/resolver/resolver.py View 6 chunks +15 lines, -46 lines 0 comments Download
D dfvfs/resolver/resolver_helper.py View 1 chunk +0 lines, -52 lines 0 comments Download
D dfvfs/resolver/sqlite_blob_resolver_helper.py View 1 chunk +0 lines, -44 lines 0 comments Download
D dfvfs/resolver/tar_resolver_helper.py View 1 chunk +0 lines, -43 lines 0 comments Download
D dfvfs/resolver/tsk_partition_resolver_helper.py View 1 chunk +0 lines, -45 lines 0 comments Download
D dfvfs/resolver/tsk_resolver_helper.py View 1 chunk +0 lines, -43 lines 0 comments Download
D dfvfs/resolver/vhdi_resolver_helper.py View 1 chunk +0 lines, -31 lines 0 comments Download
D dfvfs/resolver/vmdk_resolver_helper.py View 1 chunk +0 lines, -31 lines 0 comments Download
D dfvfs/resolver/vshadow_resolver_helper.py View 1 chunk +0 lines, -43 lines 0 comments Download
D dfvfs/resolver/zip_resolver_helper.py View 1 chunk +0 lines, -43 lines 0 comments Download
A dfvfs/resolver_helpers/__init__.py View 1 chunk +79 lines, -0 lines 0 comments Download
A + dfvfs/resolver_helpers/bde_resolver_helper.py View 3 chunks +7 lines, -9 lines 0 comments Download
A + dfvfs/resolver_helpers/compressed_stream_resolver_helper.py View 3 chunks +7 lines, -9 lines 0 comments Download
A + dfvfs/resolver_helpers/cpio_resolver_helper.py View 3 chunks +7 lines, -9 lines 0 comments Download
A + dfvfs/resolver_helpers/data_range_resolver_helper.py View 3 chunks +7 lines, -10 lines 0 comments Download
A + dfvfs/resolver_helpers/encoded_stream_resolver_helper.py View 3 chunks +7 lines, -10 lines 0 comments Download
A + dfvfs/resolver_helpers/encrypted_stream_resolver_helper.py View 3 chunks +7 lines, -9 lines 0 comments Download
A + dfvfs/resolver_helpers/ewf_resolver_helper.py View 2 chunks +5 lines, -7 lines 0 comments Download
A + dfvfs/resolver_helpers/fake_resolver_helper.py View 2 chunks +3 lines, -3 lines 0 comments Download
A + dfvfs/resolver_helpers/fvde_resolver_helper.py View 3 chunks +7 lines, -9 lines 0 comments Download
A + dfvfs/resolver_helpers/gzip_resolver_helper.py View 3 chunks +7 lines, -9 lines 0 comments Download
A + dfvfs/resolver_helpers/lvm_resolver_helper.py View 3 chunks +7 lines, -9 lines 0 comments Download
A dfvfs/resolver_helpers/manager.py View 1 chunk +67 lines, -0 lines 0 comments Download
A + dfvfs/resolver_helpers/ntfs_resolver_helper.py View 3 chunks +7 lines, -9 lines 0 comments Download
A + dfvfs/resolver_helpers/os_resolver_helper.py View 3 chunks +7 lines, -9 lines 0 comments Download
A + dfvfs/resolver_helpers/qcow_resolver_helper.py View 2 chunks +5 lines, -7 lines 0 comments Download
A + dfvfs/resolver_helpers/raw_resolver_helper.py View 2 chunks +5 lines, -7 lines 0 comments Download
A + dfvfs/resolver_helpers/resolver_helper.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dfvfs/resolver_helpers/sqlite_blob_resolver_helper.py View 3 chunks +7 lines, -10 lines 0 comments Download
A + dfvfs/resolver_helpers/tar_resolver_helper.py View 3 chunks +7 lines, -9 lines 0 comments Download
A + dfvfs/resolver_helpers/tsk_partition_resolver_helper.py View 3 chunks +7 lines, -11 lines 0 comments Download
A + dfvfs/resolver_helpers/tsk_resolver_helper.py View 3 chunks +7 lines, -9 lines 0 comments Download
A + dfvfs/resolver_helpers/vhdi_resolver_helper.py View 2 chunks +5 lines, -7 lines 0 comments Download
A + dfvfs/resolver_helpers/vmdk_resolver_helper.py View 2 chunks +5 lines, -7 lines 0 comments Download
A + dfvfs/resolver_helpers/vshadow_resolver_helper.py View 3 chunks +7 lines, -9 lines 0 comments Download
A + dfvfs/resolver_helpers/zip_resolver_helper.py View 3 chunks +7 lines, -9 lines 0 comments Download
M dfvfs/serializer/json_serializer.py View 1 chunk +1 line, -0 lines 0 comments Download
M dfvfs/vfs/cpio_file_system.py View 3 chunks +3 lines, -5 lines 0 comments Download
M dfvfs/vfs/lvm_file_system.py View 2 chunks +3 lines, -5 lines 0 comments Download
M dfvfs/vfs/ntfs_file_system.py View 3 chunks +3 lines, -5 lines 0 comments Download
M dfvfs/vfs/tar_file_system.py View 3 chunks +3 lines, -5 lines 0 comments Download
M dfvfs/vfs/tsk_file_system.py View 3 chunks +3 lines, -5 lines 0 comments Download
M dfvfs/vfs/tsk_partition_file_system.py View 3 chunks +3 lines, -5 lines 0 comments Download
M dfvfs/vfs/vshadow_file_system.py View 2 chunks +3 lines, -5 lines 0 comments Download
M dfvfs/vfs/zip_file_system.py View 3 chunks +3 lines, -5 lines 0 comments Download
D tests/resolver/__init__.py View 1 chunk +0 lines, -1 line 0 comments Download
D tests/resolver/bde_resolver_helper.py View 1 chunk +0 lines, -29 lines 0 comments Download
D tests/resolver/compressed_stream_resolver_helper.py View 1 chunk +0 lines, -31 lines 0 comments Download
D tests/resolver/cpio_resolver_helper.py View 1 chunk +0 lines, -29 lines 0 comments Download
D tests/resolver/encoded_stream_resolver_helper.py View 1 chunk +0 lines, -31 lines 0 comments Download
D tests/resolver/encrypted_stream_resolver_helper.py View 1 chunk +0 lines, -31 lines 0 comments Download
D tests/resolver/ewf_resolver_helper.py View 1 chunk +0 lines, -29 lines 0 comments Download
D tests/resolver/fvde_resolver_helper.py View 1 chunk +0 lines, -29 lines 0 comments Download
D tests/resolver/gzip_resolver_helper.py View 1 chunk +0 lines, -29 lines 0 comments Download
D tests/resolver/lvm_resolver_helper.py View 1 chunk +0 lines, -29 lines 0 comments Download
D tests/resolver/ntfs_resolver_helper.py View 1 chunk +0 lines, -29 lines 0 comments Download
D tests/resolver/os_resolver_helper.py View 1 chunk +0 lines, -29 lines 0 comments Download
D tests/resolver/qcow_resolver_helper.py View 1 chunk +0 lines, -29 lines 0 comments Download
D tests/resolver/raw_resolver_helper.py View 1 chunk +0 lines, -29 lines 0 comments Download
D tests/resolver/resolver.py View 1 chunk +0 lines, -38 lines 0 comments Download
D tests/resolver/sqlite_blob_resolver_helper.py View 1 chunk +0 lines, -31 lines 0 comments Download
D tests/resolver/tar_resolver_helper.py View 1 chunk +0 lines, -29 lines 0 comments Download
D tests/resolver/test_lib.py View 1 chunk +0 lines, -81 lines 0 comments Download
D tests/resolver/tsk_partition_resolver_helper.py View 1 chunk +0 lines, -31 lines 0 comments Download
D tests/resolver/tsk_resolver_helper.py View 1 chunk +0 lines, -29 lines 0 comments Download
D tests/resolver/vhdi_resolver_helper.py View 1 chunk +0 lines, -29 lines 0 comments Download
D tests/resolver/vmdk_resolver_helper.py View 1 chunk +0 lines, -29 lines 0 comments Download
D tests/resolver/vshadow_resolver_helper.py View 1 chunk +0 lines, -29 lines 0 comments Download
D tests/resolver/zip_resolver_helper.py View 1 chunk +0 lines, -29 lines 0 comments Download
A + tests/resolver_helpers/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/resolver_helpers/bde_resolver_helper.py View 1 chunk +2 lines, -2 lines 0 comments Download
A + tests/resolver_helpers/compressed_stream_resolver_helper.py View 1 chunk +2 lines, -2 lines 0 comments Download
A + tests/resolver_helpers/cpio_resolver_helper.py View 1 chunk +2 lines, -2 lines 0 comments Download
A + tests/resolver_helpers/encoded_stream_resolver_helper.py View 1 chunk +2 lines, -2 lines 0 comments Download
A + tests/resolver_helpers/encrypted_stream_resolver_helper.py View 1 chunk +2 lines, -2 lines 0 comments Download
A + tests/resolver_helpers/ewf_resolver_helper.py View 1 chunk +2 lines, -2 lines 0 comments Download
A + tests/resolver_helpers/fvde_resolver_helper.py View 1 chunk +2 lines, -2 lines 0 comments Download
A + tests/resolver_helpers/gzip_resolver_helper.py View 1 chunk +2 lines, -2 lines 0 comments Download
A + tests/resolver_helpers/lvm_resolver_helper.py View 1 chunk +2 lines, -2 lines 0 comments Download
A tests/resolver_helpers/manager.py View 1 chunk +40 lines, -0 lines 0 comments Download
A + tests/resolver_helpers/ntfs_resolver_helper.py View 1 chunk +2 lines, -2 lines 0 comments Download
A + tests/resolver_helpers/os_resolver_helper.py View 1 chunk +2 lines, -2 lines 0 comments Download
A + tests/resolver_helpers/qcow_resolver_helper.py View 1 chunk +2 lines, -2 lines 0 comments Download
A + tests/resolver_helpers/raw_resolver_helper.py View 1 chunk +2 lines, -2 lines 0 comments Download
A + tests/resolver_helpers/sqlite_blob_resolver_helper.py View 1 chunk +2 lines, -2 lines 0 comments Download
A + tests/resolver_helpers/tar_resolver_helper.py View 1 chunk +2 lines, -2 lines 0 comments Download
A + tests/resolver_helpers/test_lib.py View 1 chunk +1 line, -1 line 0 comments Download
A + tests/resolver_helpers/tsk_partition_resolver_helper.py View 1 chunk +2 lines, -2 lines 0 comments Download
A + tests/resolver_helpers/tsk_resolver_helper.py View 1 chunk +2 lines, -2 lines 0 comments Download
A + tests/resolver_helpers/vhdi_resolver_helper.py View 1 chunk +2 lines, -2 lines 0 comments Download
A + tests/resolver_helpers/vmdk_resolver_helper.py View 1 chunk +2 lines, -2 lines 0 comments Download
A + tests/resolver_helpers/vshadow_resolver_helper.py View 1 chunk +2 lines, -2 lines 0 comments Download
A + tests/resolver_helpers/zip_resolver_helper.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5
Joachim Metz
6 years, 2 months ago (2018-02-10 08:04:16 UTC) #1
Joachim Metz
Code updated.
6 years, 2 months ago (2018-02-10 08:17:52 UTC) #2
Joachim Metz
Code updated.
6 years, 2 months ago (2018-02-10 09:29:33 UTC) #3
onager
LGTM
6 years, 1 month ago (2018-03-08 11:24:59 UTC) #4
Joachim Metz
6 years, 1 month ago (2018-03-09 00:35:37 UTC) #5 
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close cyclic1
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b