Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(613)

Issue 335520043: Issue 5267: Fix building with a source directory on a different device (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 1 month ago by Dan Eble
Modified:
6 years ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix building with a source directory on a different device https://sourceforge.net/p/testlilyissues/issues/5267/ In configure, check whether hard links between files in the source and build directories can be created. If not, fall back on copying. This supports building with the source and build directories on different devices. Run git diff in the *source* directory. Ignore .DS_Store files created by macOS Finder. (Not part of fixing the build, but mighty convenient for me.)

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -9 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M Documentation/css/GNUmakefile View 1 chunk +2 lines, -2 lines 0 comments Download
M Documentation/pictures/GNUmakefile View 1 chunk +4 lines, -4 lines 0 comments Download
M GNUmakefile.in View 1 chunk +7 lines, -3 lines 0 comments Download
M config.make.in View 1 chunk +1 line, -0 lines 0 comments Download
M configure.ac View 1 chunk +10 lines, -0 lines 2 comments Download

Messages

Total messages: 2
lemzwerg
LGTM, with a single question. https://codereview.appspot.com/335520043/diff/1/configure.ac File configure.ac (right): https://codereview.appspot.com/335520043/diff/1/configure.ac#newcode66 configure.ac:66: AC_MSG_CHECKING([how to replicate source ...
6 years, 1 month ago (2018-02-09 07:59:04 UTC) #1
Dan Eble
6 years, 1 month ago (2018-02-09 22:39:05 UTC) #2
https://codereview.appspot.com/335520043/diff/1/configure.ac
File configure.ac (right):

https://codereview.appspot.com/335520043/diff/1/configure.ac#newcode66
configure.ac:66: AC_MSG_CHECKING([how to replicate source files to build files])
On 2018/02/09 07:59:04, lemzwerg wrote:
> Any reason why you are using hard links instead of soft links?
> And what about using AC_PROG_LN_S instead of this home-brewed macro?

The commands I replaced were hard link commands and I want to minimize the
probability of breaking someone else's build.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b