Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7025)

Issue 335030043: src: Reintroduce the hex mode keybind with an environment variable. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 5 months ago by fujiwara
Modified:
6 years, 5 months ago
Reviewers:
shawn.p.huang, Peng
CC:
aaron_correspondwith.me
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

src: Reintroduce the hex mode keybind with an environment variable This was removed by "Move emoji implementation from IBusEngineSimple to IBusPanel". Reintroduced here behind an environment variable. BUG=https://github.com/ibus/ibus/issues/1961 Committed: 88b9a93d61824ba8b18cc9fc943527937db5e40b

Patch Set 1 #

Patch Set 2 : Added IBUS_ENABLE_CONTROL_SHIFT_U too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/ibusenginesimple.c View 1 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4
fujiwara
6 years, 5 months ago (2017-11-16 08:53:49 UTC) #1
Peng
lgtm
6 years, 5 months ago (2017-11-16 14:49:31 UTC) #2
fujiwara
Added IBUS_ENABLE_CONTROL_SHIFT_U too.
6 years, 5 months ago (2017-11-17 03:22:20 UTC) #3
fujiwara
6 years, 5 months ago (2017-11-17 03:28:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
88b9a93d61824ba8b18cc9fc943527937db5e40b (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b