I see plenty of casts added, 2 questions:
1/ Why? How can we avoid so much casts?
2/ Why did they pop up right now? I have not seen that much casts in your
previous patch sets.
On 2018/03/09 12:16:18, S. Deronne wrote:
> I see plenty of casts added, 2 questions:
>
> 1/ Why? How can we avoid so much casts?
> 2/ Why did they pop up right now? I have not seen that much casts in your
> previous patch sets.
The conservative change is to add a cast rather than try to reword the code.
Adding a cast reduces the possibility of side effects from a code change. All
changes made initially for all modules was to add the cast. Based upon your
comments, the code has been modified to minimize the number of casts.
Issue 334560043: Eliminate Visual Studio compiler warnings
(Closed)
Created 6 years ago by ammo6818-vandals.uidaho.edu
Modified 5 years, 1 month ago
Reviewers: S. Deronne, Tom Henderson
Base URL:
Comments: 17