Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1110)

Issue 334560043: Eliminate Visual Studio compiler warnings

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 months ago by ammo6818-vandals.uidaho.edu
Modified:
8 months, 1 week ago
Visibility:
Public.

Description

Eliminate Visual Studio compiler warnings

Patch Set 1 #

Total comments: 8

Patch Set 2 : Updated patch to minimize changes #

Patch Set 3 : Update per review comments #

Total comments: 9
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M examples/wireless/80211e-txop.cc View 1 2 3 chunks +3 lines, -3 lines 1 comment Download
M examples/wireless/80211n-mimo.cc View 1 chunk +1 line, -1 line 1 comment Download
M examples/wireless/power-adaptation-distance.cc View 1 chunk +1 line, -1 line 1 comment Download
M examples/wireless/power-adaptation-interference.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M examples/wireless/simple-ht-hidden-stations.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M examples/wireless/wifi-aggregation.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M examples/wireless/wifi-hidden-terminal.cc View 1 chunk +1 line, -1 line 1 comment Download
M examples/wireless/wifi-spectrum-per-example.cc View 1 1 chunk +1 line, -1 line 1 comment Download
M examples/wireless/wifi-spectrum-per-interference.cc View 1 1 chunk +2 lines, -2 lines 2 comments Download
M examples/wireless/wifi-spectrum-saturation-example.cc View 1 1 chunk +1 line, -1 line 1 comment Download
M examples/wireless/wifi-timing-attributes.cc View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 6
S. Deronne
I see plenty of casts added, 2 questions: 1/ Why? How can we avoid so ...
9 months ago (2018-03-09 12:16:18 UTC) #1
Tom Henderson
I did not review each one but I think that most if not all casts ...
9 months ago (2018-03-09 16:56:40 UTC) #2
ammo6818-vandals.uidaho.edu
On 2018/03/09 12:16:18, S. Deronne wrote: > I see plenty of casts added, 2 questions: ...
9 months ago (2018-03-11 19:00:44 UTC) #3
ammo6818-vandals.uidaho.edu
Review comments incorporated. https://codereview.appspot.com/334560043/diff/1/examples/wireless/80211e-txop.cc File examples/wireless/80211e-txop.cc (right): https://codereview.appspot.com/334560043/diff/1/examples/wireless/80211e-txop.cc#newcode226 examples/wireless/80211e-txop.cc:226: serverAppA.Stop (Seconds (static_cast<double> (simulationTime + 1))); ...
9 months ago (2018-03-11 19:01:18 UTC) #4
S. Deronne
https://codereview.appspot.com/334560043/diff/40001/examples/wireless/80211e-txop.cc File examples/wireless/80211e-txop.cc (right): https://codereview.appspot.com/334560043/diff/40001/examples/wireless/80211e-txop.cc#newcode62 examples/wireless/80211e-txop.cc:62: double simulationTime = 10.0; //seconds is .0 needed? If ...
8 months, 2 weeks ago (2018-03-27 10:36:17 UTC) #5
S. Deronne
8 months, 1 week ago (2018-04-03 20:25:33 UTC) #6
Robert, could you update with the latest ns-3-dev and address my comments?
Thanks.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b