Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(270)

Issue 334500044: [dfvfs] Added GetDate method to TSKTime (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months ago by Joachim Metz
Modified:
6 months ago
Reviewers:
onager
CC:
kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[dfvfs] Added GetDate method to TSKTime

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated dependency information #

Total comments: 2

Patch Set 3 : Disabled Python 3 tox test #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -53 lines) Patch
M .travis.yml View 1 2 1 chunk +1 line, -0 lines 2 comments Download
M config/dpkg/control View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M dependencies.ini View 1 2 1 chunk +1 line, -1 line 0 comments Download
M dfvfs/vfs/tsk_file_entry.py View 1 2 6 chunks +83 lines, -48 lines 2 comments Download
M requirements.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M setup.cfg View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/vfs/tsk_file_entry.py View 1 2 chunks +88 lines, -0 lines 0 comments Download

Messages

Total messages: 12
Joachim Metz
7 months ago (2018-02-18 11:22:39 UTC) #1
onager
I'm not sure if this is ready for review, but a few thoughts anyway. https://codereview.appspot.com/334500044/diff/1/dependencies.ini ...
6 months, 2 weeks ago (2018-03-08 12:18:50 UTC) #2
Joachim Metz
https://codereview.appspot.com/334500044/diff/1/dependencies.ini File dependencies.ini (right): https://codereview.appspot.com/334500044/diff/1/dependencies.ini#newcode18 dependencies.ini:18: minimum_version: 20180218 ack, agree https://codereview.appspot.com/334500044/diff/1/dfvfs/vfs/tsk_file_entry.py File dfvfs/vfs/tsk_file_entry.py (right): https://codereview.appspot.com/334500044/diff/1/dfvfs/vfs/tsk_file_entry.py#newcode24 ...
6 months, 2 weeks ago (2018-03-09 00:38:00 UTC) #3
Joachim Metz
Code updated.
6 months, 1 week ago (2018-03-16 06:50:35 UTC) #4
onager
LGTM, one docstring nit https://codereview.appspot.com/334500044/diff/20001/dfvfs/vfs/tsk_file_entry.py File dfvfs/vfs/tsk_file_entry.py (right): https://codereview.appspot.com/334500044/diff/20001/dfvfs/vfs/tsk_file_entry.py#newcode24 dfvfs/vfs/tsk_file_entry.py:24: fraction_of_second (int): fraction of second. ...
6 months ago (2018-03-18 09:24:57 UTC) #5
Joachim Metz
https://codereview.appspot.com/334500044/diff/20001/dfvfs/vfs/tsk_file_entry.py File dfvfs/vfs/tsk_file_entry.py (right): https://codereview.appspot.com/334500044/diff/20001/dfvfs/vfs/tsk_file_entry.py#newcode24 dfvfs/vfs/tsk_file_entry.py:24: fraction_of_second (int): fraction of second. On 2018/03/18 09:24:57, onager ...
6 months ago (2018-03-18 11:32:54 UTC) #6
Joachim Metz
Code updated.
6 months ago (2018-03-18 13:07:33 UTC) #7
Joachim Metz
Code updated.
6 months ago (2018-03-18 13:08:51 UTC) #8
Joachim Metz
PTAL
6 months ago (2018-03-18 13:10:06 UTC) #9
onager
Couple of nits, but change still LGTM https://codereview.appspot.com/334500044/diff/60001/.travis.yml File .travis.yml (right): https://codereview.appspot.com/334500044/diff/60001/.travis.yml#newcode39 .travis.yml:39: - env: ...
6 months ago (2018-03-18 13:29:42 UTC) #10
Joachim Metz
https://codereview.appspot.com/334500044/diff/60001/.travis.yml File .travis.yml (right): https://codereview.appspot.com/334500044/diff/60001/.travis.yml#newcode39 .travis.yml:39: - env: TARGET="linux-python34" nope, I've filed an issue to ...
6 months ago (2018-03-19 07:05:19 UTC) #11
Joachim Metz
6 months ago (2018-03-19 07:06:11 UTC) #12
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close getdate
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b