[plaso] Explicitly surface which Python version is running our tests.

[plaso] Explicitly surface which Python version is running our tests.

[Joachim Metz, 2018-02-13 22:08:28]

https://codereview.appspot.com/334480043/diff/1/run_tests.py
File run_tests.py (right):

https://codereview.appspot.com/334480043/diff/1/run_tests.py#newcode13
run_tests.py:13: sys.stderr.write('Using Python version
{0:s}\n'.format(repr(sys.version_info)))
Please move into main-section and use print()

you can use {0!s} to force a string conversion

[ep, 2018-02-13 22:30:10]

Code updated.

[ep, 2018-02-13 22:33:14]

Actually my main goal with this change was to trigger a Travis log with this
information, but I think it would be great to have it committed!

https://codereview.appspot.com/334480043/diff/1/run_tests.py
File run_tests.py (right):

https://codereview.appspot.com/334480043/diff/1/run_tests.py#newcode13
run_tests.py:13: sys.stderr.write('Using Python version
{0:s}\n'.format(repr(sys.version_info)))
On 2018/02/13 22:08:28, Joachim Metz wrote:
> Please move into main-section and use print()
> 
> you can use {0!s} to force a string conversion

Done. (And used a human-friendlier version, so no need for the conversion)

[Joachim Metz, 2018-02-14 06:08:50]

https://codereview.appspot.com/334480043/diff/20001/run_tests.py
File run_tests.py (right):

https://codereview.appspot.com/334480043/diff/20001/run_tests.py#newcode17
run_tests.py:17: print('Using Python version {0}'.format(sys.version),
file=sys.stderr)
per style guide use the explicit form {0!s}

https://github.com/log2timeline/plaso/wiki/Style-guide#strings

what is the need to output this to stderr and not stdout? if no particular need
remove, if particular need add comment explaining why.

[ep, 2018-02-14 11:14:42]

Code updated.

[ep, 2018-02-14 11:16:02]

https://codereview.appspot.com/334480043/diff/20001/run_tests.py
File run_tests.py (right):

https://codereview.appspot.com/334480043/diff/20001/run_tests.py#newcode17
run_tests.py:17: print('Using Python version {0}'.format(sys.version),
file=sys.stderr)
On 2018/02/14 06:08:50, Joachim Metz wrote:
> per style guide use the explicit form {0!s}
> 
> https://github.com/log2timeline/plaso/wiki/Style-guide#strings
> 
> what is the need to output this to stderr and not stdout? if no particular
need
> remove, if particular need add comment explaining why.

Done. (I'd used stderr for consistency with unittest, but the version list
already uses stdout, so that was just noise, indeed...)

[ep, 2018-02-14 11:56:52]

Code updated.

[Joachim Metz, 2018-02-14 15:06:11]

LGTM, I'll merge this later

[Joachim Metz, 2018-02-14 20:30:17]

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close py2or3