Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3971)

Issue 334460043: Let parser use define-markup-command-internal

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 2 months ago by dak
Modified:
6 years, 2 months ago
Reviewers:
thomasmorley651
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Let parser use define-markup-command-internal Macros/syntax are quirky to use from C++. Also: Split out define-markup-command-internal

Patch Set 1 #

Patch Set 2 : Make do completely without primitive-eval for macro definitions #

Patch Set 3 : Fix result of make-...-markup-list to return a list as the strange API requires #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -33 lines) Patch
M lily/include/lily-imports.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/lily-imports.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/parser.yy View 1 1 chunk +2 lines, -5 lines 0 comments Download
M scm/markup-macros.scm View 1 2 3 chunks +39 lines, -26 lines 0 comments Download

Messages

Total messages: 6
dak
Make do completely without primitive-eval for macro definitions
6 years, 2 months ago (2018-02-04 16:55:32 UTC) #1
thomasmorley651
Works with my guilev2 setup and compiling input/regression/markup-partial.ly directly. make doc (with guilev2) fails at ...
6 years, 2 months ago (2018-02-04 21:36:17 UTC) #2
thomasmorley651
On 2018/02/04 21:36:17, thomasmorley651 wrote: > Works with my guilev2 setup and compiling input/regression/markup-partial.ly > ...
6 years, 2 months ago (2018-02-05 00:04:22 UTC) #3
dak
On 2018/02/05 00:04:22, thomasmorley651 wrote: > On 2018/02/04 21:36:17, thomasmorley651 wrote: > > Works with ...
6 years, 2 months ago (2018-02-05 01:04:22 UTC) #4
dak
Fix result of make-...-markup-list to return a list as the strange API requires
6 years, 2 months ago (2018-02-05 01:20:14 UTC) #5
thomasmorley651
6 years, 2 months ago (2018-02-06 21:57:23 UTC) #6
Out of my own testings as well as running a full `make doc' with guilev2:
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b