Issue 334200043: ticket:13442 Fixing checks for whether or not grouping is enabled. A grouping size of zero means t…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 334200043: ticket:13442 Fixing checks for whether or not grouping is enabled. A grouping size of zero means t… (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 4 months ago by sffc

Modified:
6 years, 4 months ago

Reviewers:
andy.heninger

Base URL:
svn+icussh://source.icu-project.org/repos/icu/trunk/icu4j/

Visibility:
Public.

ticket:13442 Fixing checks for whether or not grouping is enabled. A grouping size of zero means that grouping is disabled.

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -3 lines)			Patch
M	main/classes/core/src/com/ibm/icu/impl/number/Parse.java	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	main/classes/core/src/com/ibm/icu/text/DecimalFormat.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	main/tests/core/src/com/ibm/icu/dev/test/format/NumberFormatTest.java	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 3

On 2017/11/29 23:22:07, andy.heninger wrote:
> LGTM

r40677