Issue 3340041: #2504: Add gettext.pgettext and friends

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3340041: #2504: Add gettext.pgettext and friends

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by merwok

Modified:
9 years ago

Reviewers:
andrew.kuchling

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+564 lines, -51 lines)			Patch
M	Doc/library/gettext.rst	View	13 chunks	+155 lines, -1 line	0 comments	Download
M	Lib/gettext.py	View	14 chunks	+145 lines, -9 lines	1 comment	Download
M	Lib/test/test_gettext.py	View	12 chunks	+231 lines, -27 lines	1 comment	Download
M	Misc/ACKS	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Misc/NEWS	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	Tools/i18n/msgfmt.py	View	9 chunks	+29 lines, -14 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

andrew.kuchling

9 years ago (2015-04-14 15:24:19 UTC) #1

The patch looks generally fine to me.

https://codereview.appspot.com/3340041/diff/1/Lib/gettext.py
File Lib/gettext.py (right):

https://codereview.appspot.com/3340041/diff/1/Lib/gettext.py#newcode383
Lib/gettext.py:383: except KeyError:
To minimize the risk of hiding unrelated KeyErrors, should the 'if
self._output_charset ... return tmsg' lines be moved outside of the 'try' block
and put into an 'else' clause?

https://codereview.appspot.com/3340041/diff/1/Lib/test/test_gettext.py
File Lib/test/test_gettext.py (right):

https://codereview.appspot.com/3340041/diff/1/Lib/test/test_gettext.py#newcod...
Lib/test/test_gettext.py:102: def test_some_translations_with_context(self):
The test suite modifications don't seem to exercise all of the variants
introduced by the patch, e.g. lpgettext, npgettext, lnpgettext, ldnpgettext.

Expand All Messages | Collapse All Messages