Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6415)

Issue 333840043: Draw plots on percentiles, use pandas to create boxplots

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 6 months ago by tonythomas
Modified:
6 years, 6 months ago
Reviewers:
david.tomic11
CC:
dkostic, kirill.sc, seregibenjamin, tonythomas, cynthiamao122_gmail.com, liangzijie1437_gmail.com
Visibility:
Public.

Description

Draw plots on percentiles, use pandas to create boxplots BUG=REP-

Patch Set 1 #

Patch Set 2 : Add log scales on y axis #

Patch Set 3 : remove debug lines #

Patch Set 4 : Fix things to a single plot #

Patch Set 5 : Fix variable erorr #

Patch Set 6 : Use better labels #

Total comments: 3

Patch Set 7 : Fix label value #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -18 lines) Patch
M api.py View 2 chunks +15 lines, -0 lines 0 comments Download
M experiments/setups/1x3.2cores.vanilla.json View 1 2 chunks +3 lines, -3 lines 0 comments Download
M launch_lx3.py View 1 2 3 4 5 6 6 chunks +30 lines, -15 lines 0 comments Download
A utils/plot_ycsb_data_from_list.py View 1 2 3 4 5 1 chunk +55 lines, -0 lines 0 comments Download
A utils/read_yscb_data_from_folder.py View 1 2 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 6
tonythomas
This is not perfect yet, but shows separate box plots for 50th, 99th and max ...
6 years, 6 months ago (2017-10-10 18:48:06 UTC) #1
seregibenjamin
Good to see a progress on this. On 10 October 2017 at 20:48, <01tonythomas@gmail.com> wrote: ...
6 years, 6 months ago (2017-10-10 22:11:08 UTC) #2
david.tomic11
Review comments and give check so i can merge this https://codereview.appspot.com/333840043/diff/100001/api.py File api.py (right): https://codereview.appspot.com/333840043/diff/100001/api.py#newcode146 ...
6 years, 6 months ago (2017-10-14 15:05:25 UTC) #3
tonythomas
https://codereview.appspot.com/333840043/diff/100001/launch_lx3.py File launch_lx3.py (right): https://codereview.appspot.com/333840043/diff/100001/launch_lx3.py#newcode152 launch_lx3.py:152: 'label': 'thread count', On 2017/10/14 15:05:25, david.tomic11 wrote: > ...
6 years, 6 months ago (2017-10-14 15:18:18 UTC) #4
tonythomas
merged. danke -- Tony Thomas https://mediawiki.org/wiki/User:01tonythomas -- On Sat, Oct 14, 2017 at 5:18 PM, ...
6 years, 6 months ago (2017-10-14 15:29:52 UTC) #5
david.tomic11
6 years, 6 months ago (2017-10-14 15:31:14 UTC) #6
bitte

On 14 October 2017 at 17:29, Tony Thomas <01tonythomas@gmail.com> wrote:

> merged. danke
>
> --
> Tony Thomas
> https://mediawiki.org/wiki/User:01tonythomas
> --
>
> On Sat, Oct 14, 2017 at 5:18 PM, <01tonythomas@gmail.com> wrote:
>
>>
>> https://codereview.appspot.com/333840043/diff/100001/launch_lx3.py
>> File launch_lx3.py (right):
>>
>> https://codereview.appspot.com/333840043/diff/100001/launch_
>> lx3.py#newcode152
>> launch_lx3.py:152: 'label': 'thread count',
>> On 2017/10/14 15:05:25, david.tomic11 wrote:
>>
>>> you sure the label shouldn't be jitter_level?
>>>
>>
>> :D of course
>>
>> https://codereview.appspot.com/333840043/
>>
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b