Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(10627)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 333790043: ICU ticket #13384: Fixes issue described in comment3 in #13384: Without #include unicode/utypes.h t… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 6 months ago by nrunge
Modified:
6 years, 4 months ago
Reviewers:
sffc
CC:
markus.icu, andy.heninger
Base URL:
svn+ssh://source.icu-project.org/repos/icu/trunk/icu4c/
Visibility:
Public.

Description

ICU ticket #13384: Fixes issue described in comment3 in #13384: Without #include unicode/utypes.h t…

Patch Set 1 #

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -0 lines) Patch
M source/i18n/number_affixutils.h View 1 chunk +2 lines, -0 lines 0 comments Download
M source/i18n/number_affixutils.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M source/i18n/number_compact.h View 1 chunk +2 lines, -0 lines 0 comments Download
M source/i18n/number_compact.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M source/i18n/number_decimalquantity.h View 1 chunk +2 lines, -0 lines 0 comments Download
M source/i18n/number_decimalquantity.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M source/i18n/number_decimfmtprops.h View 1 chunk +2 lines, -0 lines 0 comments Download
M source/i18n/number_decimfmtprops.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M source/i18n/number_fluent.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M source/i18n/number_formatimpl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M source/i18n/number_formatimpl.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M source/i18n/number_grouping.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M source/i18n/number_integerwidth.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M source/i18n/number_longnames.h View 1 chunk +2 lines, -0 lines 0 comments Download
M source/i18n/number_longnames.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M source/i18n/number_modifiers.h View 1 chunk +2 lines, -0 lines 0 comments Download
M source/i18n/number_modifiers.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M source/i18n/number_notation.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M source/i18n/number_padding.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M source/i18n/number_patternmodifier.h View 1 chunk +2 lines, -0 lines 0 comments Download
M source/i18n/number_patternmodifier.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M source/i18n/number_patternstring.h View 1 chunk +2 lines, -0 lines 0 comments Download
M source/i18n/number_patternstring.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M source/i18n/number_rounding.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M source/i18n/number_roundingutils.h View 1 chunk +2 lines, -0 lines 0 comments Download
M source/i18n/number_scientific.h View 1 chunk +2 lines, -0 lines 0 comments Download
M source/i18n/number_scientific.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M source/i18n/number_stringbuilder.h View 1 chunk +2 lines, -0 lines 0 comments Download
M source/i18n/number_stringbuilder.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M source/i18n/number_types.h View 1 chunk +2 lines, -0 lines 0 comments Download
M source/i18n/number_utils.h View 1 chunk +2 lines, -0 lines 0 comments Download
M source/i18n/unicode/numberformatter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M source/test/intltest/numbertest.h View 1 chunk +2 lines, -0 lines 0 comments Download
M source/test/intltest/numbertest_affixutils.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M source/test/intltest/numbertest_api.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M source/test/intltest/numbertest_decimalquantity.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M source/test/intltest/numbertest_modifiers.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M source/test/intltest/numbertest_patternmodifier.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M source/test/intltest/numbertest_patternstring.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M source/test/intltest/numbertest_stringbuilder.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4
nrunge
6 years, 6 months ago (2017-10-04 21:08:28 UTC) #1
nrunge
Code review changes
6 years, 6 months ago (2017-10-04 21:40:37 UTC) #2
sffc
LGTM
6 years, 6 months ago (2017-10-04 22:41:31 UTC) #3
sffc
6 years, 4 months ago (2017-12-01 08:34:46 UTC) #4 
@nrunge, can you click "Edit Issue" and mark this as closed?  Thanks.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b