Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(449)

Issue 333660043: 802.11 PCF implementation

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months ago by S. Deronne
Modified:
1 week, 4 days ago
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

Implementation of 802.11 PCF in ns-3

Patch Set 1 : Initial patch set #

Patch Set 2 : Added PCF example #

Total comments: 38

Patch Set 3 : Merge with ns-3-dev + handle some review comments #

Patch Set 4 : Add missing PCF example in previous patchset #

Patch Set 5 : Fix wifi-blockack example in previous patchset #

Total comments: 16
Unified diffs Side-by-side diffs Delta from patch set Stats (+5603 lines, -3772 lines) Patch
M examples/wireless/80211e-txop.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M examples/wireless/mixed-network.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download
M examples/wireless/wifi-blockack.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A examples/wireless/wifi-pcf.cc View 1 2 3 1 chunk +252 lines, -0 lines 6 comments Download
M examples/wireless/wscript View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/mesh/helper/mesh-helper.cc View 2 chunks +17 lines, -18 lines 0 comments Download
M src/mesh/model/mesh-wifi-interface-mac.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M src/test/ns3wifi/wifi-ac-mapping-test-suite.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M src/wave/helper/wave-helper.cc View 1 chunk +16 lines, -16 lines 0 comments Download
M src/wave/model/ocb-wifi-mac.cc View 12 chunks +14 lines, -14 lines 0 comments Download
M src/wave/model/wave-mac-low.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/wave/model/wave-mac-low.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/wave/test/ocb-test-suite.cc View 2 chunks +18 lines, -18 lines 0 comments Download
M src/wifi/doc/source/wifi-design.rst View 1 2 3 chunks +11 lines, -9 lines 0 comments Download
M src/wifi/helper/wifi-helper.cc View 1 2 2 chunks +19 lines, -18 lines 0 comments Download
M src/wifi/model/adhoc-wifi-mac.cc View 6 chunks +12 lines, -12 lines 0 comments Download
M src/wifi/model/ap-wifi-mac.h View 1 2 7 chunks +39 lines, -4 lines 0 comments Download
M src/wifi/model/ap-wifi-mac.cc View 1 2 48 chunks +204 lines, -70 lines 0 comments Download
M src/wifi/model/block-ack-manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/wifi/model/capability-information.h View 2 chunks +13 lines, -0 lines 0 comments Download
M src/wifi/model/capability-information.cc View 2 chunks +12 lines, -0 lines 0 comments Download
A src/wifi/model/cf-parameter-set.h View 1 chunk +153 lines, -0 lines 0 comments Download
A src/wifi/model/cf-parameter-set.cc View 1 chunk +192 lines, -0 lines 0 comments Download
R src/wifi/model/dca-txop.h View 1 2 1 chunk +0 lines, -427 lines 0 comments Download
R src/wifi/model/dca-txop.cc View 1 2 1 chunk +0 lines, -624 lines 0 comments Download
M src/wifi/model/dcf-manager.h View 1 2 7 chunks +34 lines, -11 lines 0 comments Download
M src/wifi/model/dcf-manager.cc View 1 2 7 chunks +42 lines, -3 lines 0 comments Download
M src/wifi/model/dcf-state.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M src/wifi/model/dcf-state.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
R src/wifi/model/edca-txop-n.h View 1 chunk +0 lines, -541 lines 0 comments Download
R src/wifi/model/edca-txop-n.cc View 1 2 1 chunk +0 lines, -1568 lines 0 comments Download
A src/wifi/model/infrastructure-wifi-mac.h View 1 2 1 chunk +78 lines, -0 lines 0 comments Download
A src/wifi/model/infrastructure-wifi-mac.cc View 1 chunk +75 lines, -0 lines 0 comments Download
M src/wifi/model/mac-low.h View 1 2 14 chunks +79 lines, -16 lines 0 comments Download
M src/wifi/model/mac-low.cc View 1 2 38 chunks +355 lines, -89 lines 0 comments Download
M src/wifi/model/mac-rx-middle.h View 1 2 2 chunks +9 lines, -0 lines 0 comments Download
M src/wifi/model/mac-rx-middle.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M src/wifi/model/mgt-headers.h View 1 2 4 chunks +14 lines, -0 lines 0 comments Download
M src/wifi/model/mgt-headers.cc View 4 chunks +15 lines, -0 lines 0 comments Download
A src/wifi/model/qos-txop.h View 1 chunk +541 lines, -0 lines 0 comments Download
A src/wifi/model/qos-txop.cc View 1 2 1 chunk +1570 lines, -0 lines 0 comments Download
M src/wifi/model/regular-wifi-mac.h View 13 chunks +66 lines, -69 lines 0 comments Download
M src/wifi/model/regular-wifi-mac.cc View 1 2 8 chunks +32 lines, -32 lines 0 comments Download
M src/wifi/model/sta-wifi-mac.h View 1 2 4 chunks +13 lines, -2 lines 0 comments Download
M src/wifi/model/sta-wifi-mac.cc View 1 2 34 chunks +79 lines, -42 lines 0 comments Download
A src/wifi/model/txop.h View 1 2 1 chunk +454 lines, -0 lines 10 comments Download
A src/wifi/model/txop.cc View 1 2 1 chunk +752 lines, -0 lines 0 comments Download
M src/wifi/model/wifi-mac.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/wifi/model/wifi-mac.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/wifi/model/wifi-mac-header.h View 5 chunks +43 lines, -2 lines 0 comments Download
M src/wifi/model/wifi-mac-header.cc View 1 2 15 chunks +103 lines, -21 lines 0 comments Download
M src/wifi/model/wifi-mac-queue.h View 1 2 3 chunks +26 lines, -2 lines 0 comments Download
M src/wifi/model/wifi-mac-queue.cc View 1 2 2 chunks +45 lines, -0 lines 0 comments Download
M src/wifi/model/wifi-net-device.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/wifi/model/wifi-net-device.cc View 1 2 1 chunk +10 lines, -10 lines 0 comments Download
M src/wifi/model/wifi-remote-station-manager.h View 1 2 2 chunks +13 lines, -0 lines 0 comments Download
M src/wifi/model/wifi-remote-station-manager.cc View 1 2 2 chunks +13 lines, -0 lines 0 comments Download
M src/wifi/test/dcf-manager-test.cc View 10 chunks +46 lines, -27 lines 0 comments Download
M src/wifi/test/wifi-aggregation-test.cc View 16 chunks +40 lines, -40 lines 0 comments Download
M src/wifi/test/wifi-test.cc View 2 chunks +18 lines, -18 lines 0 comments Download
M src/wifi/wscript View 1 2 6 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 12
Rediet
Hey S├ębastien, Here are my comments. Didn't have time to check with the standard though... ...
3 weeks, 3 days ago (2018-03-29 16:40:22 UTC) #1
S. Deronne
Rediet, Thanks for your review. No problem wrt to the standard, I think Varun has ...
3 weeks, 3 days ago (2018-03-30 08:58:43 UTC) #2
Tom Henderson
I did not have time to go through everything yet (large patch) so just took ...
3 weeks, 1 day ago (2018-03-31 23:27:03 UTC) #3
S. Deronne
Tom, thanks for your review, I agree this is a big patch. There is a ...
3 weeks ago (2018-04-01 15:03:51 UTC) #4
Tom Henderson
On 2018/04/01 15:03:51, S. Deronne wrote: > Tom, thanks for your review, I agree this ...
3 weeks ago (2018-04-01 16:16:26 UTC) #5
Rediet
https://codereview.appspot.com/333660043/diff/20001/src/wifi/model/ap-wifi-mac.h File src/wifi/model/ap-wifi-mac.h (right): https://codereview.appspot.com/333660043/diff/20001/src/wifi/model/ap-wifi-mac.h#newcode330 src/wifi/model/ap-wifi-mac.h:330: Time m_beaconInterval; //!< Interval between beacons On 2018/03/30 08:58:43, ...
2 weeks, 6 days ago (2018-04-03 07:24:01 UTC) #6
Stefano Avallone
I would like to make a proposal that is related to one aspect of this ...
2 weeks, 1 day ago (2018-04-08 08:40:43 UTC) #7
Tom Henderson
On 2018/04/08 08:40:43, Stefano Avallone wrote: > I would like to make a proposal that ...
2 weeks ago (2018-04-08 15:24:23 UTC) #8
S. Deronne
https://codereview.appspot.com/333660043/diff/20001/src/wifi/model/ap-wifi-mac.h File src/wifi/model/ap-wifi-mac.h (right): https://codereview.appspot.com/333660043/diff/20001/src/wifi/model/ap-wifi-mac.h#newcode330 src/wifi/model/ap-wifi-mac.h:330: Time m_beaconInterval; //!< Interval between beacons Compilation succeeded on ...
1 week, 4 days ago (2018-04-11 20:00:30 UTC) #9
S. Deronne
On 2018/04/08 08:40:43, Stefano Avallone wrote: > I would like to make a proposal that ...
1 week, 4 days ago (2018-04-11 20:02:04 UTC) #10
Stefano Avallone
FYI I just rebased the patch on the current master. On Wed, Apr 11, 2018 ...
1 week, 4 days ago (2018-04-11 20:50:03 UTC) #11
Rediet
1 week, 4 days ago (2018-04-12 07:32:04 UTC) #12
https://codereview.appspot.com/333660043/diff/20001/src/wifi/model/wifi-mac-h...
File src/wifi/model/wifi-mac-header.cc (right):

https://codereview.appspot.com/333660043/diff/20001/src/wifi/model/wifi-mac-h...
src/wifi/model/wifi-mac-header.cc:272: m_duration = duration;
On 2018/04/11 20:00:30, S. Deronne wrote:
> Correct, so you want to check here that raw duration is lower or equal to that
> value?

I think it would be better (just like what's done below for SetDuration, unless
redundant).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld e4aa27b