Issue 333590043: [plaso] [NOT ready for review] Let tox run tests in the appropriate virtualenv.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 333590043: [plaso] [NOT ready for review] Let tox run tests in the appropriate virtualenv. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 2 months ago by ep

Modified:
6 years ago

Reviewers:
Joachim Metz

CC:
jberggren, romaing, onager, kiddi, log2timeline-dev_googlegroups.com

Visibility:
Public.

[plaso] Let tox run tests in the appropriate virtualenv.

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	.travis.yml	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
	M	tox.ini	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6

I see that this breaks py34 in the Travis CI integration tests on Github. I ...

6 years, 2 months ago (2018-02-02 14:56:23 UTC) #2

[Waiting to see if this has the desired effect on Travis integration.]

6 years, 2 months ago (2018-02-14 14:57:55 UTC) #4

This change seems to do what it is meant to do, but I wouldn't submit ...

6 years, 1 month ago (2018-02-21 16:22:11 UTC) #5

Joachim Metz

6 years ago (2018-03-30 10:40:13 UTC) #6

There are duplicate changes in https://codereview.appspot.com/334530043/, what
is the status of this CL?

Please close if no longer relevant