[plaso] Added Window Registry parser plugin filters tests #1668

[plaso] Added Window Registry parser plugin filters tests #1668

[Joachim Metz, 2018-01-21 19:36:03]

Code updated.

[Joachim Metz, 2018-01-21 20:30:08]

Code updated.

[baby546833, 2018-01-27 03:06:18]

<？xml version =“1.0”encoding =“utf-8”？>
代碼審查 - 所有我要審查的問題</ title> <link href =“http://zh.w3.org/2005/Atom”
https://codereview.appspot.com/“rel =”alternate“> </ link> <link href
=”https://codereview.appspot.com/rss/reviews/baby546833“rel =”self“> </ li>鏈路>
<ID> https://codereview.appspot.com/ </ ID> <更新> 2018-01-27T02：54：55 + 00：00
</更新> <作者> <名稱>里特沃爾德</名稱> <em> </ author> <entry> <title>在Emojier上實現Unicode選擇
</ title> <link href =“https://codereview.appspot.com/340190043/”rel
=“alternate”> </ link> <updated> 2018-01-27T02：54：55 + 00：
urn：md5：d2f7ec990f072dc671a96939cbd73158 <summary type =“html”> </ code>
  在Emojier上實現Unicode選擇

BUG = HTTPS：//github.com/ibus/ibus/issues/1922

</ summary> </ entry> <entry> <title>測試代碼審查後
</ title> <link href =“https://codereview.appspot.com/6493067/”rel =“alternate”>
</ link> <updated> 2018-01-27T02：39：44 + 00：更新> <author> <name> ItzmE29 </ name>
</ author> <id> urn：md5：97932c56597ba525fb046fe6a73414f3 <summary type =“html”>
  這是一個測試評論代碼帖子

</摘要> </條目> </飼料>
me=baby546833@gmail.com 周訓毅

[baby546833, 2018-01-27 03:08:21]

On 2018/01/21 18:48:31, Joachim Metz wrote:

<？xml version =“1.0”encoding =“utf-8”？>
代碼審查 - 所有我要審查的問題</ title> <link href =“http://zh.w3.org/2005/Atom”
https://codereview.appspot.com/“rel =”alternate“> </ link> <link href
=”https://codereview.appspot.com/rss/reviews/baby546833“rel =”self“> </ li>鏈路>
<ID> https://codereview.appspot.com/ </ ID> <更新> 2018-01-27T02：54：55 + 00：00
</更新> <作者> <名稱>里特沃爾德</名稱> <em> </ author> <entry> <title>在Emojier上實現Unicode選擇
</ title> <link href =“https://codereview.appspot.com/340190043/”rel
=“alternate”> </ link> <updated> 2018-01-27T02：54：55 + 00：
urn：md5：d2f7ec990f072dc671a96939cbd73158 <summary type =“html”> </ code>
  在Emojier上實現Unicode選擇

BUG = HTTPS：//github.com/ibus/ibus/issues/1922

</ summary> </ entry> <entry> <title>測試代碼審查後
</ title> <link href =“https://codereview.appspot.com/6493067/”rel =“alternate”>
</ link> <updated> 2018-01-27T02：39：44 + 00：更新> <author> <name> ItzmE29 </ name>
</ author> <id> urn：md5：97932c56597ba525fb046fe6a73414f3 <summary type =“html”>
  這是一個測試評論代碼帖子

</摘要> </條目> </飼料>
me=baby546833@gmail.com

[baby546833, 2018-01-28 04:55:35]

I Love my wife

[onager, 2018-02-11 12:04:58]

https://codereview.appspot.com/333570043/diff/40001/tests/parsers/winreg_plug...
File tests/parsers/winreg_plugins/appcompatcache.py (right):

https://codereview.appspot.com/333570043/diff/40001/tests/parsers/winreg_plug...
tests/parsers/winreg_plugins/appcompatcache.py:298: self.assertTrue(result)
Please move the assert into the _CheckFiltersOnKeyPath method, rather than
repeating it on (almost) every call. Probably also rename to _AssertFiltersOn...
and maybe add a _AssertDoesntFilter.. method that's the inverse.

https://codereview.appspot.com/333570043/diff/40001/tests/parsers/winreg_plug...
tests/parsers/winreg_plugins/appcompatcache.py:300: key_path =
'HKEY_LOCAL_MACHINE\\Bogus'
Please factor this out to a method in the test_lib, rather than repeating it for
every plugin.

[Joachim Metz, 2018-02-11 14:08:43]

https://codereview.appspot.com/333570043/diff/40001/tests/parsers/winreg_plug...
File tests/parsers/winreg_plugins/appcompatcache.py (right):

https://codereview.appspot.com/333570043/diff/40001/tests/parsers/winreg_plug...
tests/parsers/winreg_plugins/appcompatcache.py:298: self.assertTrue(result)
On 2018/02/11 12:04:58, onager wrote:
> Please move the assert into the _CheckFiltersOnKeyPath method, rather than
> repeating it on (almost) every call. Probably also rename to
_AssertFiltersOn...
> and maybe add a _AssertDoesntFilter.. method that's the inverse.

Done.

https://codereview.appspot.com/333570043/diff/40001/tests/parsers/winreg_plug...
tests/parsers/winreg_plugins/appcompatcache.py:300: key_path =
'HKEY_LOCAL_MACHINE\\Bogus'
On 2018/02/11 12:04:58, onager wrote:
> Please factor this out to a method in the test_lib, rather than repeating it
for
> every plugin.

Acknowledged.

[Joachim Metz, 2018-02-11 14:12:24]

Code updated.

[baby546833, 2018-02-11 17:27:56]

I very my wife....

[baby546833, 2018-02-11 17:44:03]

幹你娘老雞歪，網路上一群欠人幹的爛B

[baby546833, 2018-02-11 17:46:09]

幹你祖公的大某小姨的臭雞歪

[baby546833, 2018-02-11 17:47:08]

你們有誰欠人幹

[baby546833, 2018-02-11 17:47:57]

死妓女……插你屁眼

[baby546833, 2018-02-11 17:50:30]

2016/09/11我結第2次婚

[baby546833, 2018-02-11 17:53:24]

我曾開過復康巴士……我開媽祖一號，叫我周勇..

[baby546833, 2018-02-11 17:54:53]

我喜歡未成年少女的雞歪

[baby546833, 2018-02-11 17:55:54]

我也喜歡幹屁眼

[baby546833, 2018-02-11 17:56:58]

重點是去找妓女幹完不給錢

[baby546833, 2018-02-11 17:58:26]

我要公開網路上和我視訊的賤女人照片

[baby546833, 2018-02-11 17:59:19]

誰叫你們這麽賤

[baby546833, 2018-02-11 18:00:48]

公開你們的電話，你們生意才會好，死妓女

[baby546833, 2018-02-11 18:02:38]

公開你們視訊的叫聲……叫你們朋友也一起聽……

[baby546833, 2018-02-11 18:03:58]

我住台北昌吉街

[baby546833, 2018-02-11 18:05:01]

我常打老婆，越打越爽越興奮

[onager, 2018-02-19 15:36:12]

LGTM after removing the redundant test.

https://codereview.appspot.com/333570043/diff/60001/tests/parsers/winreg_plug...
File tests/parsers/winreg_plugins/appcompatcache.py (right):

https://codereview.appspot.com/333570043/diff/60001/tests/parsers/winreg_plug...
tests/parsers/winreg_plugins/appcompatcache.py:290:
self._AssertFiltersOnKeyPath(plugin, key_path)
Remove this block, we only need to test this once.

[Joachim Metz, 2018-02-19 17:56:13]

https://codereview.appspot.com/333570043/diff/60001/tests/parsers/winreg_plug...
File tests/parsers/winreg_plugins/appcompatcache.py (right):

https://codereview.appspot.com/333570043/diff/60001/tests/parsers/winreg_plug...
tests/parsers/winreg_plugins/appcompatcache.py:290:
self._AssertFiltersOnKeyPath(plugin, key_path)
The first one should be AppCompatibility

[Joachim Metz, 2018-02-19 18:04:03]

Code updated.

[Joachim Metz, 2018-02-19 18:09:32]

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close fix1668

[baby546833, 2018-02-20 01:19:53]

I very love my wife

[bichphuong02121993, 2019-01-08 02:34:06]

Vào Thứ Ba, 8 tháng 1, 2019, <bichphuong02121993@gmail.com> đã viết:

> https://codereview.appspot.com/333570043/
>