Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(209)

Issue 333520043: ticket:13551 Adding EXCEPT_ZERO enum value to SignDisplay. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 2 months ago by sffc
Modified:
6 years ago
Reviewers:
andy.heninger
Base URL:
svn+icussh://source.icu-project.org/repos/icu/trunk/
Visibility:
Public.

Description

ticket:13551 Adding EXCEPT_ZERO enum value to SignDisplay.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Adding ICU4C implementation. #

Patch Set 3 : Actually adding ICU4C implementation. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+366 lines, -94 lines) Patch
M icu4c/source/i18n/number_decimalquantity.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M icu4c/source/i18n/number_decimalquantity.cpp View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M icu4c/source/i18n/number_formatimpl.cpp View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M icu4c/source/i18n/number_modifiers.h View 1 2 1 chunk +14 lines, -12 lines 0 comments Download
M icu4c/source/i18n/number_patternmodifier.h View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M icu4c/source/i18n/number_patternmodifier.cpp View 1 2 7 chunks +26 lines, -19 lines 0 comments Download
M icu4c/source/i18n/unicode/numberformatter.h View 1 2 3 chunks +29 lines, -9 lines 0 comments Download
M icu4c/source/test/intltest/numbertest_api.cpp View 1 2 5 chunks +77 lines, -0 lines 0 comments Download
M icu4c/source/test/intltest/numbertest_patternmodifier.cpp View 1 2 2 chunks +18 lines, -8 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/DecimalQuantity.java View 1 chunk +3 lines, -0 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/DecimalQuantity_AbstractBCD.java View 1 chunk +5 lines, -0 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/MutablePatternModifier.java View 7 chunks +28 lines, -20 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/ParameterizedModifier.java View 4 chunks +13 lines, -10 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/number/NumberFormatter.java View 3 chunks +26 lines, -3 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/number/NumberFormatterImpl.java View 1 chunk +2 lines, -1 line 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/impl/number/DecimalQuantity_SimpleStorage.java View 1 chunk +5 lines, -0 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/number/MutablePatternModifierTest.java View 2 chunks +16 lines, -4 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/number/NumberFormatterApiTest.java View 5 chunks +88 lines, -0 lines 2 comments Download

Messages

Total messages: 9
sffc
6 years, 2 months ago (2018-01-18 00:36:23 UTC) #1
andy.heninger
LGTM. Needs an official API proposal. https://codereview.appspot.com/333520043/diff/1/icu4j/main/classes/core/src/com/ibm/icu/number/NumberFormatter.java File icu4j/main/classes/core/src/com/ibm/icu/number/NumberFormatter.java (right): https://codereview.appspot.com/333520043/diff/1/icu4j/main/classes/core/src/com/ibm/icu/number/NumberFormatter.java#newcode247 icu4j/main/classes/core/src/com/ibm/icu/number/NumberFormatter.java:247: * @draft ICU ...
6 years, 2 months ago (2018-01-18 01:10:28 UTC) #2
sffc
Adding ICU4C implementation.
6 years, 2 months ago (2018-01-23 00:39:47 UTC) #3
sffc
Actually adding ICU4C implementation.
6 years, 2 months ago (2018-01-23 00:41:04 UTC) #4
sffc
Please take another look; ICU4C is added. API proposal is sent.
6 years, 2 months ago (2018-01-23 00:53:08 UTC) #5
andy.heninger
On 2018/01/23 00:53:08, sffc wrote: > Please take another look; ICU4C is added. > > ...
6 years, 1 month ago (2018-02-08 23:52:17 UTC) #6
sffc
Thanks! I checked it in a couple days ago.
6 years, 1 month ago (2018-02-08 23:57:37 UTC) #7
andy.heninger
LGTM, modulo one typo in a test case. https://codereview.appspot.com/333520043/diff/40001/icu4j/main/tests/core/src/com/ibm/icu/dev/test/number/NumberFormatterApiTest.java File icu4j/main/tests/core/src/com/ibm/icu/dev/test/number/NumberFormatterApiTest.java (right): https://codereview.appspot.com/333520043/diff/40001/icu4j/main/tests/core/src/com/ibm/icu/dev/test/number/NumberFormatterApiTest.java#newcode1593 icu4j/main/tests/core/src/com/ibm/icu/dev/test/number/NumberFormatterApiTest.java:1593: "Sign ...
6 years, 1 month ago (2018-02-20 21:38:47 UTC) #8
sffc
6 years ago (2018-03-01 04:41:47 UTC) #9
Message was sent while issue was closed.
Fixed in revision 41031

https://codereview.appspot.com/333520043/diff/40001/icu4j/main/tests/core/src...
File
icu4j/main/tests/core/src/com/ibm/icu/dev/test/number/NumberFormatterApiTest.java
(right):

https://codereview.appspot.com/333520043/diff/40001/icu4j/main/tests/core/src...
icu4j/main/tests/core/src/com/ibm/icu/dev/test/number/NumberFormatterApiTest.java:1593:
"Sign Always Negative",
On 2018/02/20 21:38:47, andy.heninger wrote:
> Always -> Except-Zero

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b