Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(753)

Issue 333230043: Add coordinator patch

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week ago by Tsumak.Dmitri
Modified:
3 days, 19 hours ago
CC:
dkostic, w.fakher.reda
Visibility:
Public.

Description

Add coordinator patch BUG=

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -1 line) Patch
M src/java/org/apache/cassandra/service/AbstractReadExecutor.java View 4 chunks +38 lines, -1 line 2 comments Download

Messages

Total messages: 4
Tsumak.Dmitri
1 week ago (2017-12-03 18:22:48 UTC) #1
cuteliaoliao
5 days ago (2017-12-06 15:05:42 UTC) #2
mumuzuge
4 days, 23 hours ago (2017-12-06 15:15:51 UTC) #3
Jiangfeng
3 days, 19 hours ago (2017-12-07 19:28:04 UTC) #4
I found wrong logic and see the comments that I write to the twos lines in the
code.

https://codereview.appspot.com/333230043/diff/1/src/java/org/apache/cassandra...
File src/java/org/apache/cassandra/service/AbstractReadExecutor.java (right):

https://codereview.appspot.com/333230043/diff/1/src/java/org/apache/cassandra...
src/java/org/apache/cassandra/service/AbstractReadExecutor.java:213:
SpeculativeRetryParam retry = cfs.metadata().params.speculativeRetry;
I suggest you save the current percentile parameter of speculative retry as a
static variable. And write like "SpeculativeRetryParam retry =
SpeculativeRetryParam.percentile(thisvariable);"

And then change the static variable at the end of ML calculation.

https://codereview.appspot.com/333230043/diff/1/src/java/org/apache/cassandra...
src/java/org/apache/cassandra/service/AbstractReadExecutor.java:236: retry =
SpeculativeRetryParam.percentile(Float.parseFloat(output));
If retry is set here, then, the readexecutor of the only request is set with our
calculated speculative retry parameter. All other read request is still set by
Line 213 "SpeculativeRetryParam retry =
cfs.metadata().params.speculativeRetry;".
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 204d58d