[plaso] Changed tagging file to be read as UTF-8 #1478 and made CLI helper fail on error

[plaso] Changed tagging file to be read as UTF-8 #1478 and made CLI helper fail on error

[onager, 2017-12-02 20:21:44]

https://codereview.appspot.com/333210043/diff/1/plaso/analysis/tagging.py
File plaso/analysis/tagging.py (right):

https://codereview.appspot.com/333210043/diff/1/plaso/analysis/tagging.py#new...
plaso/analysis/tagging.py:88: with io.open(tagging_file_path, 'r',
encoding='utf-8') as file_object:
as tagging_file

https://codereview.appspot.com/333210043/diff/1/plaso/analysis/tagging.py#new...
plaso/analysis/tagging.py:99: event_filter_expression =
self._TAG_RULE_LINE.match(line)
This isn't a filter, it's a rule that used to apply labels. Please change the
name to labeling_expression or similar.

This goes throughout the rest of this change too.

https://codereview.appspot.com/333210043/diff/1/plaso/analysis/tagging.py#new...
plaso/analysis/tagging.py:114: This method attempts to detect whether the event
filter expersion is valid
expression

https://codereview.appspot.com/333210043/diff/1/plaso/cli/helpers/tagging_ana...
File plaso/cli/helpers/tagging_analysis.py (right):

https://codereview.appspot.com/333210043/diff/1/plaso/cli/helpers/tagging_ana...
plaso/cli/helpers/tagging_analysis.py:74: 'Invalid tagging file: {0:s} with
error: unsupported encoding, '
Please make this message briefer: "Invalid tagging file x, tagging file must be
UTF-8"

https://codereview.appspot.com/333210043/diff/1/plaso/cli/helpers/tagging_ana...
plaso/cli/helpers/tagging_analysis.py:79: 'Invalid tagging file: {0:s} with
error: {1!s}'.format(
-Invalid tagging file +unable to load tagging file

[Joachim Metz, 2017-12-03 06:06:35]

https://codereview.appspot.com/333210043/diff/1/plaso/analysis/tagging.py
File plaso/analysis/tagging.py (right):

https://codereview.appspot.com/333210043/diff/1/plaso/analysis/tagging.py#new...
plaso/analysis/tagging.py:88: with io.open(tagging_file_path, 'r',
encoding='utf-8') as file_object:
Seeing that the variable is only used in 1 other place this was IMHO clear
enough.

https://codereview.appspot.com/333210043/diff/1/plaso/analysis/tagging.py#new...
plaso/analysis/tagging.py:99: event_filter_expression =
self._TAG_RULE_LINE.match(line)
> This isn't a filter, it's a rule that used to apply labels.

Technically it is a filter. However this is a discussion about semantics that is
unlikely to productive. I'm fine renaming it to "tagging rule" if you think that
is more clear.

https://codereview.appspot.com/333210043/diff/1/plaso/analysis/tagging.py#new...
plaso/analysis/tagging.py:114: This method attempts to detect whether the event
filter expersion is valid
On 2017/12/02 20:21:43, onager wrote:
> expression

Done.

https://codereview.appspot.com/333210043/diff/1/plaso/cli/helpers/tagging_ana...
File plaso/cli/helpers/tagging_analysis.py (right):

https://codereview.appspot.com/333210043/diff/1/plaso/cli/helpers/tagging_ana...
plaso/cli/helpers/tagging_analysis.py:74: 'Invalid tagging file: {0:s} with
error: unsupported encoding, '
On 2017/12/02 20:21:44, onager wrote:
> Please make this message briefer: "Invalid tagging file x, tagging file must
be
> UTF-8"

Done.

https://codereview.appspot.com/333210043/diff/1/plaso/cli/helpers/tagging_ana...
plaso/cli/helpers/tagging_analysis.py:79: 'Invalid tagging file: {0:s} with
error: {1!s}'.format(
On 2017/12/02 20:21:44, onager wrote:
> -Invalid tagging file +unable to load tagging file

Acknowledged.

[Joachim Metz, 2017-12-03 06:21:26]

Code updated.

[onager, 2017-12-09 14:47:18]

LGTM

[Joachim Metz, 2017-12-09 16:19:31]

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close tagging