Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2471)

Issue 333080043: Eliminate Visual Studio complier warnings

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 1 week ago by ammo6818-vandals.uidaho.edu
Modified:
16 hours, 31 minutes ago
Reviewers:
Stefano Avallone
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

Eliminate Visual Studio complier warnings

Patch Set 1 #

Patch Set 2 : Updates to use C++ style type casts #

Total comments: 16

Patch Set 3 : Updated patch set to address review comments #

Total comments: 32

Patch Set 4 : Updates to patch for review comments #

Patch Set 5 : Patch updates for x64 build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -75 lines) Patch
M src/traffic-control/examples/adaptive-red-tests.cc View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M src/traffic-control/examples/codel-vs-pfifo-asymmetric.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/traffic-control/examples/codel-vs-pfifo-basic-test.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/traffic-control/examples/pfifo-vs-red.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/traffic-control/examples/pie-example.cc View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M src/traffic-control/examples/red-tests.cc View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M src/traffic-control/helper/queue-disc-container.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/traffic-control/helper/traffic-control-helper.cc View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M src/traffic-control/model/codel-queue-disc.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M src/traffic-control/model/fq-codel-queue-disc.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/traffic-control/model/pie-queue-disc.h View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M src/traffic-control/model/pie-queue-disc.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M src/traffic-control/model/queue-disc.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M src/traffic-control/model/red-queue-disc.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/traffic-control/model/traffic-control-layer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/traffic-control/test/adaptive-red-queue-disc-test-suite.cc View 1 2 3 3 chunks +4 lines, -5 lines 0 comments Download
M src/traffic-control/test/codel-queue-disc-test-suite.cc View 1 2 3 9 chunks +21 lines, -22 lines 0 comments Download
M src/traffic-control/test/pie-queue-disc-test-suite.cc View 1 2 3 4 chunks +12 lines, -13 lines 0 comments Download
M src/traffic-control/test/red-queue-disc-test-suite.cc View 1 2 3 4 chunks +12 lines, -13 lines 0 comments Download

Messages

Total messages: 9
Stefano Avallone
https://codereview.appspot.com/333080043/diff/20001/src/traffic-control/examples/codel-vs-pfifo-asymmetric.cc File src/traffic-control/examples/codel-vs-pfifo-asymmetric.cc (right): https://codereview.appspot.com/333080043/diff/20001/src/traffic-control/examples/codel-vs-pfifo-asymmetric.cc#newcode235 src/traffic-control/examples/codel-vs-pfifo-asymmetric.cc:235: float startTime = 0.1f; OK. https://codereview.appspot.com/333080043/diff/20001/src/traffic-control/examples/codel-vs-pfifo-basic-test.cc File src/traffic-control/examples/codel-vs-pfifo-basic-test.cc (right): ...
1 month, 3 weeks ago (2017-12-28 23:55:28 UTC) #1
ammo6818-vandals.uidaho.edu
Updated patch set has been uploaded to address your review comments. https://codereview.appspot.com/333080043/diff/20001/src/traffic-control/examples/pfifo-vs-red.cc File src/traffic-control/examples/pfifo-vs-red.cc (right): ...
1 month, 3 weeks ago (2017-12-29 04:43:19 UTC) #2
Stefano Avallone
https://codereview.appspot.com/333080043/diff/60001/src/traffic-control/examples/adaptive-red-tests.cc File src/traffic-control/examples/adaptive-red-tests.cc (right): https://codereview.appspot.com/333080043/diff/60001/src/traffic-control/examples/adaptive-red-tests.cc#newcode180 src/traffic-control/examples/adaptive-red-tests.cc:180: #if 0 Why? https://codereview.appspot.com/333080043/diff/60001/src/traffic-control/examples/adaptive-red-tests.cc#newcode206 src/traffic-control/examples/adaptive-red-tests.cc:206: Why? https://codereview.appspot.com/333080043/diff/60001/src/traffic-control/examples/codel-vs-pfifo-basic-test.cc File src/traffic-control/examples/codel-vs-pfifo-basic-test.cc ...
1 month, 2 weeks ago (2017-12-29 22:56:39 UTC) #3
ammo6818-vandals.uidaho.edu
Updates for the latest review comments have been uploaded. https://codereview.appspot.com/333080043/diff/60001/src/traffic-control/examples/adaptive-red-tests.cc File src/traffic-control/examples/adaptive-red-tests.cc (right): https://codereview.appspot.com/333080043/diff/60001/src/traffic-control/examples/adaptive-red-tests.cc#newcode180 src/traffic-control/examples/adaptive-red-tests.cc:180: ...
1 month, 2 weeks ago (2017-12-31 05:15:04 UTC) #4
Tom Henderson
https://codereview.appspot.com/333080043/diff/60001/src/traffic-control/test/codel-queue-disc-test-suite.cc File src/traffic-control/test/codel-queue-disc-test-suite.cc (right): https://codereview.appspot.com/333080043/diff/60001/src/traffic-control/test/codel-queue-disc-test-suite.cc#newcode535 src/traffic-control/test/codel-queue-disc-test-suite.cc:535: NS_UNUSED(oldVal); On 2017/12/31 05:15:03, ammo6818-vandals.uidaho.edu wrote: > On 2017/12/29 ...
1 month, 2 weeks ago (2017-12-31 05:21:49 UTC) #5
ammo6818-vandals.uidaho.edu
Response provided to Tom's review comments about unused parameters. https://codereview.appspot.com/333080043/diff/60001/src/traffic-control/test/codel-queue-disc-test-suite.cc File src/traffic-control/test/codel-queue-disc-test-suite.cc (right): https://codereview.appspot.com/333080043/diff/60001/src/traffic-control/test/codel-queue-disc-test-suite.cc#newcode535 src/traffic-control/test/codel-queue-disc-test-suite.cc:535: ...
1 month, 2 weeks ago (2017-12-31 15:21:45 UTC) #6
Tom Henderson
> > yes, this warning can be suppressed in Visual Studio. however, before going to ...
1 month, 2 weeks ago (2017-12-31 18:57:21 UTC) #7
ammo6818-vandals.uidaho.edu
All review comments have been addressed and are ready for merging into ns-3-dev.
1 week ago (2018-02-11 19:43:38 UTC) #8
ammo6818-vandals.uidaho.edu
16 hours, 31 minutes ago (2018-02-18 05:42:34 UTC) #9
Please let me know if there are any other review comments or merge patches into
ns-3-dev
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 204d58d