Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2542)

Issue 333070043: Eliminate Visual Studio compiler warnings

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 1 week ago by ammo6818-vandals.uidaho.edu
Modified:
7 hours, 25 minutes ago
Reviewers:
S. Deronne
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

Eliminate Visual Studio compiler warnings

Patch Set 1 #

Patch Set 2 : Corrections #

Patch Set 3 : Updates to use C++ style type casts #

Total comments: 102

Patch Set 4 : Updates for latest module changes #

Patch Set 5 : Updated patch to address review comments #

Total comments: 13

Patch Set 6 : Updates to patch set #

Patch Set 7 : Patch updates for x64 build #

Total comments: 19

Patch Set 8 : Patch updates for review comments and latest module changes #

Total comments: 73

Patch Set 9 : Updated patch for latest changes. #

Total comments: 47
Unified diffs Side-by-side diffs Delta from patch set Stats (+432 lines, -342 lines) Patch
M src/wifi/examples/test-interference-helper.cc View 1 2 3 4 5 6 7 8 2 chunks +5 lines, -5 lines 1 comment Download
M src/wifi/examples/wifi-manager-example.cc View 1 2 3 4 5 6 7 8 4 chunks +11 lines, -9 lines 1 comment Download
M src/wifi/helper/athstats-helper.cc View 1 2 3 4 5 6 7 8 2 chunks +1 line, -2 lines 1 comment Download
M src/wifi/helper/wifi-helper.cc View 1 2 3 4 5 6 7 8 3 chunks +3 lines, -2 lines 0 comments Download
M src/wifi/model/aarf-wifi-manager.cc View 1 2 2 chunks +5 lines, -5 lines 1 comment Download
M src/wifi/model/aarfcd-wifi-manager.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M src/wifi/model/amrr-wifi-manager.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M src/wifi/model/ap-wifi-mac.cc View 1 2 3 4 5 6 8 chunks +23 lines, -23 lines 0 comments Download
M src/wifi/model/aparf-wifi-manager.cc View 1 2 3 4 5 6 7 8 10 chunks +17 lines, -17 lines 1 comment Download
M src/wifi/model/arf-wifi-manager.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M src/wifi/model/block-ack-agreement.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/wifi/model/block-ack-cache.h View 1 2 3 4 5 1 chunk +1 line, -1 line 1 comment Download
M src/wifi/model/block-ack-manager.cc View 1 2 3 4 5 6 4 chunks +9 lines, -9 lines 4 comments Download
M src/wifi/model/cara-wifi-manager.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M src/wifi/model/constant-rate-wifi-manager.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M src/wifi/model/ctrl-headers.cc View 1 2 1 chunk +2 lines, -2 lines 1 comment Download
M src/wifi/model/dca-txop.cc View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M src/wifi/model/dcf-manager.cc View 1 2 3 4 chunks +6 lines, -5 lines 0 comments Download
M src/wifi/model/dsss-error-rate-model.h View 1 2 3 4 5 6 4 chunks +4 lines, -4 lines 1 comment Download
M src/wifi/model/dsss-error-rate-model.cc View 1 2 3 4 5 6 4 chunks +4 lines, -4 lines 1 comment Download
M src/wifi/model/dsss-parameter-set.cc View 1 2 3 4 3 chunks +4 lines, -4 lines 1 comment Download
M src/wifi/model/edca-parameter-set.cc View 1 2 3 4 11 chunks +20 lines, -20 lines 0 comments Download
M src/wifi/model/erp-information.cc View 3 chunks +4 lines, -4 lines 1 comment Download
M src/wifi/model/extended-capabilities.cc View 1 2 3 4 2 chunks +2 lines, -0 lines 1 comment Download
M src/wifi/model/he-capabilities.cc View 1 2 3 4 1 chunk +1 line, -0 lines 1 comment Download
M src/wifi/model/ht-operation.cc View 1 2 3 4 3 chunks +4 lines, -4 lines 3 comments Download
M src/wifi/model/ideal-wifi-manager.cc View 1 2 3 4 5 6 7 8 9 chunks +17 lines, -12 lines 2 comments Download
M src/wifi/model/interference-helper.cc View 1 2 3 4 5 6 5 chunks +5 lines, -5 lines 2 comments Download
M src/wifi/model/mac-low.h View 1 2 3 4 2 chunks +1 line, -2 lines 1 comment Download
M src/wifi/model/mac-low.cc View 1 2 3 4 5 6 7 17 chunks +16 lines, -15 lines 3 comments Download
M src/wifi/model/mgt-headers.cc View 1 2 3 4 5 6 4 chunks +8 lines, -6 lines 2 comments Download
M src/wifi/model/minstrel-ht-wifi-manager.cc View 1 2 3 4 5 6 7 8 13 chunks +21 lines, -16 lines 0 comments Download
M src/wifi/model/minstrel-wifi-manager.cc View 1 2 3 4 5 6 7 8 11 chunks +17 lines, -15 lines 0 comments Download
M src/wifi/model/mpdu-aggregator.cc View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M src/wifi/model/msdu-aggregator.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M src/wifi/model/onoe-wifi-manager.cc View 1 2 4 chunks +15 lines, -5 lines 0 comments Download
M src/wifi/model/parf-wifi-manager.cc View 1 2 3 4 5 6 7 8 5 chunks +9 lines, -9 lines 0 comments Download
M src/wifi/model/regular-wifi-mac.cc View 1 2 3 5 chunks +14 lines, -11 lines 1 comment Download
M src/wifi/model/rraa-wifi-manager.cc View 1 2 3 4 5 6 7 8 4 chunks +7 lines, -7 lines 1 comment Download
M src/wifi/model/rrpaa-wifi-manager.cc View 1 2 3 4 5 6 7 8 4 chunks +5 lines, -5 lines 0 comments Download
M src/wifi/model/spectrum-wifi-phy.cc View 1 2 3 4 5 6 6 chunks +9 lines, -9 lines 2 comments Download
M src/wifi/model/sta-wifi-mac.cc View 1 2 3 4 5 7 chunks +10 lines, -10 lines 0 comments Download
M src/wifi/model/supported-rates.h View 1 2 3 4 5 3 chunks +3 lines, -3 lines 1 comment Download
M src/wifi/model/supported-rates.cc View 1 2 3 4 5 6 7 chunks +8 lines, -8 lines 0 comments Download
M src/wifi/model/vht-capabilities.h View 1 2 3 4 1 chunk +2 lines, -2 lines 1 comment Download
M src/wifi/model/vht-capabilities.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 2 comments Download
M src/wifi/model/wifi-information-element.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/wifi/model/wifi-information-element-vector.cc View 1 2 3 4 5 6 3 chunks +3 lines, -0 lines 1 comment Download
M src/wifi/model/wifi-mac-header.h View 1 2 3 4 5 1 chunk +1 line, -1 line 1 comment Download
M src/wifi/model/wifi-mac-header.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M src/wifi/model/wifi-mac-queue.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/wifi/model/wifi-mac-queue.cc View 1 chunk +1 line, -1 line 1 comment Download
M src/wifi/model/wifi-mac-trailer.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M src/wifi/model/wifi-mode.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M src/wifi/model/wifi-net-device.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/wifi/model/wifi-phy.h View 1 2 3 4 5 6 7 2 chunks +3 lines, -3 lines 1 comment Download
M src/wifi/model/wifi-phy.cc View 1 2 3 4 5 6 7 8 chunks +12 lines, -12 lines 0 comments Download
M src/wifi/model/wifi-phy-tag.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M src/wifi/model/wifi-radio-energy-model.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 1 comment Download
M src/wifi/model/wifi-remote-station-manager.cc View 1 2 3 4 5 6 7 8 13 chunks +42 lines, -8 lines 1 comment Download
M src/wifi/model/wifi-utils.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/wifi/model/yans-wifi-channel.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M src/wifi/test/dcf-manager-test.cc View 1 2 3 4 5 6 7 8 8 chunks +11 lines, -11 lines 1 comment Download
M src/wifi/test/spectrum-wifi-phy-test.cc View 1 2 3 4 5 6 7 8 3 chunks +6 lines, -0 lines 1 comment Download
M src/wifi/test/tx-duration-test.cc View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -2 lines 1 comment Download
M src/wifi/test/wifi-test.cc View 1 2 3 4 5 6 7 8 8 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 20
S. Deronne
Robert, thanks for your huge work. I added some comments inline. I am also not ...
2 months ago (2017-12-17 15:39:16 UTC) #1
S. Deronne
https://codereview.appspot.com/333070043/diff/40001/src/wifi/model/ap-wifi-mac.cc File src/wifi/model/ap-wifi-mac.cc (left): https://codereview.appspot.com/333070043/diff/40001/src/wifi/model/ap-wifi-mac.cc#oldcode979 src/wifi/model/ap-wifi-mac.cc:979: { i should be coded on 8 bits to ...
2 months ago (2017-12-17 16:02:45 UTC) #2
S. Deronne
https://codereview.appspot.com/333070043/diff/40001/src/wifi/helper/athstats-helper.cc File src/wifi/helper/athstats-helper.cc (right): https://codereview.appspot.com/333070043/diff/40001/src/wifi/helper/athstats-helper.cc#newcode211 src/wifi/helper/athstats-helper.cc:211: NS_UNUSED(preamble); we can simply add preamble in the log ...
2 months ago (2017-12-17 16:18:27 UTC) #3
S. Deronne
https://codereview.appspot.com/333070043/diff/40001/src/wifi/model/dsss-parameter-set.cc File src/wifi/model/dsss-parameter-set.cc (right): https://codereview.appspot.com/333070043/diff/40001/src/wifi/model/dsss-parameter-set.cc#newcode22 src/wifi/model/dsss-parameter-set.cc:22: #include "ns3/unused.h" needed? https://codereview.appspot.com/333070043/diff/40001/src/wifi/model/edca-parameter-set.cc File src/wifi/model/edca-parameter-set.cc (right): https://codereview.appspot.com/333070043/diff/40001/src/wifi/model/edca-parameter-set.cc#newcode22 src/wifi/model/edca-parameter-set.cc:22: ...
2 months ago (2017-12-17 16:24:21 UTC) #4
S. Deronne
https://codereview.appspot.com/333070043/diff/40001/src/wifi/model/mac-low.cc File src/wifi/model/mac-low.cc (left): https://codereview.appspot.com/333070043/diff/40001/src/wifi/model/mac-low.cc#oldcode69 src/wifi/model/mac-low.cc:69: { why no unused needed for the duration? https://codereview.appspot.com/333070043/diff/40001/src/wifi/model/regular-wifi-mac.cc ...
2 months ago (2017-12-17 16:49:29 UTC) #5
S. Deronne
https://codereview.appspot.com/333070043/diff/40001/src/wifi/test/wifi-test.cc File src/wifi/test/wifi-test.cc (right): https://codereview.appspot.com/333070043/diff/40001/src/wifi/test/wifi-test.cc#newcode586 src/wifi/test/wifi-test.cc:586: NS_UNUSED(adr); adr can be removed https://codereview.appspot.com/333070043/diff/40001/src/wifi/test/wifi-test.cc#newcode1067 src/wifi/test/wifi-test.cc:1067: NS_UNUSED(adr); adr ...
2 months ago (2017-12-17 17:07:37 UTC) #6
S. Deronne
https://codereview.appspot.com/333070043/diff/40001/src/wifi/test/block-ack-test-suite.cc File src/wifi/test/block-ack-test-suite.cc (right): https://codereview.appspot.com/333070043/diff/40001/src/wifi/test/block-ack-test-suite.cc#newcode274 src/wifi/test/block-ack-test-suite.cc:274: for (uint16_t i = 179; i < 220; i++) ...
2 months ago (2017-12-17 17:14:58 UTC) #7
ammo6818-vandals.uidaho.edu
An updated patch has been uploaded to address your review comments. I have also replied ...
2 months ago (2017-12-20 04:16:35 UTC) #8
S. Deronne
Could you please provide an updated patch based on the latest ns-3-dev? As you might ...
1 month, 3 weeks ago (2017-12-22 22:28:28 UTC) #9
S. Deronne
https://codereview.appspot.com/333070043/diff/80001/src/wifi/examples/test-interference-helper.cc File src/wifi/examples/test-interference-helper.cc (right): https://codereview.appspot.com/333070043/diff/80001/src/wifi/examples/test-interference-helper.cc#newcode121 src/wifi/examples/test-interference-helper.cc:121: txVector.SetTxPowerLevel (static_cast<uint8_t>(m_input.txPowerLevelA)); this is not correct initially, they set ...
1 month, 3 weeks ago (2017-12-23 10:19:59 UTC) #10
ammo6818-vandals.uidaho.edu
Additional changes for your latest review comments. https://codereview.appspot.com/333070043/diff/40001/src/wifi/model/ap-wifi-mac.cc File src/wifi/model/ap-wifi-mac.cc (left): https://codereview.appspot.com/333070043/diff/40001/src/wifi/model/ap-wifi-mac.cc#oldcode979 src/wifi/model/ap-wifi-mac.cc:979: { On ...
1 month, 3 weeks ago (2017-12-23 15:14:33 UTC) #11
S. Deronne
Robert, am I really reviewing the latest patch set? I'd like to start to merge ...
1 week, 3 days ago (2018-02-08 20:53:31 UTC) #12
ammo6818-vandals.uidaho.edu
The review comments have been replied to or changes uploaded to address. https://codereview.appspot.com/333070043/diff/140001/src/wifi/examples/test-interference-helper.cc File src/wifi/examples/test-interference-helper.cc ...
1 week ago (2018-02-11 19:41:06 UTC) #13
S. Deronne
I will start pushing what can be done already. My main concerns are still those ...
2 days ago (2018-02-16 21:24:33 UTC) #14
S. Deronne
I am starting to push some changes to ns-3-dev, please address my comments so that ...
1 day, 14 hours ago (2018-02-17 08:13:16 UTC) #15
S. Deronne
I pushed some changes to ns-3-dev already. Could you please update your patchset and address ...
1 day, 2 hours ago (2018-02-17 20:00:22 UTC) #16
ammo6818-vandals.uidaho.edu
Updated patch for latest changes uploaded. https://codereview.appspot.com/333070043/diff/40001/src/wifi/examples/test-interference-helper.cc File src/wifi/examples/test-interference-helper.cc (right): https://codereview.appspot.com/333070043/diff/40001/src/wifi/examples/test-interference-helper.cc#newcode121 src/wifi/examples/test-interference-helper.cc:121: txVector.SetTxPowerLevel (static_cast<int8_t>(m_input.txPowerLevelA)); On ...
17 hours, 5 minutes ago (2018-02-18 05:13:10 UTC) #17
S. Deronne
https://codereview.appspot.com/333070043/diff/140001/src/wifi/examples/test-interference-helper.cc File src/wifi/examples/test-interference-helper.cc (right): https://codereview.appspot.com/333070043/diff/140001/src/wifi/examples/test-interference-helper.cc#newcode251 src/wifi/examples/test-interference-helper.cc:251: uint64_t delay = 0; //microseconds OK, thanks. https://codereview.appspot.com/333070043/diff/140001/src/wifi/examples/wifi-manager-example.cc File ...
14 hours, 33 minutes ago (2018-02-18 07:44:41 UTC) #18
S. Deronne
https://codereview.appspot.com/333070043/diff/200001/src/wifi/examples/test-interference-helper.cc File src/wifi/examples/test-interference-helper.cc (right): https://codereview.appspot.com/333070043/diff/200001/src/wifi/examples/test-interference-helper.cc#newcode275 src/wifi/examples/test-interference-helper.cc:275: //LogComponentEnable ("SimpleFrameCaptureModel", LOG_LEVEL_ALL); I suggest to simply remove them ...
14 hours, 11 minutes ago (2018-02-18 08:06:44 UTC) #19
S. Deronne
7 hours, 25 minutes ago (2018-02-18 14:52:57 UTC) #20
I will continue to push. 
I still do not agree with all those NS_UNUSED.
Please always check against the latest ns-3-dev so that I can see the remaining
part, as long as I do not know how to reproduce on my machine, I do not know the
remaining warnings (or whether additional ones popped up)...

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/aarf-wifi...
File src/wifi/model/aarf-wifi-manager.cc (right):

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/aarf-wifi...
src/wifi/model/aarf-wifi-manager.cc:248: if (m_currentRate != mode.GetDataRate
(static_cast<uint8_t>(channelWidth)))
channelWidth is already uint8_t

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/aparf-wif...
File src/wifi/model/aparf-wifi-manager.cc (right):

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/aparf-wif...
src/wifi/model/aparf-wifi-manager.cc:130: m_minPower =
static_cast<uint8_t>(phy->GetTxPowerStart ());
m_minPower is already uint8_t

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/block-ack...
File src/wifi/model/block-ack-cache.h (right):

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/block-ack...
src/wifi/model/block-ack-cache.h:80: uint16_t m_winSize; ///< window size
OK

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/block-ack...
File src/wifi/model/block-ack-manager.cc (right):

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/block-ack...
src/wifi/model/block-ack-manager.cc:373: || SwitchToBlockAckIfNeeded (recip,
tid, hdr.GetSequenceNumber ())))
why this rename? If not applicable for cleaning up warning, please remove from
the patchset.

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/block-ack...
src/wifi/model/block-ack-manager.cc:410: Mac48Address hdrRecipient =
hdr.GetAddr1 ();
idem

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/block-ack...
src/wifi/model/block-ack-manager.cc:570:
static_cast<uint8_t>((*queueIt).hdr.GetFragmentNumber ())))
GetFragmentNumber will return uint8_t in a next commit.

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/block-ack...
src/wifi/model/block-ack-manager.cc:633: m_stationManager->ReportAmpduTxStatus
(recipient, tid, static_cast<uint8_t>(nSuccessfulMpdus),
static_cast<uint8_t>(nFailedMpdus), rxSnr, dataSnr);
nSuccessfulMpdus and nFailedMpdus will be declared as uint8_t in a next commit.

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/ctrl-head...
File src/wifi/model/ctrl-headers.cc (right):

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/ctrl-head...
src/wifi/model/ctrl-headers.cc:702: index = static_cast<uint8_t>(4096 -
m_startingSeq + seq);
to make a decision: or we keep those case, or we accept to use uint16_t for
index.

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/dsss-erro...
File src/wifi/model/dsss-error-rate-model.cc (left):

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/dsss-erro...
src/wifi/model/dsss-error-rate-model.cc:98: #ifdef HAVE_GSL
OK to push those changes

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/dsss-erro...
File src/wifi/model/dsss-error-rate-model.h (left):

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/dsss-erro...
src/wifi/model/dsss-error-rate-model.h:117: static double SymbolErrorProb256Cck
(double e1); /// equation (17) in Pursley's paper
OK to push those changes

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/dsss-para...
File src/wifi/model/dsss-parameter-set.cc (left):

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/dsss-para...
src/wifi/model/dsss-parameter-set.cc:82: }
OK to push those changes

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/erp-infor...
File src/wifi/model/erp-information.cc (left):

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/erp-infor...
src/wifi/model/erp-information.cc:112: }
OK to push those changes

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/extended-...
File src/wifi/model/extended-capabilities.cc (right):

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/extended-...
src/wifi/model/extended-capabilities.cc:414: NS_UNUSED(extendedcapabilities);
maybe a better solution is to implement the body of those functions?

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/he-capabi...
File src/wifi/model/he-capabilities.cc (right):

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/he-capabi...
src/wifi/model/he-capabilities.cc:22: #include "ns3/unused.h"
to be removed

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/ht-operat...
File src/wifi/model/ht-operation.cc (right):

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/ht-operat...
src/wifi/model/ht-operation.cc:335: uint8_t val = 0;
correct

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/ht-operat...
src/wifi/model/ht-operation.cc:371: m_reservedInformationSubset2_1 =
static_cast<uint8_t>((ctrl >> 5) & 0x07ff);
OK

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/ht-operat...
src/wifi/model/ht-operation.cc:481: uint16_t informationsubset3 = i.ReadU16 ();
correct

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/ideal-wif...
File src/wifi/model/ideal-wifi-manager.cc (right):

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/ideal-wif...
src/wifi/model/ideal-wifi-manager.cc:37: uint8_t m_nss;             //!< number
of spacial streams
Correct :-)

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/ideal-wif...
src/wifi/model/ideal-wifi-manager.cc:221: NS_LOG_FUNCTION (this << station <<
rxSnr <<txMode);
I prefer this solution :-)

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/interfere...
File src/wifi/model/interference-helper.cc (right):

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/interfere...
src/wifi/model/interference-helper.cc:130: m_firstPower (0.0),
does this really change something? I had myself cleaned those 0.0, but if you
say this plays a role then at least I know :-)

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/interfere...
src/wifi/model/interference-helper.cc:305: double csr =
m_errorRateModel->GetChunkSuccessRate (mode, txVector, snir, (uint32_t)nbits);
C-style cast NOK, and this functions expects a uint64_t and not uint32_t, so
this cast is not valid.

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/mac-low.cc
File src/wifi/model/mac-low.cc (right):

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/mac-low.c...
src/wifi/model/mac-low.cc:1957: uint16_t mappedSeqControl =
static_cast<uint16_t>(QosUtilsMapSeqControlToUniqueInteger
(hdr.GetSequenceControl (), endSequence));
make QosUtilsMapSeqControlToUniqueInteger returns uint16_t?

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/mac-low.c...
src/wifi/model/mac-low.cc:2417: if (!edcaIt->second->GetMpduAggregator
()->CanBeAggregated (peekedPacket->GetSize () + peekedHdr.GetSize () +
WIFI_MAC_FCS_LENGTH, aggregatedPacket, static_cast<uint8_t>(size)))
blockack size should be adapted in the code to be limited to uint8_t, an BACK
will not be more than 255 bytes.

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/mac-low.c...
src/wifi/model/mac-low.cc:2682: ampdutag.SetRemainingNbOfMpdus
(static_cast<uint8_t>(i - 1));
define i as uint8_t should be fine

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/mac-low.h
File src/wifi/model/mac-low.h (right):

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/mac-low.h...
src/wifi/model/mac-low.h:661: void SendDataAfterCts (Time duration);
well spotted :-)

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/mgt-heade...
File src/wifi/model/mgt-headers.cc (right):

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/mgt-heade...
src/wifi/model/mgt-headers.cc:441: i.WriteHtolsbU16
(static_cast<uint16_t>(m_beaconInterval / 1024));
I guess we do not have choice here, so OK for this cast.

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/mgt-heade...
src/wifi/model/mgt-headers.cc:977: m_actionValue =
static_cast<uint8_t>(action.selfProtectedAction);
I also think only cast is the solution here

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/regular-w...
File src/wifi/model/regular-wifi-mac.cc (right):

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/regular-w...
src/wifi/model/regular-wifi-mac.cc:1368: GetVOQueue ()->GetMpduAggregator
()->SetMaxAmpduSize (static_cast<uint16_t>(m_voMaxAmpduSize));
m_voMaxAmpduSize should be uint16_t,  as well as be, bk and vi, and both msdu
and mpdu.

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/rraa-wifi...
File src/wifi/model/rraa-wifi-manager.cc (right):

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/rraa-wifi...
src/wifi/model/rraa-wifi-manager.cc:208: station->m_nRate =
static_cast<uint8_t>(GetNSupported (station));
GetNSupported returns uint8_t now

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/spectrum-...
File src/wifi/model/spectrum-wifi-phy.cc (right):

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/spectrum-...
src/wifi/model/spectrum-wifi-phy.cc:110: m_rxSpectrumModel =
WifiSpectrumValueHelper::GetSpectrumModel (GetFrequency (), GetChannelWidth (),
GetBandBandwidth (), static_cast<uint8_t>(GetGuardBandwidth ()));
Make GetGuardBandwidth as uint8_t? But I fear this could be larger than 255, so
maybe a better solution is to change GetSpectrumModel definition.

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/spectrum-...
src/wifi/model/spectrum-wifi-phy.cc:381: uint32_t guardBandwidth = 0;
correct

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/supported...
File src/wifi/model/supported-rates.h (right):

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/supported...
src/wifi/model/supported-rates.h:157: void AddSupportedRate (uint64_t bs);
not sure this is allowed, to be check in the IE definition from the standard.

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/vht-capab...
File src/wifi/model/vht-capabilities.cc (right):

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/vht-capab...
src/wifi/model/vht-capabilities.cc:115: uint32_t vhtinfo = i.ReadLsbtohU32 ();
Good

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/vht-capab...
src/wifi/model/vht-capabilities.cc:184: n = (i * 2) + 32;
Indeed, not needed to redefine  n :-)

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/vht-capab...
File src/wifi/model/vht-capabilities.h (right):

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/vht-capab...
src/wifi/model/vht-capabilities.h:290: uint8_t m_supportedChannelWidthSet; ///<
supported channel width set
OK, correct.

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/wifi-info...
File src/wifi/model/wifi-information-element-vector.cc (right):

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/wifi-info...
src/wifi/model/wifi-information-element-vector.cc:108: case 0: // eliminate
compiler warning
OK

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/wifi-mac-...
File src/wifi/model/wifi-mac-header.h (right):

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/wifi-mac-...
src/wifi/model/wifi-mac-header.h:591: uint8_t m_qosStuff; ///< QOS stuff
OK to push this change

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/wifi-mac-...
File src/wifi/model/wifi-mac-queue.cc (right):

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/wifi-mac-...
src/wifi/model/wifi-mac-queue.cc:100: TimeValue (MilliSeconds (500)),
OK

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/wifi-phy.h
File src/wifi/model/wifi-phy.h (left):

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/wifi-phy....
src/wifi/model/wifi-phy.h:1962: bool     m_stbc;                  //!< Flag if
STBC is used
Very good, I will push.

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/wifi-radi...
File src/wifi/model/wifi-radio-energy-model.cc (right):

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/wifi-radi...
src/wifi/model/wifi-radio-energy-model.cc:470: NS_LOG_FUNCTION (this);
not needed

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/wifi-remo...
File src/wifi/model/wifi-remote-station-manager.cc (left):

https://codereview.appspot.com/333070043/diff/200001/src/wifi/model/wifi-remo...
src/wifi/model/wifi-remote-station-manager.cc:27: #include "wifi-phy.h"
OK
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 204d58d