Issue 332970043: Store plots after runs, finish task 1.1, 1.2

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 332970043: Store plots after runs, finish task 1.1, 1.2

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 6 months ago by tonythomas

Modified:
6 years, 6 months ago

Reviewers:
david.tomic11, cynthiamao122

CC:
dkostic, kirill.sc, seregibenjamin, tonythomas, cynthiamao122_gmail.com, liangzijie1437_gmail.com

Visibility:
Public.

More Reviews

Description

Fix function params' Stop iterating latencies for task 1.1x BUG=REP-

Patch Set 1 #

Patch Set 2 : Reduce ping time intervals #

Patch Set 3 : Fix ping command #

Patch Set 4 : return propoerly from ping execute #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -38 lines)			Patch
M	api.py	View	1	2 chunks	+12 lines, -4 lines	1 comment	Download
M	launch_lx3.py	View	1	3 chunks	+27 lines, -13 lines	0 comments	Download
M	utils/execute_ping_nodes_generate_output.py	View	1 2 3	1 chunk	+4 lines, -2 lines	0 comments	Download
M	utils/plot_results_from_ping.py	View	1	2 chunks	+22 lines, -19 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

david.tomic11

On 2017/10/21 14:19:19, tonythomas wrote: > Code courtesy: > @Ziljie, @Xinyuem. approve!

6 years, 6 months ago (2017-10-21 14:21:20 UTC) #2

xinyue

On 2017/10/21 14:19:19, tonythomas wrote: > Code courtesy: > @Ziljie, @Xinyuem. It's great and helpful! ...

6 years, 6 months ago (2017-10-21 14:24:18 UTC) #3

xinyue

6 years, 6 months ago (2017-10-21 14:24:46 UTC) #4

Great!

https://codereview.appspot.com/332970043/diff/60001/api.py
File api.py (right):

https://codereview.appspot.com/332970043/diff/60001/api.py#newcode91
api.py:91: i = i + 1
It's great and helpful! good job

Expand All Messages | Collapse All Messages