Issue 332960043: ticket:13415 Setting error code in terminal NumberFormatter methods when applicable. Renaming unpro…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 332960043: ticket:13415 Setting error code in terminal NumberFormatter methods when applicable. Renaming unpro… (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 6 months ago by sffc

Modified:
6 years, 6 months ago

Reviewers:
markus.icu

CC:
andy.heninger

Base URL:
svn+icussh://source.icu-project.org/repos/icu/trunk/icu4c/source/

Visibility:
Public.

More Reviews

Description

ticket:13415 Setting error code in terminal NumberFormatter methods when applicable. Renaming unproposed error codes for consistency with existing error codes in utypes.h.

Patch Set 2 : Responding to Markus comment #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -37 lines)			Patch
M	i18n/number_fluent.cpp	View	1	4 chunks	+31 lines, -11 lines	0 comments	Download
M	i18n/number_integerwidth.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	i18n/number_notation.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	i18n/number_padding.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	i18n/number_rounding.cpp	View		12 chunks	+12 lines, -12 lines	0 comments	Download
M	i18n/number_types.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	i18n/unicode/numberformatter.h	View		2 chunks	+9 lines, -5 lines	0 comments	Download
M	test/intltest/numbertest_api.cpp	View		1 chunk	+10 lines, -3 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

markus.icu

Otherwise LGTM https://codereview.appspot.com/332960043/diff/1/i18n/number_fluent.cpp File i18n/number_fluent.cpp (right): https://codereview.appspot.com/332960043/diff/1/i18n/number_fluent.cpp#newcode347 i18n/number_fluent.cpp:347: if (fResults == nullptr) { Before this ...

6 years, 6 months ago (2017-10-21 05:04:19 UTC) #2

Committed revision 40632.

Expand All Messages | Collapse All Messages