Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2141)

Issue 332900043: [l2tpreg] Updated setup.py with more elegant bdist_msi version work-around #14 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 6 months ago by Joachim Metz
Modified:
6 years, 6 months ago
Reviewers:
onager
CC:
kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[l2tpreg] Updated setup.py with more elegant bdist_msi version work-around #14

Patch Set 1 : Updated setup.py with more elegant bdist_msi version work-around #14 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -65 lines) Patch
M setup.py View 6 chunks +91 lines, -65 lines 0 comments Download

Messages

Total messages: 6
Joachim Metz
6 years, 6 months ago (2017-10-14 04:38:08 UTC) #1
Joachim Metz
Code updated.
6 years, 6 months ago (2017-10-14 04:43:18 UTC) #2
Joachim Metz
Code updated.
6 years, 6 months ago (2017-10-14 04:49:02 UTC) #3
Joachim Metz
Code updated.
6 years, 6 months ago (2017-10-14 04:51:03 UTC) #4
onager
LGTM
6 years, 6 months ago (2017-10-19 23:30:10 UTC) #5
Joachim Metz
6 years, 6 months ago (2017-10-20 04:43:33 UTC) #6
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close setuppy
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b