Issue 332890043: [plaso] Replace countable usages of storage with store

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 332890043: [plaso] Replace countable usages of storage with store (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 6 months ago by onager

Modified:
6 years, 6 months ago

Reviewers:
Joachim Metz

CC:
Joachim Metz, jberggren, kiddi, log2timeline-dev_googlegroups.com, aaronp

Visibility:
Public.

More Reviews

Description

[plaso] Replace countable usages of storage with store

Patch Set 1 #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+85 lines, -86 lines)			Patch
M	plaso/cli/pinfo_tool.py	View	12 chunks	+19 lines, -19 lines	0 comments	Download
M	plaso/cli/psort_tool.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	plaso/cli/psteal_tool.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	plaso/containers/events.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	plaso/multi_processing/task_engine.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	plaso/storage/fake_storage.py	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	plaso/storage/gzip_file.py	View	5 chunks	+10 lines, -10 lines	0 comments	Download
M	plaso/storage/interface.py	View	10 chunks	+20 lines, -20 lines	1 comment	Download
M	plaso/storage/sqlite_file.py	View	9 chunks	+12 lines, -12 lines	0 comments	Download
M	plaso/storage/zip_file.py	View	8 chunks	+10 lines, -10 lines	0 comments	Download
M	tests/cli/pinfo_tool.py	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	tests/storage/interface.py	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	tools/pinfo.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

onager

On 2017/10/13 22:12:50, onager wrote: Some more background on this: * "Storage" is an uncountable ...

6 years, 6 months ago (2017-10-13 22:16:30 UTC) #2

Joachim Metz

LGTM https://codereview.appspot.com/332890043/diff/1/plaso/storage/interface.py File plaso/storage/interface.py (right): https://codereview.appspot.com/332890043/diff/1/plaso/storage/interface.py#newcode304 plaso/storage/interface.py:304: """Interface for single-file stores.""" single-file => file-based having ...

6 years, 6 months ago (2017-10-14 05:08:20 UTC) #3

onager

6 years, 6 months ago (2017-10-19 23:16:11 UTC) #4

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close rename_storage

Expand All Messages | Collapse All Messages