Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2479)

Issue 332630043: [plaso] Replaced FromTimeParts in favor of dfdatetime and fixed #1700

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month ago by Joachim Metz
Modified:
1 week ago
Reviewers:
jberggren, onager
CC:
romaing, kiddi, log2timeline-dev_googlegroups.com, aaronp
Visibility:
Public.

Description

[plaso] Replaced FromTimeParts in favor of dfdatetime and fixed #1700

Patch Set 1 #

Total comments: 6

Patch Set 2 : Changes after review #

Total comments: 8

Patch Set 3 : Deprecated use of FromTimeParts function in favor of dfdatetime #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -277 lines) Patch
M plaso/lib/timelib.py View 1 2 2 chunks +0 lines, -43 lines 0 comments Download
M plaso/parsers/sccm.py View 1 2 9 chunks +88 lines, -54 lines 0 comments Download
M plaso/parsers/symantec.py View 1 8 chunks +60 lines, -63 lines 0 comments Download
M plaso/parsers/syslog.py View 1 6 chunks +45 lines, -40 lines 0 comments Download
M plaso/parsers/syslog_plugins/cron.py View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M plaso/parsers/syslog_plugins/interface.py View 2 chunks +6 lines, -7 lines 0 comments Download
M plaso/parsers/syslog_plugins/ssh.py View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M tests/lib/timelib.py View 1 2 1 chunk +0 lines, -19 lines 0 comments Download
M tests/parsers/sccm.py View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M tests/parsers/symantec.py View 1 chunk +10 lines, -15 lines 0 comments Download
M tests/parsers/syslog.py View 3 chunks +31 lines, -23 lines 0 comments Download

Messages

Total messages: 10
Joachim Metz
1 month ago (2018-01-18 19:19:23 UTC) #1
onager
This CL doesn't seem to actually remove FromTimeParts from timelib, and leaves the usage in ...
1 month ago (2018-01-19 04:51:07 UTC) #2
Joachim Metz
> This CL doesn't seem to actually remove FromTimeParts from timelib, and leaves > the ...
1 month ago (2018-01-19 05:21:54 UTC) #3
Joachim Metz
Code updated.
1 month ago (2018-01-19 05:31:15 UTC) #4
onager
Please also change the CL description, as the FromTimeParts function hasn't been removed. https://codereview.appspot.com/332630043/diff/20001/plaso/parsers/syslog.py File ...
3 weeks, 4 days ago (2018-01-24 07:46:08 UTC) #5
Joachim Metz
https://codereview.appspot.com/332630043/diff/20001/plaso/parsers/syslog.py File plaso/parsers/syslog.py (right): https://codereview.appspot.com/332630043/diff/20001/plaso/parsers/syslog.py#newcode152 plaso/parsers/syslog.py:152: pyparsing.Word(pyparsing.nums, exact=4) + pyparsing.Literal('-') + Because it was incorrect ...
3 weeks, 4 days ago (2018-01-24 07:54:50 UTC) #6
Joachim Metz
> Please also change the CL description, as the FromTimeParts function hasn't been removed. Deprecation ...
3 weeks, 4 days ago (2018-01-24 07:56:11 UTC) #7
Joachim Metz
Code updated.
2 weeks ago (2018-02-04 09:51:00 UTC) #8
onager
https://codereview.appspot.com/332630043/diff/20001/plaso/parsers/syslog.py File plaso/parsers/syslog.py (right): https://codereview.appspot.com/332630043/diff/20001/plaso/parsers/syslog.py#newcode152 plaso/parsers/syslog.py:152: pyparsing.Word(pyparsing.nums, exact=4) + pyparsing.Literal('-') + On 2018/01/24 07:54:50, Joachim ...
1 week ago (2018-02-11 12:12:28 UTC) #9
Joachim Metz
1 week ago (2018-02-11 13:26:14 UTC) #10
https://codereview.appspot.com/332630043/diff/20001/plaso/parsers/syslog.py
File plaso/parsers/syslog.py (right):

https://codereview.appspot.com/332630043/diff/20001/plaso/parsers/syslog.py#n...
plaso/parsers/syslog.py:152: pyparsing.Word(pyparsing.nums, exact=4) +
pyparsing.Literal('-') +
the previous definitions produced integers, the new approach needs a string.

https://codereview.appspot.com/332630043/diff/20001/plaso/parsers/syslog.py#n...
plaso/parsers/syslog.py:158: pyparsing.Word(pyparsing.nums, exact=6) +
pyparsing.oneOf(['-', '+']) +
On 2018/02/11 12:12:28, onager wrote:
> On 2018/01/24 07:54:50, Joachim Metz wrote:
> > this is to match the log format not to match ISO8601
> 
> OK, then please change the key name here, as it's confusing.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 204d58d