Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(17)

Issue 332310043: [plaso] Fixed handling tagging-file argument and added tests #1513 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 4 months ago by Joachim Metz
Modified:
6 years, 4 months ago
Reviewers:
romaing
CC:
jberggren, onager, kiddi, log2timeline-dev_googlegroups.com, aaronp
Visibility:
Public.

Description

[plaso] Fixed handling tagging-file argument and added tests #1513

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -11 lines) Patch
M plaso/analysis/manager.py View 5 chunks +8 lines, -8 lines 0 comments Download
M plaso/cli/tool_options.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/cli/tool_options.py View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Joachim Metz
6 years, 4 months ago (2017-11-22 06:42:33 UTC) #1
romaing
LGTM
6 years, 4 months ago (2017-11-23 16:39:56 UTC) #2
Joachim Metz
6 years, 4 months ago (2017-11-24 05:49:06 UTC) #3
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close fix1513
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b