Issue 332270043: 6EP tunnel decapsulation first draft

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 332270043: 6EP tunnel decapsulation first draft

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 5 months ago by armangungor

Modified:
6 years, 5 months ago

Reviewers:
mustafa.alabaychi, voravitt, robert.herjulf.olsson, safa.ismail.si, dima.alissa, Alaiin

CC:
dkostic

Visibility:
Public.

More Reviews

Description

6EP tunnel decapsulation first draft BUG=

Patch Set 1 #

Total comments: 3

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+148 lines, -106 lines)			Patch
A	IoT_internal/tunnel_test/iep_simulator.py	View	1 chunk	+32 lines, -0 lines	0 comments	Download
M	core/net/tunnel/tunnel.c	View	20 chunks	+115 lines, -105 lines	3 comments	Download
M	core/net/tunnel/tunnel-eth-interface.c	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

mustafa.alabaychi

6 years, 5 months ago (2017-11-22 09:29:42 UTC) #2

Thank you Arman! Great job!

https://codereview.appspot.com/332270043/diff/1/core/net/tunnel/tunnel.c
File core/net/tunnel/tunnel.c (right):

https://codereview.appspot.com/332270043/diff/1/core/net/tunnel/tunnel.c#newc...
core/net/tunnel/tunnel.c:571: resultpacket[payload_start+16] = src_port & 0xff;
I would appreciate if you could add per line comments to these lines to let us
within the team understand it easier.

https://codereview.appspot.com/332270043/diff/1/core/net/tunnel/tunnel.c#newc...
core/net/tunnel/tunnel.c:572: resultpacket[payload_start+17] = src_port >> 8;
the purpose of this 8 digit shift?

https://codereview.appspot.com/332270043/diff/1/core/net/tunnel/tunnel.c#newc...
core/net/tunnel/tunnel.c:784: if(uip_htons(tcphdr->destport) <
EPHEMERAL_PORTRANGE) {
The comments above do not belong home. Don't they?

Expand All Messages | Collapse All Messages