Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1070)

Issue 332170043: Eliminate Visual Studio compiler warnings (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 2 months ago by ammo6818-vandals.uidaho.edu
Modified:
1 year, 10 months ago
Reviewers:
Peter Barnes
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

Eliminate Visual Studio compiler warnings

Patch Set 1 #

Patch Set 2 : Updates to use C++ style type casts #

Patch Set 3 : Patch updates for x64 build #

Patch Set 4 : Patch updates for review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M src/mpi/model/null-message-mpi-interface.cc View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M src/mpi/model/remote-channel-bundle.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/mpi/model/remote-channel-bundle.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M src/mpi/model/remote-channel-bundle-manager.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2
ammo6818-vandals.uidaho.edu
Please let me know if there are any other review comments or merge into ns-3-dev
1 year, 11 months ago (2018-02-18 05:47:38 UTC) #1
Peter Barnes
1 year, 11 months ago (2018-02-21 23:18:57 UTC) #2
Pushed in r229c5432
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b