Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(362)

Issue 332050043: ticket:13411 Making "using namespace" statements consistent across number formatting cpp files. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 5 months ago by sffc
Modified:
6 years, 5 months ago
Reviewers:
andy.heninger, jshin, jeff.genovy, markus.icu
Base URL:
svn+icussh://source.icu-project.org/repos/icu/trunk/icu4c/source/
Visibility:
Public.

Description

ticket:13411 Making "using namespace" statements consistent across number formatting cpp files.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -3 lines) Patch
M i18n/number_affixutils.cpp View 1 chunk +2 lines, -1 line 2 comments Download
M i18n/number_compact.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M i18n/number_decimalquantity.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M i18n/number_decimfmtprops.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M i18n/number_formatimpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M i18n/number_grouping.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M i18n/number_integerwidth.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M i18n/number_longnames.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M i18n/number_modifiers.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M i18n/number_notation.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M i18n/number_padding.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M i18n/number_patternmodifier.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M i18n/number_patternstring.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M i18n/number_rounding.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M i18n/number_scientific.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M i18n/number_stringbuilder.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10
sffc
6 years, 5 months ago (2017-10-23 08:02:44 UTC) #1
jshin
See my comments below. I think you have to do the same for all the ...
6 years, 5 months ago (2017-10-23 08:46:20 UTC) #2
jshin
You can test it on Windows with U_USING_ICU_NAMESPACE set to 0.
6 years, 5 months ago (2017-10-23 08:47:17 UTC) #3
sffc
+Andy My understanding based on discussions with Andy last month is that the ICU namespace ...
6 years, 5 months ago (2017-10-23 08:50:50 UTC) #4
jshin
On 2017/10/23 08:50:50, sffc wrote: > +Andy > > My understanding based on discussions with ...
6 years, 5 months ago (2017-10-23 16:35:49 UTC) #5
andy.heninger
Version renaming for the icu namespace is set up in uversion.h, lines 114-117, # define ...
6 years, 5 months ago (2017-10-23 18:12:32 UTC) #6
markus.icu
On 2017/10/23 18:12:32, andy.heninger wrote: > Version renaming for the icu namespace is set up ...
6 years, 5 months ago (2017-10-24 20:38:08 UTC) #7
andy.heninger
LGTM
6 years, 5 months ago (2017-10-25 00:20:03 UTC) #8
sffc
In terms of this particular code review, we are only touching the implementation files. The ...
6 years, 5 months ago (2017-10-25 00:23:45 UTC) #9
sffc
6 years, 5 months ago (2017-10-25 00:25:14 UTC) #10
Committed revision 40630.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b