Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(662)

Issue 331980043: [plaso] Made Unicode strings the default in parsers tests #1268 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 6 months ago by Joachim Metz
Modified:
6 years, 6 months ago
Reviewers:
aaronp
CC:
jberggren, romaing, onager, kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[plaso] Made Unicode strings the default in parsers tests #1268

Patch Set 1 : Made Unicode strings the default in parsers tests #1268 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1860 lines, -1738 lines) Patch
M tests/parsers/amcache.py View 3 chunks +3 lines, -0 lines 0 comments Download
M tests/parsers/android_app_usage.py View 3 chunks +22 lines, -19 lines 0 comments Download
M tests/parsers/asl.py View 4 chunks +28 lines, -26 lines 0 comments Download
M tests/parsers/bash_history.py View 3 chunks +13 lines, -10 lines 0 comments Download
M tests/parsers/bencode_parser.py View 2 chunks +3 lines, -1 line 0 comments Download
M tests/parsers/bsm.py View 5 chunks +192 lines, -189 lines 0 comments Download
M tests/parsers/chrome_cache.py View 3 chunks +8 lines, -6 lines 0 comments Download
M tests/parsers/chrome_preferences.py View 3 chunks +37 lines, -34 lines 0 comments Download
M tests/parsers/cups_ipp.py View 4 chunks +23 lines, -21 lines 0 comments Download
M tests/parsers/custom_destinations.py View 7 chunks +35 lines, -33 lines 0 comments Download
M tests/parsers/docker.py View 6 chunks +46 lines, -44 lines 0 comments Download
M tests/parsers/dpkg.py View 4 chunks +15 lines, -12 lines 0 comments Download
M tests/parsers/esedb.py View 3 chunks +5 lines, -3 lines 0 comments Download
M tests/parsers/filestat.py View 9 chunks +42 lines, -40 lines 0 comments Download
M tests/parsers/firefox_cache.py View 11 chunks +59 lines, -57 lines 0 comments Download
M tests/parsers/iis.py View 4 chunks +30 lines, -28 lines 0 comments Download
M tests/parsers/interface.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/parsers/java_idx.py View 6 chunks +18 lines, -16 lines 0 comments Download
M tests/parsers/mac_appfirewall.py View 4 chunks +34 lines, -32 lines 0 comments Download
M tests/parsers/mac_keychain.py View 4 chunks +31 lines, -29 lines 0 comments Download
M tests/parsers/mac_securityd.py View 3 chunks +56 lines, -54 lines 0 comments Download
M tests/parsers/mac_wifi.py View 4 chunks +49 lines, -47 lines 0 comments Download
M tests/parsers/mactime.py View 5 chunks +10 lines, -8 lines 0 comments Download
M tests/parsers/mcafeeav.py View 4 chunks +18 lines, -16 lines 0 comments Download
M tests/parsers/mediator.py View 5 chunks +15 lines, -13 lines 0 comments Download
M tests/parsers/msiecf.py View 7 chunks +48 lines, -46 lines 0 comments Download
M tests/parsers/ntfs.py View 10 chunks +41 lines, -39 lines 0 comments Download
M tests/parsers/olecf.py View 4 chunks +7 lines, -5 lines 0 comments Download
M tests/parsers/opera.py View 5 chunks +23 lines, -21 lines 0 comments Download
M tests/parsers/oxml.py View 3 chunks +39 lines, -37 lines 0 comments Download
M tests/parsers/pcap.py View 4 chunks +30 lines, -28 lines 0 comments Download
M tests/parsers/pe.py View 4 chunks +16 lines, -14 lines 0 comments Download
M tests/parsers/plist.py View 3 chunks +14 lines, -12 lines 0 comments Download
M tests/parsers/pls_recall.py View 3 chunks +14 lines, -12 lines 0 comments Download
M tests/parsers/popcontest.py View 14 chunks +42 lines, -40 lines 0 comments Download
M tests/parsers/recycler.py View 6 chunks +24 lines, -22 lines 0 comments Download
M tests/parsers/safari_cookies.py View 3 chunks +19 lines, -17 lines 0 comments Download
M tests/parsers/sccm.py View 3 chunks +13 lines, -11 lines 0 comments Download
M tests/parsers/selinux.py View 6 chunks +20 lines, -18 lines 0 comments Download
M tests/parsers/skydrivelog.py View 8 chunks +62 lines, -60 lines 0 comments Download
M tests/parsers/symantec.py View 3 chunks +25 lines, -23 lines 0 comments Download
M tests/parsers/syslog.py View 4 chunks +39 lines, -37 lines 0 comments Download
M tests/parsers/systemd_journal.py View 6 chunks +19 lines, -17 lines 0 comments Download
M tests/parsers/test_lib.py View 5 chunks +7 lines, -5 lines 0 comments Download
M tests/parsers/text_parser.py View 2 chunks +23 lines, -21 lines 0 comments Download
M tests/parsers/utmp.py View 3 chunks +53 lines, -51 lines 0 comments Download
M tests/parsers/utmpx.py View 3 chunks +26 lines, -24 lines 0 comments Download
M tests/parsers/winevt.py View 4 chunks +27 lines, -25 lines 0 comments Download
M tests/parsers/winevtx.py View 5 chunks +64 lines, -62 lines 0 comments Download
M tests/parsers/winjob.py View 3 chunks +19 lines, -17 lines 0 comments Download
M tests/parsers/winlnk.py View 8 chunks +56 lines, -54 lines 0 comments Download
M tests/parsers/winprefetch.py View 7 chunks +217 lines, -215 lines 0 comments Download
M tests/parsers/winreg.py View 4 chunks +18 lines, -16 lines 0 comments Download
M tests/parsers/winrestore.py View 3 chunks +10 lines, -8 lines 0 comments Download
M tests/parsers/xchatlog.py View 3 chunks +17 lines, -15 lines 0 comments Download
M tests/parsers/xchatscrollback.py View 3 chunks +22 lines, -19 lines 0 comments Download
M tests/parsers/zsh_extended_history.py View 4 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 4
Joachim Metz
6 years, 6 months ago (2017-10-15 12:32:02 UTC) #1
Joachim Metz
Code updated.
6 years, 6 months ago (2017-10-15 13:17:21 UTC) #2
aaronp
LGTM
6 years, 6 months ago (2017-10-20 04:17:20 UTC) #3
Joachim Metz
6 years, 6 months ago (2017-10-20 04:34:25 UTC) #4
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close unicode15
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b