[plaso] Fix MacOS install script

[plaso] Fix MacOS install script

[onager, 2017-09-27 11:00:10]

Code updated.

[Joachim Metz, 2017-09-27 16:13:40]

LGTM

[aaronp, 2017-09-27 16:45:34]

There is some interesting bash style in this script, but I guess it's
consistent, :).   Just one consistency nit comment, but LGTM.

https://codereview.appspot.com/331750043/diff/20001/config/macos/install.sh
File config/macos/install.sh (right):

https://codereview.appspot.com/331750043/diff/20001/config/macos/install.sh#n...
config/macos/install.sh:74: for PACKAGE in `find ${VOLUME_NAME} -name
"${PACKAGE_NAME}-*.pkg"`;
It looks like for the other script you switched to using $(cmd) syntax, but here
you're using `cmd` syntax.  Maybe switch this one too since you're changing the
code here?

[Joachim Metz, 2017-09-27 18:57:54]

Some of the style might be related to portability

On Sep 27, 2017 18:45, <aaronp@gmail.com> wrote:

> There is some interesting bash style in this script, but I guess it's
> consistent, :).   Just one consistency nit comment, but LGTM.
>
>
> https://codereview.appspot.com/331750043/diff/20001/config/
> macos/install.sh
> File config/macos/install.sh (right):
>
> https://codereview.appspot.com/331750043/diff/20001/config/
> macos/install.sh#newcode74
> config/macos/install.sh:74: for PACKAGE in `find ${VOLUME_NAME} -name
> "${PACKAGE_NAME}-*.pkg"`;
> It looks like for the other script you switched to using $(cmd) syntax,
> but here you're using `cmd` syntax.  Maybe switch this one too since
> you're changing the code here?
>
> https://codereview.appspot.com/331750043/
>

[onager, 2017-09-30 13:03:38]

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close fix_build