Issue 331630043: [plaso] Refactored timestamp checks in tests #1701

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 331630043: [plaso] Refactored timestamp checks in tests #1701 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 2 months ago by Joachim Metz

Modified:
6 years, 1 month ago

Reviewers:
aaronp, onager

CC:
jberggren, romaing, kiddi, log2timeline-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

[plaso] Refactored timestamp checks in tests #1701

Patch Set 1 : Changes after merge #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+119 lines, -287 lines)			Patch
M	tests/parsers/pls_recall.py	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	tests/parsers/popcontest.py	View	13 chunks	+17 lines, -35 lines	0 comments	Download
M	tests/parsers/recycler.py	View	4 chunks	+6 lines, -14 lines	0 comments	Download
M	tests/parsers/safari_cookies.py	View	2 chunks	+3 lines, -6 lines	0 comments	Download
M	tests/parsers/sccm.py	View	2 chunks	+8 lines, -13 lines	0 comments	Download
M	tests/parsers/selinux.py	View	5 chunks	+4 lines, -13 lines	0 comments	Download
M	tests/parsers/skydrivelog.py	View	10 chunks	+22 lines, -39 lines	0 comments	Download
M	tests/parsers/sophos_av.py	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	tests/parsers/sqlite_plugins/android_calls.py	View	3 chunks	+8 lines, -22 lines	0 comments	Download
M	tests/parsers/sqlite_plugins/android_sms.py	View	3 chunks	+4 lines, -12 lines	0 comments	Download
M	tests/parsers/sqlite_plugins/android_webview.py	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	tests/parsers/sqlite_plugins/android_webviewcache.py	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	tests/parsers/sqlite_plugins/appusage.py	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	tests/parsers/sqlite_plugins/chrome.py	View	9 chunks	+8 lines, -33 lines	0 comments	Download
M	tests/parsers/sqlite_plugins/chrome_cookies.py	View	4 chunks	+12 lines, -18 lines	0 comments	Download
M	tests/parsers/sqlite_plugins/chrome_extension_activity.py	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	tests/parsers/sqlite_plugins/firefox.py	View	7 chunks	+9 lines, -35 lines	0 comments	Download
M	tests/parsers/sqlite_plugins/firefox_cookies.py	View	3 chunks	+5 lines, -9 lines	0 comments	Download
M	tests/parsers/sqlite_plugins/gdrive.py	View	4 chunks	+4 lines, -9 lines	0 comments	Download
M	tests/parsers/sqlite_plugins/imessage.py	View	2 chunks	+1 line, -5 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Joachim Metz

6 years, 2 months ago (2018-02-21 15:38:46 UTC) #4

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close testing4

Expand All Messages | Collapse All Messages