Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1060)

Issue 331400043: [plaso] Added CompressedFileHandler for logging #1549 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 months, 2 weeks ago by Joachim Metz
Modified:
7 months, 3 weeks ago
Reviewers:
onager
CC:
jberggren, romaing, kiddi, log2timeline-dev_googlegroups.com, aaronp
Visibility:
Public.

Description

[plaso] Added CompressedFileHandler for logging #1549

Patch Set 1 #

Patch Set 2 : Changes for multi process logging #

Patch Set 3 : Worked on tests #

Total comments: 8

Patch Set 4 : Changes after review and merge #

Total comments: 2

Patch Set 5 : Changes after review and merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -113 lines) Patch
M plaso/cli/extraction_tool.py View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M plaso/cli/image_export_tool.py View 1 2 4 chunks +6 lines, -16 lines 0 comments Download
M plaso/cli/log2timeline_tool.py View 1 2 3 4 chunks +11 lines, -21 lines 0 comments Download
M plaso/cli/pinfo_tool.py View 1 2 4 chunks +6 lines, -10 lines 0 comments Download
M plaso/cli/psort_tool.py View 1 2 3 4 chunks +6 lines, -17 lines 0 comments Download
M plaso/cli/psteal_tool.py View 1 2 3 4 3 chunks +7 lines, -0 lines 0 comments Download
M plaso/cli/tools.py View 1 2 1 chunk +0 lines, -32 lines 0 comments Download
M plaso/engine/configurations.py View 1 2 chunks +2 lines, -0 lines 0 comments Download
A plaso/lib/loggers.py View 1 2 3 4 1 chunk +89 lines, -0 lines 0 comments Download
M plaso/multi_processing/base_process.py View 1 2 4 chunks +13 lines, -0 lines 0 comments Download
M plaso/multi_processing/engine.py View 1 2 3 chunks +20 lines, -17 lines 0 comments Download
M plaso/multi_processing/task_engine.py View 1 2 3 3 chunks +13 lines, -0 lines 0 comments Download
M plaso/multi_processing/worker_process.py View 1 1 chunk +7 lines, -0 lines 0 comments Download
A tests/lib/loggers.py View 1 2 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 15
Joachim Metz
8 months, 2 weeks ago (2017-12-06 06:49:15 UTC) #1
Joachim Metz
For reviewer this CL needs some unit testing, but putting it out there for discussion ...
8 months, 2 weeks ago (2017-12-06 06:50:51 UTC) #2
Joachim Metz
Code updated.
8 months, 1 week ago (2017-12-09 10:43:05 UTC) #3
Joachim Metz
For reviewer solved the "log garbling" issue, but I still need to write a unit ...
8 months, 1 week ago (2017-12-09 12:02:55 UTC) #4
Joachim Metz
Code updated.
8 months, 1 week ago (2017-12-10 08:26:52 UTC) #5
Joachim Metz
PTAL
8 months, 1 week ago (2017-12-10 08:34:08 UTC) #6
onager
https://codereview.appspot.com/331400043/diff/40001/plaso/lib/loggers.py File plaso/lib/loggers.py (right): https://codereview.appspot.com/331400043/diff/40001/plaso/lib/loggers.py#newcode25 plaso/lib/loggers.py:25: """Opens the current base file with the (original) mode ...
7 months, 3 weeks ago (2017-12-27 20:24:58 UTC) #7
onager
7 months, 3 weeks ago (2017-12-27 20:58:54 UTC) #8
Joachim Metz
Code updated.
7 months, 3 weeks ago (2017-12-28 05:39:59 UTC) #9
Joachim Metz
https://codereview.appspot.com/331400043/diff/40001/plaso/lib/loggers.py File plaso/lib/loggers.py (right): https://codereview.appspot.com/331400043/diff/40001/plaso/lib/loggers.py#newcode25 plaso/lib/loggers.py:25: """Opens the current base file with the (original) mode ...
7 months, 3 weeks ago (2017-12-28 05:41:17 UTC) #10
onager
https://codereview.appspot.com/331400043/diff/60001/plaso/lib/loggers.py File plaso/lib/loggers.py (right): https://codereview.appspot.com/331400043/diff/60001/plaso/lib/loggers.py#newcode25 plaso/lib/loggers.py:25: """Opens the current compressed log file. Is "current" still ...
7 months, 3 weeks ago (2017-12-28 09:03:19 UTC) #11
Joachim Metz
https://codereview.appspot.com/331400043/diff/60001/plaso/lib/loggers.py File plaso/lib/loggers.py (right): https://codereview.appspot.com/331400043/diff/60001/plaso/lib/loggers.py#newcode25 plaso/lib/loggers.py:25: """Opens the current compressed log file. On 2017/12/28 09:03:19, ...
7 months, 3 weeks ago (2017-12-28 09:13:09 UTC) #12
Joachim Metz
Code updated.
7 months, 3 weeks ago (2017-12-28 09:17:56 UTC) #13
onager
LGTM
7 months, 3 weeks ago (2017-12-28 10:28:35 UTC) #14
Joachim Metz
7 months, 3 weeks ago (2017-12-28 11:07:07 UTC) #15
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close loggers
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b