Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1151)

Issue 331310043: OmnipotentSnitch: make us the first replica. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 2 days ago by seregibenjamin
Modified:
42 minutes ago
Reviewers:
tonythomas
CC:
dkostic, kirill.sc, seregibenjamin, david.tomic11, cynthiamao122_gmail.com, liangzijie1437_gmail.com
Visibility:
Public.

Description

OmnipotentSnitch: make us the first replica. BUG=

Patch Set 1 #

Total comments: 1

Patch Set 2 : FairGameSnitch: added some logging. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M src/java/org/apache/cassandra/locator/FairGameSnitch.java View 1 4 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 7
seregibenjamin
1 week, 2 days ago (2017-11-12 15:33:18 UTC) #1
tonythomas
https://codereview.appspot.com/331310043/diff/1/src/java/org/apache/cassandra/locator/OmnipotentSnitch.java File src/java/org/apache/cassandra/locator/OmnipotentSnitch.java (right): https://codereview.appspot.com/331310043/diff/1/src/java/org/apache/cassandra/locator/OmnipotentSnitch.java#newcode194 src/java/org/apache/cassandra/locator/OmnipotentSnitch.java:194: addresses.add(0, address); can we use list.set ? https://docs.oracle.com/javase/6/docs/api/java/util/ArrayList.html#set%28int,%20E%29?
1 week, 2 days ago (2017-11-12 16:23:56 UTC) #2
seregibenjamin
Oh, nice. I didn't see that function. On 12 November 2017 at 17:23, <01tonythomas@gmail.com> wrote: ...
1 week, 2 days ago (2017-11-12 18:06:10 UTC) #3
seregibenjamin
Well, I need to keep the original order for the rest of the list. How ...
1 week, 2 days ago (2017-11-12 18:12:57 UTC) #4
tonythomas
Okey. Seems like you have to get the index of address, and then replace. Ugly ...
1 week, 2 days ago (2017-11-12 18:32:02 UTC) #5
seregibenjamin
I don't know the underlying list data structure but if it is a doubly linked ...
1 week, 2 days ago (2017-11-12 18:35:42 UTC) #6
seregibenjamin
1 hour ago (2017-11-22 11:48:02 UTC) #7

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4