Issue 331300043: Fix code after ziljies changes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 5 months ago by tonythomas

Modified:
6 years, 5 months ago

Reviewers:

CC:
dkostic, kirill.sc, seregibenjamin, david.tomic11, tonythomas, cynthiamao122_gmail.com, liangzijie1437_gmail.com

Visibility:
Public.

Fix code after ziljies changes Major cleanup after ziljies patch BUG=REP-

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+130 lines, -205 lines)			Patch
M	api.py	View		2 chunks	+1 line, -15 lines	0 comments	Download
M	launch_lx3.py	View	1 2 3 4	5 chunks	+22 lines, -28 lines	0 comments	Download
M	utils/cassandra_notifier.py	View		2 chunks	+10 lines, -5 lines	0 comments	Download
D	utils/draw_latency_plot.py	View	1	1 chunk	+0 lines, -55 lines	0 comments	Download
D	utils/draw_time_vs_scores.py	View	1	1 chunk	+0 lines, -45 lines	0 comments	Download
A	utils/ds_score_plots/__init__.py	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	utils/ds_score_plots/fetch_score_and_write_to_csv.py	View	1 2 3 4	1 chunk	+57 lines, -0 lines	0 comments	Download
A	utils/ds_score_plots/plot_time_vs_score.py	View	1 2 3 4	1 chunk	+41 lines, -0 lines	0 comments	Download
M	utils/get_data_from_log_case.py	View	1	1 chunk	+0 lines, -58 lines	0 comments	Download

Total messages: 2

tonythomas

Ziljie will possibly push more on top of master once this get merged

6 years, 5 months ago (2017-11-12 11:53:28 UTC) #1

Merging now (verified with team)