Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(981)

Issue 330710043: src: Fix GVariant leaks (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 5 months ago by fujiwara
Modified:
6 years, 5 months ago
Reviewers:
shawn.p.huang, Peng
CC:
carlosg_gnome.org
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

src: Fix GVariant leaks g_task_propagate_pointer() gives ownership of the data to the caller, so the GVariants handed this way must be unref'ed after the contents have been extracted/copied. BUG=https://github.com/ibus/ibus/pull/1956 Committed: 1cbe86726d99b79201cf3735610524e9a49aa08b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M src/ibusbus.c View 7 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3
fujiwara
6 years, 5 months ago (2017-10-30 08:34:04 UTC) #1
Peng
Lgtm
6 years, 5 months ago (2017-10-30 10:24:35 UTC) #2
fujiwara
6 years, 5 months ago (2017-10-31 04:17:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1cbe86726d99b79201cf3735610524e9a49aa08b (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b