Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2361)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 330570043: [plaso] Made Unicode strings the default in bencode, cookie, ESEDB, OLECF, plist and syslog parser … (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 6 months ago by Joachim Metz
Modified:
6 years, 6 months ago
Reviewers:
aaronp
CC:
jberggren, romaing, onager, kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[plaso] Made Unicode strings the default in bencode, cookie, ESEDB, OLECF, plist and syslog parser …

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+447 lines, -382 lines) Patch
M tests/parsers/bencode_plugins/test_lib.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/parsers/bencode_plugins/transmission.py View 5 chunks +8 lines, -6 lines 0 comments Download
M tests/parsers/bencode_plugins/utorrent.py View 7 chunks +12 lines, -9 lines 0 comments Download
M tests/parsers/cookie_plugins/ganalytics.py View 5 chunks +40 lines, -38 lines 0 comments Download
M tests/parsers/cookie_plugins/manager.py View 2 chunks +4 lines, -2 lines 0 comments Download
M tests/parsers/cookie_plugins/test_lib.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/parsers/esedb_plugins/file_history.py View 3 chunks +13 lines, -11 lines 0 comments Download
M tests/parsers/esedb_plugins/msie_webcache.py View 3 chunks +14 lines, -12 lines 0 comments Download
M tests/parsers/esedb_plugins/test_lib.py View 2 chunks +8 lines, -7 lines 0 comments Download
M tests/parsers/olecf_plugins/automatic_destinations.py View 6 chunks +53 lines, -51 lines 0 comments Download
M tests/parsers/olecf_plugins/default.py View 3 chunks +9 lines, -7 lines 0 comments Download
M tests/parsers/olecf_plugins/summary.py View 5 chunks +38 lines, -36 lines 0 comments Download
M tests/parsers/olecf_plugins/test_lib.py View 2 chunks +12 lines, -8 lines 0 comments Download
M tests/parsers/plist_plugins/airport.py View 3 chunks +10 lines, -8 lines 0 comments Download
M tests/parsers/plist_plugins/appleaccount.py View 3 chunks +15 lines, -13 lines 0 comments Download
M tests/parsers/plist_plugins/bluetooth.py View 4 chunks +13 lines, -10 lines 2 comments Download
M tests/parsers/plist_plugins/default.py View 4 chunks +29 lines, -27 lines 0 comments Download
M tests/parsers/plist_plugins/install_history.py View 3 chunks +18 lines, -16 lines 0 comments Download
M tests/parsers/plist_plugins/interface.py View 7 chunks +28 lines, -25 lines 0 comments Download
M tests/parsers/plist_plugins/ipod.py View 3 chunks +17 lines, -15 lines 0 comments Download
M tests/parsers/plist_plugins/macuser.py View 3 chunks +17 lines, -15 lines 0 comments Download
M tests/parsers/plist_plugins/safari.py View 3 chunks +8 lines, -6 lines 0 comments Download
M tests/parsers/plist_plugins/softwareupdate.py View 3 chunks +12 lines, -10 lines 0 comments Download
M tests/parsers/plist_plugins/spotlight.py View 3 chunks +10 lines, -8 lines 0 comments Download
M tests/parsers/plist_plugins/spotlight_volume.py View 3 chunks +10 lines, -8 lines 0 comments Download
M tests/parsers/plist_plugins/test_lib.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/parsers/plist_plugins/timemachine.py View 3 chunks +10 lines, -8 lines 0 comments Download
M tests/parsers/syslog_plugins/cron.py View 3 chunks +10 lines, -8 lines 0 comments Download
M tests/parsers/syslog_plugins/ssh.py View 3 chunks +21 lines, -18 lines 0 comments Download
M tests/parsers/syslog_plugins/test_lib.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Joachim Metz
6 years, 6 months ago (2017-10-15 13:00:15 UTC) #1
aaronp
LGTM https://codereview.appspot.com/330570043/diff/1/tests/parsers/plist_plugins/bluetooth.py File tests/parsers/plist_plugins/bluetooth.py (right): https://codereview.appspot.com/330570043/diff/1/tests/parsers/plist_plugins/bluetooth.py#newcode63 tests/parsers/plist_plugins/bluetooth.py:63: event = events[10] How did this even work ...
6 years, 6 months ago (2017-10-20 04:11:01 UTC) #2
Joachim Metz
https://codereview.appspot.com/330570043/diff/1/tests/parsers/plist_plugins/bluetooth.py File tests/parsers/plist_plugins/bluetooth.py (right): https://codereview.appspot.com/330570043/diff/1/tests/parsers/plist_plugins/bluetooth.py#newcode63 tests/parsers/plist_plugins/bluetooth.py:63: event = events[10] On 2017/10/20 04:11:01, aaronp wrote: > ...
6 years, 6 months ago (2017-10-20 04:31:44 UTC) #3
Joachim Metz
6 years, 6 months ago (2017-10-20 04:41:51 UTC) #4 
merged
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b