Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(587)

Issue 330540043: [plaso] Fix for output option parsing. Fixes #1437 #1433 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months ago by onager
Modified:
1 month, 3 weeks ago
Reviewers:
Joachim Metz, aaronp
CC:
jberggren, romaing, kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[plaso] Fix for output option parsing. Fixes #1437 #1433

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -23 lines) Patch
M plaso/cli/psort_tool.py View 3 chunks +14 lines, -16 lines 0 comments Download
M plaso/cli/psteal_tool.py View 4 chunks +30 lines, -7 lines 4 comments Download
M plaso/cli/tool_options.py View 2 chunks +11 lines, -0 lines 0 comments Download
M tools/psteal.py View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 5
onager
2 months ago (2017-10-11 21:57:43 UTC) #1
aaronp
LGTM
1 month, 3 weeks ago (2017-10-15 05:32:53 UTC) #2
Joachim Metz
a couple of small things to consider before merge https://codereview.appspot.com/330540043/diff/1/plaso/cli/psteal_tool.py File plaso/cli/psteal_tool.py (right): https://codereview.appspot.com/330540043/diff/1/plaso/cli/psteal_tool.py#newcode502 plaso/cli/psteal_tool.py:502: ...
1 month, 3 weeks ago (2017-10-15 05:58:07 UTC) #3
onager
https://codereview.appspot.com/330540043/diff/1/plaso/cli/psteal_tool.py File plaso/cli/psteal_tool.py (right): https://codereview.appspot.com/330540043/diff/1/plaso/cli/psteal_tool.py#newcode502 plaso/cli/psteal_tool.py:502: if self._preferred_language == 'list': On 2017/10/15 05:58:07, Joachim Metz ...
1 month, 3 weeks ago (2017-10-17 13:59:36 UTC) #4
onager
1 month, 3 weeks ago (2017-10-17 14:58:38 UTC) #5
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close fix_args
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 204d58d