Issue 330540043: [plaso] Fix for output option parsing. Fixes #1437 #1433

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 330540043: [plaso] Fix for output option parsing. Fixes #1437 #1433 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 6 months ago by onager

Modified:
6 years, 6 months ago

Reviewers:
Joachim Metz, aaronp

CC:
jberggren, romaing, kiddi, log2timeline-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

[plaso] Fix for output option parsing. Fixes #1437 #1433

Patch Set 1 #

Total comments: 4

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+71 lines, -23 lines)			Patch
M	plaso/cli/psort_tool.py	View	3 chunks	+14 lines, -16 lines	0 comments	Download
M	plaso/cli/psteal_tool.py	View	4 chunks	+30 lines, -7 lines	4 comments	Download
M	plaso/cli/tool_options.py	View	2 chunks	+11 lines, -0 lines	0 comments	Download
M	tools/psteal.py	View	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Joachim Metz

a couple of small things to consider before merge https://codereview.appspot.com/330540043/diff/1/plaso/cli/psteal_tool.py File plaso/cli/psteal_tool.py (right): https://codereview.appspot.com/330540043/diff/1/plaso/cli/psteal_tool.py#newcode502 plaso/cli/psteal_tool.py:502: ...

6 years, 6 months ago (2017-10-15 05:58:07 UTC) #3

onager

https://codereview.appspot.com/330540043/diff/1/plaso/cli/psteal_tool.py File plaso/cli/psteal_tool.py (right): https://codereview.appspot.com/330540043/diff/1/plaso/cli/psteal_tool.py#newcode502 plaso/cli/psteal_tool.py:502: if self._preferred_language == 'list': On 2017/10/15 05:58:07, Joachim Metz ...

6 years, 6 months ago (2017-10-17 13:59:36 UTC) #4

onager

6 years, 6 months ago (2017-10-17 14:58:38 UTC) #5

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close fix_args

Expand All Messages | Collapse All Messages