Merge commit 'e6579bfded4a3ed5ea6aeff6b885eff3b47a3dc7' into rawoptimizedfixes2

Merge commit 'e6579bfded4a3ed5ea6aeff6b885eff3b47a3dc7' into rawoptimizedfixes2


Updating visualization script to produce cross-correlation plots


Merge branch 'kurma' of bitbucket.org:nslab/nc_ycsb into kurma


Removing the point class thingy


Other fixes


yet another fix


fixes


Changes to data writer


Adding fix


Streamlinging+Fixing binary to text conversion


Adding some additional comments


Commenting out debug lines


Fix


Fixing indentation issues


Adding support for READS/UPDATES/WRITES + improving clarity

BUG=

[kirill.sc, 2017-09-16 12:00:10]

https://codereview.appspot.com/330230043/diff/1/core/src/main/java/com/yahoo/...
File
core/src/main/java/com/yahoo/ycsb/measurements/OneMeasurementRawOptimized.java
(left):

https://codereview.appspot.com/330230043/diff/1/core/src/main/java/com/yahoo/...
core/src/main/java/com/yahoo/ycsb/measurements/OneMeasurementRawOptimized.java:161:
if (!allThreadsCheckedIn || !outputStreams.containsKey(threadId)) {
Why do we have to have containsKey check here and then use get() a few lines
later? 
First, you can just use get() and check if you got null. That will be only one
lookup. 

However, the best solution is to create stream at the constructor of the class
for the given thread ID. So you don't have to check anything here.

https://codereview.appspot.com/330230043/diff/1/core/src/main/java/com/yahoo/...
core/src/main/java/com/yahoo/ycsb/measurements/OneMeasurementRawOptimized.java:168:
if(outputStreams.keySet().size() == measurementsThreadCount)
There is a bug here. the outputStreams.keySet().size() equals to the number of
threads passed to YCSB as parameter. Which is a different number from
measurementsThreadCount. 

If the first number is lower than then measurementsThreadCount, then YCSB keep
on openning files until it reaches system limit and crashes.

https://codereview.appspot.com/330230043/diff/1/core/src/main/java/com/yahoo/...
File
core/src/main/java/com/yahoo/ycsb/measurements/OneMeasurementRawOptimized.java
(right):

https://codereview.appspot.com/330230043/diff/1/core/src/main/java/com/yahoo/...
core/src/main/java/com/yahoo/ycsb/measurements/OneMeasurementRawOptimized.java:154:
outputStreams.put(threadId, new DataOutputStream(new
BufferedOutputStream(System.out)));
Does this code path even working? What the point of dumping binary into stdout?
I mean how we going to parse it out of there?

https://codereview.appspot.com/330230043/diff/1/core/src/main/java/com/yahoo/...
core/src/main/java/com/yahoo/ycsb/measurements/OneMeasurementRawOptimized.java:239:
System.err.println("Oh noes .. we are getting this exception: " + e);
What does this message means? Is it critical or not?

https://codereview.appspot.com/330230043/diff/1/core/src/main/java/com/yahoo/...
core/src/main/java/com/yahoo/ycsb/measurements/OneMeasurementRawOptimized.java:261:
{
be consistent with your scope brackets. I think most of the files keep it on the
same line with the code

https://codereview.appspot.com/330230043/diff/1/core/src/main/java/com/yahoo/...
core/src/main/java/com/yahoo/ycsb/measurements/OneMeasurementRawOptimized.java:266:
String aLine = String.format("%s,%d,%d", numToOptEncoding.get(byteString[0] &
0xFF),
what is the purpose of 0xFF? why do we need to do it?