Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(525)

Issue 329840043: [dfvfs] Made Unicode strings the default #204 and updated docstrings #182 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by Joachim Metz
Modified:
2 months ago
Reviewers:
onager
CC:
kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[dfvfs] Made Unicode strings the default #204 and updated docstrings #182

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -175 lines) Patch
M dfvfs/resolver/bde_resolver_helper.py View 2 chunks +3 lines, -1 line 0 comments Download
M dfvfs/resolver/cache.py View 12 chunks +31 lines, -31 lines 0 comments Download
M dfvfs/resolver/compressed_stream_resolver_helper.py View 4 chunks +7 lines, -5 lines 0 comments Download
M dfvfs/resolver/context.py View 4 chunks +10 lines, -8 lines 0 comments Download
M dfvfs/resolver/cpio_resolver_helper.py View 4 chunks +7 lines, -5 lines 0 comments Download
M dfvfs/resolver/data_range_resolver_helper.py View 4 chunks +7 lines, -5 lines 0 comments Download
M dfvfs/resolver/encoded_stream_resolver_helper.py View 4 chunks +7 lines, -5 lines 0 comments Download
M dfvfs/resolver/encrypted_stream_resolver_helper.py View 4 chunks +7 lines, -5 lines 0 comments Download
M dfvfs/resolver/ewf_resolver_helper.py View 3 chunks +5 lines, -3 lines 0 comments Download
M dfvfs/resolver/fake_resolver_helper.py View 1 chunk +3 lines, -1 line 0 comments Download
M dfvfs/resolver/fvde_resolver_helper.py View 2 chunks +3 lines, -1 line 0 comments Download
M dfvfs/resolver/gzip_resolver_helper.py View 4 chunks +7 lines, -5 lines 0 comments Download
M dfvfs/resolver/lvm_resolver_helper.py View 4 chunks +7 lines, -5 lines 0 comments Download
M dfvfs/resolver/ntfs_resolver_helper.py View 4 chunks +7 lines, -5 lines 0 comments Download
M dfvfs/resolver/os_resolver_helper.py View 4 chunks +7 lines, -5 lines 0 comments Download
M dfvfs/resolver/qcow_resolver_helper.py View 3 chunks +5 lines, -3 lines 0 comments Download
M dfvfs/resolver/raw_resolver_helper.py View 3 chunks +5 lines, -3 lines 0 comments Download
M dfvfs/resolver/resolver.py View 6 chunks +7 lines, -5 lines 0 comments Download
M dfvfs/resolver/resolver_helper.py View 3 chunks +8 lines, -6 lines 0 comments Download
M dfvfs/resolver/sqlite_blob_resolver_helper.py View 4 chunks +7 lines, -5 lines 0 comments Download
M dfvfs/resolver/tar_resolver_helper.py View 4 chunks +7 lines, -5 lines 0 comments Download
M dfvfs/resolver/tsk_partition_resolver_helper.py View 4 chunks +7 lines, -5 lines 0 comments Download
M dfvfs/resolver/tsk_resolver_helper.py View 4 chunks +7 lines, -5 lines 0 comments Download
M dfvfs/resolver/vhdi_resolver_helper.py View 3 chunks +5 lines, -3 lines 0 comments Download
M dfvfs/resolver/vmdk_resolver_helper.py View 3 chunks +5 lines, -3 lines 0 comments Download
M dfvfs/resolver/vshadow_resolver_helper.py View 4 chunks +7 lines, -5 lines 0 comments Download
M dfvfs/resolver/zip_resolver_helper.py View 4 chunks +8 lines, -6 lines 0 comments Download
M dfvfs/serializer/json_serializer.py View 6 chunks +29 lines, -27 lines 0 comments Download
M dfvfs/serializer/serializer.py View 3 chunks +6 lines, -4 lines 2 comments Download

Messages

Total messages: 4
Joachim Metz
2 months, 1 week ago (2017-07-15 11:17:30 UTC) #1
onager
One typo, LGTM https://codereview.appspot.com/329840043/diff/1/dfvfs/serializer/serializer.py File dfvfs/serializer/serializer.py (right): https://codereview.appspot.com/329840043/diff/1/dfvfs/serializer/serializer.py#newcode22 dfvfs/serializer/serializer.py:22: serialized (object): serialized form of the ...
2 months ago (2017-07-18 14:49:34 UTC) #2
Joachim Metz
https://codereview.appspot.com/329840043/diff/1/dfvfs/serializer/serializer.py File dfvfs/serializer/serializer.py (right): https://codereview.appspot.com/329840043/diff/1/dfvfs/serializer/serializer.py#newcode22 dfvfs/serializer/serializer.py:22: serialized (object): serialized form of the path specificaiton. On ...
2 months ago (2017-07-18 18:39:56 UTC) #3
Joachim Metz
2 months ago (2017-07-18 18:40:53 UTC) #4
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close unicode6
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted