Adds support to the angular webconsole to show tasks by category.

Adds support to the angular webconsole to show tasks by category.

[alanmorales, 2017-10-19 15:21:01]

Please take a look, thanks!

https://screenshot.googleplex.com/p90xvcp2uOY
https://screenshot.googleplex.com/WWSz4LPauHC

[mbassiouny, 2017-10-20 14:53:45]

Thanks Alan. Generally looks good with few minor comments. Can we remove
failures-table.component.css file and add it when it has content.

Thanks,
Mahmoud

https://codereview.appspot.com/329530043/diff/1/webconsole/frontend/src/app/j...
File
webconsole/frontend/src/app/jobs/job-tasks/failures-table/failures-table.component.html
(right):

https://codereview.appspot.com/329530043/diff/1/webconsole/frontend/src/app/j...
webconsole/frontend/src/app/jobs/job-tasks/failures-table/failures-table.component.html:7:
<ng-container *ngIf="tasks != null && tasks.length !== 0">
Can you show a message that describes that there are no failed messages or
something?

https://codereview.appspot.com/329530043/diff/1/webconsole/frontend/src/app/j...
File
webconsole/frontend/src/app/jobs/job-tasks/failures-table/failures-table.component.ts
(right):

https://codereview.appspot.com/329530043/diff/1/webconsole/frontend/src/app/j...
webconsole/frontend/src/app/jobs/job-tasks/failures-table/failures-table.component.ts:32:
displayedColumns = ['taskType', 'creationTime', 'lastModificationTime',
'taskId', 'failureMessage'];
Is that the order in which the failed task is displayed. If so, failure message
and taskId probably more important and should come first before the creation and
last modified time.

https://codereview.appspot.com/329530043/diff/1/webconsole/frontend/src/app/j...
File webconsole/frontend/src/app/jobs/job-tasks/job-tasks.component.ts (right):

https://codereview.appspot.com/329530043/diff/1/webconsole/frontend/src/app/j...
webconsole/frontend/src/app/jobs/job-tasks/job-tasks.component.ts:30: if
(this.numFailureTypesLoaded >= Object.keys(TaskType.Type).length) {
Is that TaskFailureType.Type?

https://codereview.appspot.com/329530043/diff/1/webconsole/frontend/src/app/j...
File webconsole/frontend/src/app/jobs/job-tasks/job-tasks.resources.ts (right):

https://codereview.appspot.com/329530043/diff/1/webconsole/frontend/src/app/j...
webconsole/frontend/src/app/jobs/job-tasks/job-tasks.resources.ts:24:
disconnect() {}
What's disconnect do?

https://codereview.appspot.com/329530043/diff/1/webconsole/frontend/src/app/j...
File webconsole/frontend/src/app/jobs/jobs.resources.ts (right):

https://codereview.appspot.com/329530043/diff/1/webconsole/frontend/src/app/j...
webconsole/frontend/src/app/jobs/jobs.resources.ts:78: export const
FAILURE_TYPE_TO_STRING_MAP = {
Is that means any change in the proto should be reflected here?

https://codereview.appspot.com/329530043/diff/1/webconsole/frontend/src/app/j...
webconsole/frontend/src/app/jobs/jobs.resources.ts:79: 0: 'Uknown failure',
Unknown

[alanmorales, 2017-10-20 20:38:43]

Please take another look, thanks!

https://codereview.appspot.com/329530043/diff/1/webconsole/frontend/src/app/j...
File
webconsole/frontend/src/app/jobs/job-tasks/failures-table/failures-table.component.html
(right):

https://codereview.appspot.com/329530043/diff/1/webconsole/frontend/src/app/j...
webconsole/frontend/src/app/jobs/job-tasks/failures-table/failures-table.component.html:7:
<ng-container *ngIf="tasks != null && tasks.length !== 0">
On 2017/10/20 14:53:45, mbassiouny wrote:
> Can you show a message that describes that there are no failed messages or
> something?

Thanks, I hadn't considered this case. It shouldn't go here because this
component shows it for a specific failure type. Instead, I am making the failure
component fire an event so that the parent knows if no failure type has no
failed tasks. Take a look at the screenshot and unit test.

https://screenshot.googleplex.com/NOqzM16Caxn

https://codereview.appspot.com/329530043/diff/1/webconsole/frontend/src/app/j...
File
webconsole/frontend/src/app/jobs/job-tasks/failures-table/failures-table.component.ts
(right):

https://codereview.appspot.com/329530043/diff/1/webconsole/frontend/src/app/j...
webconsole/frontend/src/app/jobs/job-tasks/failures-table/failures-table.component.ts:32:
displayedColumns = ['taskType', 'creationTime', 'lastModificationTime',
'taskId', 'failureMessage'];
On 2017/10/20 14:53:45, mbassiouny wrote:
> Is that the order in which the failed task is displayed. If so, failure
message
> and taskId probably more important and should come first before the creation
and
> last modified time.

Thank you so much, this is very true. Moved failure message and task id to the
front.

https://codereview.appspot.com/329530043/diff/1/webconsole/frontend/src/app/j...
File webconsole/frontend/src/app/jobs/job-tasks/job-tasks.component.ts (right):

https://codereview.appspot.com/329530043/diff/1/webconsole/frontend/src/app/j...
webconsole/frontend/src/app/jobs/job-tasks/job-tasks.component.ts:30: if
(this.numFailureTypesLoaded >= Object.keys(TaskType.Type).length) {
On 2017/10/20 14:53:45, mbassiouny wrote:
> Is that TaskFailureType.Type?

yes, sorry! thank you so much

https://codereview.appspot.com/329530043/diff/1/webconsole/frontend/src/app/j...
File webconsole/frontend/src/app/jobs/job-tasks/job-tasks.resources.ts (right):

https://codereview.appspot.com/329530043/diff/1/webconsole/frontend/src/app/j...
webconsole/frontend/src/app/jobs/job-tasks/job-tasks.resources.ts:24:
disconnect() {}
On 2017/10/20 14:53:45, mbassiouny wrote:
> What's disconnect do?

From the original source:

"Disconnects a collection viewer (such as a data-table) from this data source.
Can be used to perform any clean-up or tear-down operations when a view is being
destroyed."

It looks like it cleans up when the user navigates away from the page. I
implemented it here because it's part of the class but it doesn't do anything
right now.

https://codereview.appspot.com/329530043/diff/1/webconsole/frontend/src/app/j...
File webconsole/frontend/src/app/jobs/jobs.resources.ts (right):

https://codereview.appspot.com/329530043/diff/1/webconsole/frontend/src/app/j...
webconsole/frontend/src/app/jobs/jobs.resources.ts:78: export const
FAILURE_TYPE_TO_STRING_MAP = {
On 2017/10/20 14:53:45, mbassiouny wrote:
> Is that means any change in the proto should be reflected here?

Yes. Any new fields in the proto would also have to be added here with a
human-readable representation. This will be good for example, when we need to
i18n our app, we can get appropriate string representations for each type. Also
we can change what text the user sees without changing anything else in the
stack.

https://codereview.appspot.com/329530043/diff/1/webconsole/frontend/src/app/j...
webconsole/frontend/src/app/jobs/jobs.resources.ts:79: 0: 'Uknown failure',
On 2017/10/20 14:53:45, mbassiouny wrote:
> Unknown

Thanks!

[thobrla, 2017-10-24 23:35:02]

LGTM

https://codereview.appspot.com/329530043/diff/20001/webconsole/frontend/src/a...
File webconsole/frontend/src/app/jobs/job-tasks/job-tasks.component.spec.ts
(right):

https://codereview.appspot.com/329530043/diff/20001/webconsole/frontend/src/a...
webconsole/frontend/src/app/jobs/job-tasks/job-tasks.component.spec.ts:92:
taskTabs[1].click(); // Change to the "succeeded tasks" tab
Consider indexing with an enum value so that if the position of succeeded tasks
moves, this still works?