Issue 329510043: ui/gtk3: Unref Panel and Indicator when double panels run

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 329510043: ui/gtk3: Unref Panel and Indicator when double panels run (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 6 months ago by fujiwara

Modified:
6 years, 6 months ago

Reviewers:
shawn.p.huang, Peng

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

ui/gtk3: Unref Panel and Indicator when double panels run If unref is not called properly, Panel.finalize() is not called and Gtk.StatusIcon won't be hidden with double panels. Committed: dfe21a2729f13107ef28c4cd075ac81d501384ea

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated with comment #2 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+121 lines, -10 lines)			Patch
M	ui/gtk3/application.vala	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	ui/gtk3/indicator.vala	View		15 chunks	+45 lines, -0 lines	0 comments	Download
M	ui/gtk3/panel.vala	View	1	7 chunks	+67 lines, -10 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Peng

Lgtm with nits https://codereview.appspot.com/329510043/diff/1/ui/gtk3/panel.vala File ui/gtk3/panel.vala (right): https://codereview.appspot.com/329510043/diff/1/ui/gtk3/panel.vala#newcode102 ui/gtk3/panel.vala:102: private bool m_is_kde = false; #if ...

6 years, 6 months ago (2017-10-18 13:26:53 UTC) #2

fujiwara

6 years, 6 months ago (2017-10-19 01:53:40 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
dfe21a2729f13107ef28c4cd075ac81d501384ea (presubmit successful).

Expand All Messages | Collapse All Messages