Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5118)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 329470043: [plaso] Made Unicode strings the default in Windows Registry parser plugins tests #1268 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 6 months ago by Joachim Metz
Modified:
6 years, 6 months ago
Reviewers:
aaronp
CC:
jberggren, romaing, onager, kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[plaso] Made Unicode strings the default in Windows Registry parser plugins tests #1268

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1197 lines, -1139 lines) Patch
M tests/parsers/winreg_plugins/appcompatcache.py View 18 chunks +48 lines, -46 lines 0 comments Download
M tests/parsers/winreg_plugins/bagmru.py View 3 chunks +17 lines, -15 lines 0 comments Download
M tests/parsers/winreg_plugins/ccleaner.py View 3 chunks +28 lines, -26 lines 0 comments Download
M tests/parsers/winreg_plugins/default.py View 4 chunks +19 lines, -17 lines 0 comments Download
M tests/parsers/winreg_plugins/lfu.py View 7 chunks +44 lines, -42 lines 0 comments Download
M tests/parsers/winreg_plugins/mountpoints.py View 3 chunks +12 lines, -10 lines 0 comments Download
M tests/parsers/winreg_plugins/mrulist.py View 9 chunks +37 lines, -35 lines 0 comments Download
M tests/parsers/winreg_plugins/mrulistex.py View 11 chunks +118 lines, -116 lines 2 comments Download
M tests/parsers/winreg_plugins/msie_zones.py View 6 chunks +248 lines, -246 lines 0 comments Download
M tests/parsers/winreg_plugins/network_drives.py View 4 chunks +32 lines, -30 lines 0 comments Download
M tests/parsers/winreg_plugins/networks.py View 4 chunks +53 lines, -51 lines 0 comments Download
M tests/parsers/winreg_plugins/officemru.py View 4 chunks +27 lines, -25 lines 0 comments Download
M tests/parsers/winreg_plugins/outlook.py View 5 chunks +18 lines, -16 lines 0 comments Download
M tests/parsers/winreg_plugins/programscache.py View 4 chunks +54 lines, -52 lines 0 comments Download
M tests/parsers/winreg_plugins/run.py View 6 chunks +37 lines, -35 lines 0 comments Download
M tests/parsers/winreg_plugins/sam_users.py View 4 chunks +25 lines, -23 lines 0 comments Download
M tests/parsers/winreg_plugins/services.py View 8 chunks +43 lines, -41 lines 0 comments Download
M tests/parsers/winreg_plugins/shutdown.py View 3 chunks +11 lines, -9 lines 0 comments Download
M tests/parsers/winreg_plugins/task_scheduler.py View 3 chunks +16 lines, -14 lines 0 comments Download
M tests/parsers/winreg_plugins/terminal_server.py View 7 chunks +27 lines, -25 lines 0 comments Download
M tests/parsers/winreg_plugins/test_lib.py View 3 chunks +4 lines, -2 lines 0 comments Download
M tests/parsers/winreg_plugins/timezone.py View 5 chunks +46 lines, -44 lines 0 comments Download
M tests/parsers/winreg_plugins/typedurls.py View 5 chunks +33 lines, -31 lines 0 comments Download
M tests/parsers/winreg_plugins/usb.py View 3 chunks +16 lines, -14 lines 0 comments Download
M tests/parsers/winreg_plugins/usbstor.py View 3 chunks +21 lines, -19 lines 0 comments Download
M tests/parsers/winreg_plugins/userassist.py View 4 chunks +26 lines, -24 lines 0 comments Download
M tests/parsers/winreg_plugins/windows_version.py View 6 chunks +38 lines, -36 lines 0 comments Download
M tests/parsers/winreg_plugins/winlogon.py View 5 chunks +85 lines, -83 lines 0 comments Download
M tests/parsers/winreg_plugins/winrar.py View 4 chunks +14 lines, -12 lines 0 comments Download

Messages

Total messages: 4
Joachim Metz
6 years, 6 months ago (2017-10-15 12:24:13 UTC) #1
aaronp
LGTM https://codereview.appspot.com/329470043/diff/1/tests/parsers/winreg_plugins/mrulistex.py File tests/parsers/winreg_plugins/mrulistex.py (right): https://codereview.appspot.com/329470043/diff/1/tests/parsers/winreg_plugins/mrulistex.py#newcode289 tests/parsers/winreg_plugins/mrulistex.py:289: '<UNKNOWN: 0x00> ' Any idea why the diff'ing ...
6 years, 6 months ago (2017-10-20 23:37:23 UTC) #2
Joachim Metz
https://codereview.appspot.com/329470043/diff/1/tests/parsers/winreg_plugins/mrulistex.py File tests/parsers/winreg_plugins/mrulistex.py (right): https://codereview.appspot.com/329470043/diff/1/tests/parsers/winreg_plugins/mrulistex.py#newcode289 tests/parsers/winreg_plugins/mrulistex.py:289: '<UNKNOWN: 0x00> ' alas no
6 years, 6 months ago (2017-10-21 03:46:25 UTC) #3
Joachim Metz
6 years, 6 months ago (2017-10-21 03:50:34 UTC) #4 
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close unicode16
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b