Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(644)

Issue 329400043: RPM comupting the RTT of each switch

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months ago by younes.tahri3
Modified:
5 days, 23 hours ago
CC:
sdnik2200ht17_ict.kth.se
Visibility:
Public.

Description

RPM comupting the RTT of each switch BUG=

Patch Set 1 #

Total comments: 3

Patch Set 2 : RPM sending to DB #

Total comments: 12

Patch Set 3 : update RPM #

Total comments: 10

Patch Set 4 : traffic gen and test automation for RPM #

Patch Set 5 : graph generation #

Total comments: 14

Patch Set 6 : Commented RPM code #

Patch Set 7 : admission control test file #

Patch Set 8 : Admission control test file #

Patch Set 9 : update #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -11 lines) Patch
M RPM/RPM.py View 1 2 3 4 5 6 7 8 5 chunks +9 lines, -9 lines 3 comments Download
M topology/Admission_control View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -2 lines 0 comments Download
A topology/iperf_traffic View 1 2 3 4 5 6 7 8 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 29
younes.tahri3
Hey! If you have some time you can review my code for RPM. This code ...
2 months ago (2017-10-07 08:51:29 UTC) #1
younes.tahri3
2 months ago (2017-10-07 08:54:38 UTC) #2
younes.tahri3
2 months ago (2017-10-07 08:57:36 UTC) #3
younes.tahri3
2 months ago (2017-10-07 09:01:28 UTC) #4
younes.tahri3
2 months ago (2017-10-07 09:02:29 UTC) #5
younes.tahri3
2 months ago (2017-10-07 09:03:23 UTC) #6
younes.tahri3
Hey there! Here is an updated version of the RPM! Feel free to review when ...
2 months ago (2017-10-12 20:08:12 UTC) #7
younes.tahri3
To view the full code, just click on context : whole file <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=icon> Virus-free. www.avast.com ...
2 months ago (2017-10-12 20:10:55 UTC) #8
Vasileios Papageorgiou
Hi Yonues! I made a review on your first version of RPM https://codereview.appspot.com/329400043/diff/1/RPM/RPM.py File RPM/RPM.py ...
2 months ago (2017-10-12 20:16:19 UTC) #9
Vasileios Papageorgiou
Hi Younes! I made some comments on your new code for RPM https://codereview.appspot.com/329400043/diff/20001/RPM/RPM.py File RPM/RPM.py ...
2 months ago (2017-10-12 20:27:00 UTC) #10
engr.sikandar.iqbal
I'm looking forward to knowing your opinion regarding my comments. Thanks BR, Sikandar Iqbal https://codereview.appspot.com/329400043/diff/20001/RPM/RPM.py ...
1 month, 3 weeks ago (2017-10-16 22:02:25 UTC) #11
younes.tahri3
https://codereview.appspot.com/329400043/diff/20001/RPM/RPM.py File RPM/RPM.py (right): https://codereview.appspot.com/329400043/diff/20001/RPM/RPM.py#newcode50 RPM/RPM.py:50: def roulette(self,ratio): On 2017/10/12 20:27:00, Vasileios Papageorgiou wrote: > ...
1 month, 3 weeks ago (2017-10-17 08:32:48 UTC) #12
younes.tahri3
Hey there, I forgot to publish my comments. Here are my replies. I hope it's ...
1 month, 3 weeks ago (2017-10-17 08:38:23 UTC) #13
engr.sikandar.iqbal
Thanks! https://codereview.appspot.com/329400043/diff/20001/RPM/RPM.py File RPM/RPM.py (right): https://codereview.appspot.com/329400043/diff/20001/RPM/RPM.py#newcode33 RPM/RPM.py:33: self.only_once[new_switch.id]=1 On 2017/10/17 08:38:22, younes.tahri3 wrote: > On ...
1 month, 3 weeks ago (2017-10-17 13:30:15 UTC) #14
younes.tahri3
Here is an updated code for the RPM, feel free to give comments. Testing the ...
4 weeks ago (2017-11-13 17:18:35 UTC) #15
Vasileios Papageorgiou
Hi Younes, See the comments for RPM implementation. BR, Vasilis Papageorgiou https://codereview.appspot.com/329400043/diff/40001/RPM/RPM.py File RPM/RPM.py (right): ...
4 weeks ago (2017-11-14 13:00:01 UTC) #16
younes.tahri3
https://codereview.appspot.com/329400043/diff/40001/RPM/RPM.py File RPM/RPM.py (right): https://codereview.appspot.com/329400043/diff/40001/RPM/RPM.py#newcode45 RPM/RPM.py:45: self.iterator_302=0 On 2017/11/14 13:00:01, Vasileios Papageorgiou wrote: > why ...
2 weeks, 6 days ago (2017-11-21 21:47:04 UTC) #17
younes.tahri3
Traffic generation : one terminal for each host+ssh+iperf +Test automation for RPM: only one script ...
2 weeks, 6 days ago (2017-11-21 21:48:51 UTC) #18
younes.tahri3
Here you'll find the code I use to generate the graphs that are on the ...
1 week, 6 days ago (2017-11-29 01:44:55 UTC) #19
Vasileios Papageorgiou
Hi Younes, Check my comments for RPM.py new file. BR, Vasileios Papageorgiou https://codereview.appspot.com/329400043/diff/80001/RPM/RPM.py File RPM/RPM.py ...
1 week, 6 days ago (2017-11-29 13:49:20 UTC) #20
2016shana2333
Hi, here is a code review for RPM https://codereview.appspot.com/329400043/diff/80001/RPM/test.py File RPM/test.py (right): https://codereview.appspot.com/329400043/diff/80001/RPM/test.py#newcode22 RPM/test.py:22: self.nbOfRules=0 ...
1 week, 6 days ago (2017-11-29 13:58:55 UTC) #21
younes.tahri3
https://codereview.appspot.com/329400043/diff/80001/RPM/test.py File RPM/test.py (right): https://codereview.appspot.com/329400043/diff/80001/RPM/test.py#newcode22 RPM/test.py:22: self.nbOfRules=0 On 2017/11/29 13:58:55, 2016shana2333 wrote: > What is ...
1 week, 2 days ago (2017-12-02 18:31:29 UTC) #22
younes.tahri3
https://codereview.appspot.com/329400043/diff/80001/RPM/RPM.py File RPM/RPM.py (right): https://codereview.appspot.com/329400043/diff/80001/RPM/RPM.py#newcode113 RPM/RPM.py:113: def addRTT302_flows(self): #Computes avg RTT for s302 and s314 ...
1 week, 2 days ago (2017-12-02 18:42:11 UTC) #23
younes.tahri3
Hello! You'll find here a commented version of the RPM code. To try the code, ...
1 week, 2 days ago (2017-12-02 20:06:49 UTC) #24
younes.tahri3
Admission control test file, with updated port numbers(10001,10002,10003)
6 days, 18 hours ago (2017-12-05 20:45:27 UTC) #25
younes.tahri3
6 days, 17 hours ago (2017-12-05 22:09:37 UTC) #26
Vasileios Papageorgiou
Hi Younes, Check the comments for RPM. BR, Vasilis https://codereview.appspot.com/329400043/diff/160001/RPM/RPM.py File RPM/RPM.py (right): https://codereview.appspot.com/329400043/diff/160001/RPM/RPM.py#newcode1 RPM/RPM.py:1: ...
6 days ago (2017-12-06 15:24:25 UTC) #27
Vasileios Papageorgiou
Hi, It seems a good script similar to what other automated test of Michael do. ...
6 days ago (2017-12-06 15:25:55 UTC) #28
younes.tahri3
5 days, 23 hours ago (2017-12-06 16:00:42 UTC) #29
https://codereview.appspot.com/329400043/diff/160001/RPM/RPM.py
File RPM/RPM.py (right):

https://codereview.appspot.com/329400043/diff/160001/RPM/RPM.py#newcode113
RPM/RPM.py:113: def addRTT302_flows(self): 	#Computes avg RTT for s302 and s314
each time we add flows(here, 1 iperf flow added each 30s)
On 2017/12/06 15:24:25, Vasileios Papageorgiou wrote:
> What do you mean by  1 iperf flow added each 30s? Does it have to with the
> topology/iperf_traffic test or with the  topology/Admission_control test?

I use iperf_traffic file for this one. And in this file, you see that there is a
sleep(30s) between each new iperf flow
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 204d58d