Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(237)

Issue 329400043: RPM comupting the RTT of each switch

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks ago by younes.tahri3
Modified:
4 days, 15 hours ago
CC:
sdnik2200ht17_ict.kth.se
Visibility:
Public.

Description

RPM comupting the RTT of each switch BUG=

Patch Set 1 #

Total comments: 3

Patch Set 2 : RPM sending to DB #

Total comments: 12
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M RPM/RPM.py View 1 1 chunk +1 line, -0 lines 12 comments Download

Messages

Total messages: 14
younes.tahri3
Hey! If you have some time you can review my code for RPM. This code ...
2 weeks ago (2017-10-07 08:51:29 UTC) #1
younes.tahri3
2 weeks ago (2017-10-07 08:54:38 UTC) #2
younes.tahri3
2 weeks ago (2017-10-07 08:57:36 UTC) #3
younes.tahri3
2 weeks ago (2017-10-07 09:01:28 UTC) #4
younes.tahri3
2 weeks ago (2017-10-07 09:02:29 UTC) #5
younes.tahri3
2 weeks ago (2017-10-07 09:03:23 UTC) #6
younes.tahri3
Hey there! Here is an updated version of the RPM! Feel free to review when ...
1 week, 2 days ago (2017-10-12 20:08:12 UTC) #7
younes.tahri3
To view the full code, just click on context : whole file <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=icon> Virus-free. www.avast.com ...
1 week, 2 days ago (2017-10-12 20:10:55 UTC) #8
Vasileios Papageorgiou
Hi Yonues! I made a review on your first version of RPM https://codereview.appspot.com/329400043/diff/1/RPM/RPM.py File RPM/RPM.py ...
1 week, 2 days ago (2017-10-12 20:16:19 UTC) #9
Vasileios Papageorgiou
Hi Younes! I made some comments on your new code for RPM https://codereview.appspot.com/329400043/diff/20001/RPM/RPM.py File RPM/RPM.py ...
1 week, 2 days ago (2017-10-12 20:27:00 UTC) #10
engr.sikandar.iqbal
I'm looking forward to knowing your opinion regarding my comments. Thanks BR, Sikandar Iqbal https://codereview.appspot.com/329400043/diff/20001/RPM/RPM.py ...
5 days, 6 hours ago (2017-10-16 22:02:25 UTC) #11
younes.tahri3
https://codereview.appspot.com/329400043/diff/20001/RPM/RPM.py File RPM/RPM.py (right): https://codereview.appspot.com/329400043/diff/20001/RPM/RPM.py#newcode50 RPM/RPM.py:50: def roulette(self,ratio): On 2017/10/12 20:27:00, Vasileios Papageorgiou wrote: > ...
4 days, 20 hours ago (2017-10-17 08:32:48 UTC) #12
younes.tahri3
Hey there, I forgot to publish my comments. Here are my replies. I hope it's ...
4 days, 19 hours ago (2017-10-17 08:38:23 UTC) #13
engr.sikandar.iqbal
4 days, 15 hours ago (2017-10-17 13:30:15 UTC) #14
Thanks!

https://codereview.appspot.com/329400043/diff/20001/RPM/RPM.py
File RPM/RPM.py (right):

https://codereview.appspot.com/329400043/diff/20001/RPM/RPM.py#newcode33
RPM/RPM.py:33: self.only_once[new_switch.id]=1
On 2017/10/17 08:38:22, younes.tahri3 wrote:
> On 2017/10/16 22:02:25, engr.sikandar.iqbal wrote:
> > what is representation 1 for?
> 
> It's just a way of calling the function using (if only once==1) only one time 

Thanks!

https://codereview.appspot.com/329400043/diff/20001/RPM/RPM.py#newcode54
RPM/RPM.py:54: return 1
On 2017/10/17 08:38:22, younes.tahri3 wrote:
> On 2017/10/16 22:02:25, engr.sikandar.iqbal wrote:
> > what 1 and 0 represent?
> 
> 1: We get the switch's RTT
> 0:We don't(sleep)

ok, i got it
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted