Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(225)

Issue 329390043: OmnipotentSnitch: added a rough approximation of a possible implementation.

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 1 day ago by seregibenjamin
Modified:
1 week, 1 day ago
Reviewers:
tonythomas
CC:
dkostic, kirill.sc, seregibenjamin, david.tomic11, cynthiamao122_gmail.com, liangzijie1437_gmail.com
Visibility:
Public.

Description

OmnipotentSnitch: added a rough approximation of a possible implementation.

Patch Set 1 #

Total comments: 3

Patch Set 2 : DatabaseDescriptor: added omnipotent_snitch parameter. #

Patch Set 3 : PropertyFileSnitch: GatewayServer should be be created in either DS or OS. #

Patch Set 4 : OmnipotentSnitch: Java is not C++. #

Patch Set 5 : OmnipotentSnitch: increasing order is what we need. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M src/java/org/apache/cassandra/locator/OmnipotentSnitch.java View 1 2 3 4 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 8
seregibenjamin
2 weeks, 1 day ago (2017-10-06 23:47:22 UTC) #1
tonythomas
Great work man. Would really appreciate making few details bit more verbose so that non-java ...
2 weeks ago (2017-10-07 10:30:24 UTC) #2
seregibenjamin
*https://codereview.appspot.com/329390043/diff/1/src/java/org/apache/cassandra/locator/OmnipotentSnitch.java#newcode81 <https://codereview.appspot.com/329390043/diff/1/src/java/org/apache/cassandra/locator/OmnipotentSnitch.java#newcode81>src/java/org/apache/cassandra/locator/OmnipotentSnitch.java:81: }I dont know about the internals, but is the python program givinglatency to ...
2 weeks ago (2017-10-07 11:23:44 UTC) #3
seregibenjamin
I would like to correct my last comment. It is not a lambda but a ...
2 weeks ago (2017-10-07 11:32:04 UTC) #4
tonythomas
Benjamin, can you please reply via the codereview tool so that later when someone look ...
2 weeks ago (2017-10-07 11:33:48 UTC) #5
seregibenjamin
Ok, sorry, I will do so. On 7 October 2017 at 13:33, Tony Thomas <01tonythomas@gmail.com> ...
2 weeks ago (2017-10-07 11:35:15 UTC) #6
seregibenjamin
1 week, 4 days ago (2017-10-10 22:09:14 UTC) #7
seregibenjamin
1 week, 1 day ago (2017-10-13 13:01:46 UTC) #8

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted